From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#32720: term-mode ignores certain window size changes Date: Sun, 04 Nov 2018 10:56:13 +0100 Message-ID: <5BDEC23D.4080707@gmx.at> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030107010800070308020701" X-Trace: blaine.gmane.org 1541325310 23052 195.159.176.226 (4 Nov 2018 09:55:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Nov 2018 09:55:10 +0000 (UTC) To: Gary Fredericks , 32720@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 04 10:55:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJF7a-0005sH-68 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Nov 2018 10:55:06 +0100 Original-Received: from localhost ([::1]:58226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJF9g-00017q-1v for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Nov 2018 04:57:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJF9W-00017Y-Cc for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2018 04:57:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJF9T-0002DD-0Q for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2018 04:57:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57312) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gJF9S-0002CQ-RX for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2018 04:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gJF9S-0003Ae-EG for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2018 04:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Nov 2018 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32720-submit@debbugs.gnu.org id=B32720.154132538212120 (code B ref 32720); Sun, 04 Nov 2018 09:57:02 +0000 Original-Received: (at 32720) by debbugs.gnu.org; 4 Nov 2018 09:56:22 +0000 Original-Received: from localhost ([127.0.0.1]:33334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJF8o-00039Q-2L for submit@debbugs.gnu.org; Sun, 04 Nov 2018 04:56:22 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:55849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJF8m-000399-CF for 32720@debbugs.gnu.org; Sun, 04 Nov 2018 04:56:20 -0500 Original-Received: from [192.168.1.101] ([46.125.249.115]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mh5h7-1fxT9p45xJ-00MIUn; Sun, 04 Nov 2018 10:56:13 +0100 Original-Received: from [192.168.1.101] ([46.125.249.115]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mh5h7-1fxT9p45xJ-00MIUn; Sun, 04 Nov 2018 10:56:13 +0100 In-Reply-To: X-Provags-ID: V03:K1:gV5kEpxvoU7D0ZeqsgJeb+r+p9gnawLc1vBWH1B+bB0cnv3Nj4Z LyY7U47y3Ep2cvRqQsyIipAaZBBa64EyyDePJjTqsJv6cGDG8GNNWKNEz1VaPJjCtp0mSaJ c9A7W2BQdL0AYhDvtIqWMO1pGCyhncSmrk0xW+yJtai9UlDnW8cvrHz/eHjTUx6WjqEectn xl1LLm1eMMU3fl9NkyrsA== X-UI-Out-Filterresults: notjunk:1;V01:K0:mIytEu/ZjTI=:F7kRiWHQFF0KU/o6CeD0wL AKtBa/XT3KFNhRAd35cLlaHS9lI2Lwd+VdeUHHxuye2QCZeYBwGMd+yuiFYMZpczoejl6zWz3 hbsQi4IL3iLx5aC761dWpwy5CvFAj/Vh4eMykZvh0mjYHGGkWkqvOEkZ8Ou45BLoeKeiYZB9H N7/Xyc/5gvXpD85qXMHuoP1plSiIm5ZOknyV4sRaxv9FBf9TQyb71txItQzBMc64eDNWsKVxy XRyfZUq5Zg0F8Ce8NODVk7h0StYRkG9PMZBNm73vSj+Tpey//kSv5IR4PQeIerM72BvtD4b/3 56WvnheWqACJMfgNVNfLItzvNT52/v4FkyheehPhH6XEu7K/lKgyqsP+buBOI9SC5R9OYYbyV fqxpaLxLM3PI3emRJ2CwfUf42HBc6ZnhRIxvMQcS7NQhNy28MuK48vOcFXgwpG80JtQPgzd+j 2a2let2TbgZk4mSCjChR0nwt+kzxfeXm4e99QSpSnGE8Skm+taqjogl9e9rJEHiClOubr4b/L TKFPMADcR1/5XDsj35SIJS2+cmehB/ASc96Kp6ZKGT5Fo3X+o7xhQbrITVl4mVvTEgRY3rBo+ aaAkRPrMsaTgqwnv/3bnYZ3130x7fnuQLWUBmsKB4U4DweNKrmXJRHviHlP9u4gOcsoBt5DBz cRYopnxA5mjL4tRUriLQskeHlCtLECWPJgSVAWyVX2aSe6uEEadSZkOeFJoWorY8yv0tCqw4t g253St3DeM514a0gNawLBCoW7QVYZNTrRKj4D1lkR4XBCdWp5I0WV7e7+NgLA7XsI1oLEEch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152003 Archived-At: This is a multi-part message in MIME format. --------------030107010800070308020701 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > *Affects*: version 26 (git-bisected to commit 8e7712c7afc) > > Note: I have only tried this on --without-x emacs > > *Steps to reproduce* > > 1. start emacs > 2. start a term buffer with M-x term > 3. run `seq 1000` at the bash prompt to fill the screen > 4. enlarge the terminal window that emacs is running in, so that the > window size changes as well > 5. run `seq 1000` again, and observe that the new space at the bottom of > the buffer is not being used > > *Analysis notes* > > term-mode *does* pick up changes after more explicit window configurations, > like splits; my workaround for months has been to split and join the > terminal window whenever I've resized it. > > As best I can tell, term-mode subscribes to window size changes by adding > advice to the window-adjust-process-window-size-function variable, and the > 8e7712c7afc reduced the set of situations in which that function is called. > > I've developed a more automated workaround with a term-load-hook of this > form: > > (add-hook 'window-size-change-functions (lambda (_frame) > (window--adjust-process-windows))) > > It might be that adding this line to the term-mode setup steps would be > sufficient, but I'm not familiar enough with the window.el code to have a > guess whether that's actually a good approach. While all you write above is correct and I agree with the fix you propose, I tend to restore the old behavior as with the attached patch. The reason is that I have no idea in how many more yet unrevealed occasions my commit had adverse effects so I'd rather be on the safe side for Emacs 26.2. Please try the patch and tell me whether it indeed restores the old behavior. Thanks, martin --------------030107010800070308020701 Content-Type: text/plain; charset=windows-1252; name="run-window-configuration-change.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="run-window-configuration-change.diff" ZGlmZiAtLWdpdCBhL3NyYy9mcmFtZS5jIGIvc3JjL2ZyYW1lLmMKaW5kZXggMGE2Y2EyNi4u ODA3NmViYSAxMDA2NDQKLS0tIGEvc3JjL2ZyYW1lLmMKKysrIGIvc3JjL2ZyYW1lLmMKQEAg LTc3OSw2ICs3NzksOCBAQCBzdHJ1Y3QgZnJhbWUgKgogCiAgIHVuYmxvY2tfaW5wdXQgKCk7 CiAKKyAgcnVuX3dpbmRvd19jb25maWd1cmF0aW9uX2NoYW5nZV9ob29rIChmKTsKKwogI2lm ZGVmIEhBVkVfV0lORE9XX1NZU1RFTQogICB7CiAgICAgLyogQWRqdXN0IHNpemUgb2YgRidz IGNoaWxkIGZyYW1lcy4gICovCmRpZmYgLS1naXQgYS9zcmMvd2luZG93LmMgYi9zcmMvd2lu ZG93LmMKaW5kZXggOTAyNmE3Yi4uZWY4OGZkZSAxMDA2NDQKLS0tIGEvc3JjL3dpbmRvdy5j CisrKyBiL3NyYy93aW5kb3cuYwpAQCAtNTcsNyArNTcsNiBAQCBzdGF0aWMgYm9vbCBmb3Jl YWNoX3dpbmRvd18xIChzdHJ1Y3Qgd2luZG93ICosCiBzdGF0aWMgYm9vbCB3aW5kb3dfcmVz aXplX2NoZWNrIChzdHJ1Y3Qgd2luZG93ICosIGJvb2wpOwogc3RhdGljIHZvaWQgd2luZG93 X3Jlc2l6ZV9hcHBseSAoc3RydWN0IHdpbmRvdyAqLCBib29sKTsKIHN0YXRpYyB2b2lkIHNl bGVjdF93aW5kb3dfMSAoTGlzcF9PYmplY3QsIGJvb2wpOwotc3RhdGljIHZvaWQgcnVuX3dp bmRvd19jb25maWd1cmF0aW9uX2NoYW5nZV9ob29rIChzdHJ1Y3QgZnJhbWUgKik7CiAKIHN0 YXRpYyBzdHJ1Y3Qgd2luZG93ICpzZXRfd2luZG93X2ZyaW5nZXMgKHN0cnVjdCB3aW5kb3cg KiwgTGlzcF9PYmplY3QsCiAJCQkJCSAgTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0KTsKQEAg LTMzMTksNyArMzMxOCw3IEBAIGRlcGVuZHMgb24gdGhlIHZhbHVlIG9mICh3aW5kb3ctc3Rh cnQgV0lORE9XKSwgc28gaWYgY2FsbGluZyB0aGlzCiAgICAgRnNlbGVjdF9mcmFtZSAoZnJh bWUsIFF0KTsKIH0KIAotc3RhdGljIHZvaWQKK3ZvaWQKIHJ1bl93aW5kb3dfY29uZmlndXJh dGlvbl9jaGFuZ2VfaG9vayAoc3RydWN0IGZyYW1lICpmKQogewogICBwdHJkaWZmX3QgY291 bnQgPSBTUEVDUERMX0lOREVYICgpOwpkaWZmIC0tZ2l0IGEvc3JjL3dpbmRvdy5oIGIvc3Jj L3dpbmRvdy5oCmluZGV4IDYyOTI4M2EuLmJjNmQ4YWIgMTAwNjQ0Ci0tLSBhL3NyYy93aW5k b3cuaAorKysgYi9zcmMvd2luZG93LmgKQEAgLTEwMTYsNiArMTAxNiw3IEBAIGV4dGVybiBM aXNwX09iamVjdCB3aW5kb3dfZnJvbV9jb29yZGluYXRlcyAoc3RydWN0IGZyYW1lICosIGlu dCwgaW50LAogZXh0ZXJuIHZvaWQgc2hyaW5rX21pbmlfd2luZG93IChzdHJ1Y3Qgd2luZG93 ICosIGJvb2wpOwogZXh0ZXJuIGludCB3aW5kb3dfcmVsYXRpdmVfeF9jb29yZCAoc3RydWN0 IHdpbmRvdyAqLCBlbnVtIHdpbmRvd19wYXJ0LCBpbnQpOwogCit2b2lkIHJ1bl93aW5kb3df Y29uZmlndXJhdGlvbl9jaGFuZ2VfaG9vayAoc3RydWN0IGZyYW1lICpmKTsKIHZvaWQgcnVu X3dpbmRvd19zaXplX2NoYW5nZV9mdW5jdGlvbnMgKExpc3BfT2JqZWN0KTsKIAogLyogTWFr ZSBXSU5ET1cgZGlzcGxheSBCVUZGRVIuICBSVU5fSE9PS1NfUCBtZWFucyBpdCdzIGFsbG93 ZWQKZGlmZiAtLWdpdCBhL3NyYy94Zm5zLmMgYi9zcmMveGZucy5jCmluZGV4IDEzODFmZWUu LjU3NGYwYmIgMTAwNjQ0Ci0tLSBhL3NyYy94Zm5zLmMKKysrIGIvc3JjL3hmbnMuYwpAQCAt MTU5OSw0ICsxNTk5LDUgQEAgc3RydWN0IG1vdXNlX2N1cnNvcl9kYXRhIHsKICAgICB9CiAj ZW5kaWYgLyogbm90IFVTRV9YX1RPT0xLSVQgJiYgbm90IFVTRV9HVEsgKi8KICAgYWRqdXN0 X2ZyYW1lX2dseXBocyAoZik7CisgIHJ1bl93aW5kb3dfY29uZmlndXJhdGlvbl9jaGFuZ2Vf aG9vayAoZik7CiB9Cg== --------------030107010800070308020701--