From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sat, 04 May 2019 18:42:33 +0200 Message-ID: <5BC29D03-3401-4348-988B-54E2DA6E844C@aol.com> References: <20190407200514.2p6gfucdcdsrqe47@Ergus> <83ef6d8c40.fsf@gnu.org> <20190408085102.ozcuvs323ilfid7n@Ergus> <83bm1g8s02.fsf@gnu.org> <20190412134633.g47vybtpkwxyw7dq@Ergus> <834l73mir0.fsf@gnu.org> <20190501110808.27o64tawy2gyjocr@Ergus> <83sgtvn08w.fsf@gnu.org> <20190503174935.5i2gn2nsxr4aezvf@Ergus> <83ftpvmlg2.fsf@gnu.org> <20190503210508.6jeebxmuocjmgva4@Ergus> <83a7g2n20d.fsf@gnu.org> <6439F397-1E34-4E09-8DD3-C50433D98131@aol.com> <83r29elbux.fsf@gnu.org> <87imuqbgqh.fsf@telefonica.net> <83k1f6ky6u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----HWOW13EPBCSDP7YEBNA6OJEY7A5R1W" Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="44684"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: K-9 Mail for Android Cc: ofv@wanadoo.es To: emacs-devel@gnu.org, Eli Zaretskii , Alp Aker Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 04 18:44:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMxlq-000BPZ-FE for ged-emacs-devel@m.gmane.org; Sat, 04 May 2019 18:44:18 +0200 Original-Received: from localhost ([127.0.0.1]:58819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMxlp-0000tK-5v for ged-emacs-devel@m.gmane.org; Sat, 04 May 2019 12:44:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMxlc-0000sm-I9 for emacs-devel@gnu.org; Sat, 04 May 2019 12:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMxlb-0000w8-Bz for emacs-devel@gnu.org; Sat, 04 May 2019 12:44:04 -0400 Original-Received: from sonic307-54.consmr.mail.ir2.yahoo.com ([87.248.110.31]:37764) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMxla-0000YR-83 for emacs-devel@gnu.org; Sat, 04 May 2019 12:44:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1556988174; bh=nojtSNd8kI8zikRo5/tPPChPC89QWd3zT1cjx/bFSuk=; h=Date:In-Reply-To:References:Subject:To:From:From:Subject; b=JXOizxBelvv/ZPT2I9QMVHrYM1jbciMqyTenRWkYd6LsYXE7pF1gYrVxsk/Yk8ZXxO1oLkzU/XIRcOG/bvSn/IHHjhVjdScw3K5hXbxa16nAiOtnRMvV+bBmvXQCpOumw/+myjyCh/mjz6HPTq3lewowug1lxBwQ2RnjYH2IIIIuHugHkYAXIflZSi3Act1nKajZBBOx+G9Ns+XL5j6nf6wrRUgcZQKuLfsiYrtZlumCTViLMTc/3b7JQ8lfB/1igx5hjdQAG2NU2AsuJM/NQ/AqG9PYVmusugbCDQSPY2Vw7NPFRI1R+08BaE+FhONJoWB9aSQAKCABVPFNxCSQ0g== X-YMail-OSG: 4dmGvMQVM1mK_axOVVrrODynKKr6qHfJqoJU6i1bZIoiN7n19ngpTPUSbYbeki9 saRw238xKiE2JbYq6ArNGBXTFz6XepEhEU5i_yOG23CfvDcwG_w0_zPeRVK.MI3_u4OAnRpFRhDN lpe.QW_v4PG2u9IVMxQXLb6ju5T8wFa6krf3sqBElHS7SeXdjZvAU3YwUc3EpcYqI5dL72xMaO9C jdWC_5VunyyEST.5Vj2Dy1nbA784NkN.Mu9Bgc2lTjoKz6itChcx_17RvszXex3Rhuv1_fVz5YuH mM16CXpyjrlwMzP7odz2nf6bxovbdnSHxs1Mkk3jVvW1KPRKK7Qb2XOvmNjytblw5IImhpyyf1Xh C2oM9SxXmVAkJEILxSNt_5r0_zPAqr7L9_2qy7Smldlf8i1.my6LI4Z6bXJgxA4JBAUvJlO6DJ.7 C5T4k3E52ToezXwm1d5l10HRyIOCd3roY1RmDihb_.WQyk6GklMxjJCTVGWidgA59mNAvs5A7TUM 7Me34pklBxxRVBHsAIBF_lSEszCjbxIHaCrDuHAsF.lKUCf.AWgezKeBmvUiDb5K7kMsCWY3aNmE .DXvwGH9yuwXPnCk08.Axrq.154w71DfIA_O3_SuDWZT0h7Tuy1ipFIc86iLBfc4WLu.Xc_sW40c 2XAgXBrKnJLdkPNbGlI4E5RgeXGkQp8CyU8JtQ8X2Qt4M9RYUOJEYnnpHK8LAdZ7y.DkvLtpIBXe U6AMrtHwTtb4G8gNHQothvEv52jdYS7XitYIPHSnObfrulbscPPXOSU_TVdxYOP9fyfNXBUfKbCt 1U95u5JslZNJVGppPO7CvK9B7KXL3XgqXYZFgxAv5x Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Sat, 4 May 2019 16:42:54 +0000 Original-Received: from 31.4.151.16 (EHLO [10.155.84.2]) ([31.4.151.16]) by smtp404.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 95701eb08cc0376caa9475d20d868837; Sat, 04 May 2019 16:42:52 +0000 (UTC) In-Reply-To: <83k1f6ky6u.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 87.248.110.31 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236161 Archived-At: ------HWOW13EPBCSDP7YEBNA6OJEY7A5R1W Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I tried a similar approach but I didn't finish it yet=2E The direct vector = modification didn't work for me =2E=2E=2E Probably because the indicator fa= ce is always reset after setting the indicator and I think the real screen = update is made after the matrix generation=2E (If I understood right how th= e display engine works) So with this approach the merge really creates a new face dynamically if n= eeded=2E Any way if that approach finally works for the general case I can fix also= the other case=2E I will try it tomorrow because today I don't have time= =2E Thanks Alp specially for the Lisp code :-)=2E On May 4, 2019 5:59:37 PM GMT+02:00, Eli Zaretskii wrote: >> From: Alp Aker >> Date: Sat, 4 May 2019 11:44:11 -0400 >> Cc: Emacs devel >>=20 >> User customization could be accommodated by something like the below >(naive) patch=2E We define >> fill-column-indicator face to have unspecified background; when >displaying the indicator we merge the >> indicator face into the current it->face_id (the same face used for >the stretch glyph preceding the indicator)=2E > >What about the case there's no stretch, i=2Ee=2E the indicator directly >follows the last character of the line? --=20 Enviado desde mi dispositivo Android con K-9 Mail=2E Por favor, disculpa m= i brevedad=2E ------HWOW13EPBCSDP7YEBNA6OJEY7A5R1W Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I tried a similar approach but I didn't finish it = yet=2E The direct vector modification didn't work for me =2E=2E=2E Probably= because the indicator face is always reset after setting the indicator and= I think the real screen update is made after the matrix generation=2E (If = I understood right how the display engine works)

So with this approa= ch the merge really creates a new face dynamically if needed=2E

Any = way if that approach finally works for the general case I can fix also the = other case=2E I will try it tomorrow because today I don't have time=2E
=
Thanks Alp specially for the Lisp code :-)=2E

On May 4, 2019 5:59:37 PM GMT+02:00, Eli Zaretskii <eliz@gnu=2E= org> wrote:
Fro=
m: Alp Aker <alptekin=2Eaker@gmail=2Ecom>
Date: Sat, 4 May 2019 11=
:44:11 -0400
Cc: Emacs devel <emacs-devel@gnu=2Eorg>

User c=
ustomization could be accommodated by something like the below (naive) patc=
h=2E  We define
fill-column-indicator face to have unspecified backgroun=
d; when displaying the indicator we merge the
indicator face into the cu=
rrent it->face_id (the same face used for the stretch glyph preceding th=
e indicator)=2E

What about the case there's no stretch,=
 i=2Ee=2E the indicator directly
follows the last character of the line?=


--
Enviado desde mi dispositivo An= droid con K-9 Mail=2E Por favor, disculpa mi brevedad=2E ------HWOW13EPBCSDP7YEBNA6OJEY7A5R1W--