From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#22000: Patch addressing the menu-bar frame-resize interaction Date: Fri, 12 Oct 2018 10:44:27 +0200 Message-ID: <5BC05EEB.9010609@gmx.at> References: <87k2p8h1vn.fsf@isaac.fritz.box> <5B4D9F5F.20506@gmx.at> <5B4EE5AF.5000304@gmx.at> <5B504994.3090202@gmx.at> <5B5199F7.7000303@gmx.at> <5B51D6C4.9030006@gmx.at> <5B52E425.8010608@gmx.at> <5B543148.1010004@gmx.at> <5B557ACA.4020106@gmx.at> <5BBF93CF.4060301@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1539333790 9071 195.159.176.226 (12 Oct 2018 08:43:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 12 Oct 2018 08:43:10 +0000 (UTC) Cc: David Engster To: Vivek Dasmohapatra , 22000@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 12 10:43:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAt2H-0002GD-T3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Oct 2018 10:43:06 +0200 Original-Received: from localhost ([::1]:39024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAt4O-00031O-Fq for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Oct 2018 04:45:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAt4D-0002zO-A3 for bug-gnu-emacs@gnu.org; Fri, 12 Oct 2018 04:45:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAt4A-0000oH-4A for bug-gnu-emacs@gnu.org; Fri, 12 Oct 2018 04:45:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41672) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gAt49-0000o3-VS for bug-gnu-emacs@gnu.org; Fri, 12 Oct 2018 04:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gAt49-0006i9-On for bug-gnu-emacs@gnu.org; Fri, 12 Oct 2018 04:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Oct 2018 08:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22000-submit@debbugs.gnu.org id=B22000.153933389425758 (code B ref 22000); Fri, 12 Oct 2018 08:45:01 +0000 Original-Received: (at 22000) by debbugs.gnu.org; 12 Oct 2018 08:44:54 +0000 Original-Received: from localhost ([127.0.0.1]:45927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAt42-0006hO-Bv for submit@debbugs.gnu.org; Fri, 12 Oct 2018 04:44:54 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:34897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAt40-0006hB-A1 for 22000@debbugs.gnu.org; Fri, 12 Oct 2018 04:44:52 -0400 Original-Received: from [192.168.1.101] ([213.162.73.29]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lg1Tn-1fs3dG3Hpr-00pZTg; Fri, 12 Oct 2018 10:44:37 +0200 Original-Received: from [192.168.1.101] ([213.162.73.29]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lg1Tn-1fs3dG3Hpr-00pZTg; Fri, 12 Oct 2018 10:44:37 +0200 In-Reply-To: X-Provags-ID: V03:K1:AVc9yqgyNS7kamXUlGjd2fLdtZ8DP2BEQ4KsNsWs1pcsUWSAIfV 04R+5AQs0CxEm07YreCa+7DveOXAy6FmFrE9RLTc/OcnoiiunTJTfVAcT/u3+ChGPZP7z98 8cdQRWudW1ovSaY1daYx1Gslv+NMzqf5d+fYuQsSP2+OCgB0QXGdCeGQEuFUk2MGX0UPx0p vTU8p5iiS2x6IaQtYgiEA== X-UI-Out-Filterresults: notjunk:1;V01:K0:64WOx5GoaI8=:rSC/bIBraeK6Kw/cV1EZ4t XpbN1oq0dDk55wNQ4qfhnLTvD0oEMhxcP9jzGfdS9GQ4dWGDmgVvcLTlkeGfU5tq51wd2ZmCH 4KUc6+LbA8Gl4dUVFvnC4VjYwkzLg7dDvkOF2/UAs9DHtiur3oYXo1bdA2zsERZXhqKsscFIE GYmFyfafcklfOdJPXTb5z5rvHV695zeWuDymIRz7MpiE+/Lt5CoNYLmOTd1+UpG2J7Xga85F9 vVP8kdrN6mJoYGOnlZgjhJl9dHbXG5XD+gORFKHJ9Ae1D49G6bjvYW1G2chwnqwYZiUXwY+IW dVf+e83HUTW1aMSSRCdolpGjEnb0upW0G35DjupE+zyvKiqQUGYf0JhIvfOHIRpiu5OAXWY9X McugQCru0HXcR6nuRWy5i4iZGyRzjPVt0UCV5RM2XEevSXm7QN23nI6spIZRiFDqFCYEAe5bO BfWJzeybsfETn+KLtRq3rtVXcggb+wcjhhw+Uv+DDj80DeZwiWqITCd+DynO4jiHv2j8IWQeT AmiPIfyphQDSc+dPmU9BvycKvL3ACKKIGSeln1Vd1JPJrsoj8FmR20p2tjQBIqvzEiufz5FnN qnFiDRbRPMATe6GA3cjhSPlcLehjTJ4lJNed0bwOG5HvChW4GVESe7pfD1rGyHfc3Hv8cZITs qtgYd/UNo9T4aVCAlKlz+Ds15HkKWIkr9SYLhGqDPNAiScURDGMfi1awHarMfZ5vTvp2daAim VYFUvMG5o2rqoMHnuK1T/uNzXlgftwlTxqso6j6cMtGauMCZbUkr3FD/xfLve9zwWiEBUoMu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151162 Archived-At: > Patchset attached. > > Rebased on: > > 5bd8cfc14d4b0c78c07e65a583f42a10c4cbc06d > Fix mishandling of symbols that look like numbers > > Built and briefly tested locally. The patchset still doesn't apply to master since master has evolved differently. I get: Hunk #1 succeeded at 5671 (offset 11 lines). Hunk #2 succeeded at 5690 (offset 11 lines). Checking patch src/gtkutil.c... error: while searching for: struct x_output *x = f->output_data.x; GtkRequisition req; GtkScrolledWindow *sw; if (!x->menubar_widget || gtk_widget_get_mapped (x->menubar_widget)) return; error: patch failed: src/gtkutil.c:3455 error: src/gtkutil.c: patch does not apply Checking patch src/xfns.c... error: while searching for: NILP (Vtool_bar_mode) ? make_number (0) : make_number (1), NULL, NULL, RES_TYPE_NUMBER); x_default_parameter (f, parms, Qbuffer_predicate, Qnil, "bufferPredicate", "BufferPredicate", RES_TYPE_SYMBOL); error: patch failed: src/xfns.c:3888 error: src/xfns.c: patch does not apply and in fact GtkScrolledWindow *sw; has been removed from the former and the latter is now NILP (Vtool_bar_mode) ? make_fixnum (0) : make_fixnum (1), NULL, NULL, RES_TYPE_NUMBER); x_default_parameter (f, parms, Qbuffer_predicate, Qnil, "bufferPredicate", "BufferPredicate", RES_TYPE_SYMBOL); So in fact we would need two different patch sets here. Let's stick with the release version for the moment: Here patches 0001 and 0002 fix the resize problem but I get a too large menu bar which makes GTK builds pretty unusable. Didn't we agree that you make the fix optional? That is, one option value (say 'truncate') for users who want the resize problem get fixed and who are willing to pay for that with a higher menu bar. And one option value (say 'resize') for users who can live with the resizing problem but care more about the height of the menu bar. > I still haven't been able to reproduced the missing menu bar symptom > you described, with or without -q. Patches 0003, 0004 and 0005 make the menu bar invisible at start (with emacs -Q) and don't allow to bring it back via M-x: menu-bar-mode. I can get it back with my customized Emacs, though. Any ideas (this is GTK version 3.4.2)? Thanks, martin