From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#56521: Add 'take' list operation [PATCH] Date: Sun, 17 Jul 2022 18:00:17 +0200 Message-ID: <5B962C97-8E34-46C2-B794-D7CA022E6F64@acm.org> References: <3D32AB50-DC48-4AAE-831C-DDAC6225DFCF@acm.org> <878royueq7.fsf@gnus.org> <71564742-E071-4ABD-B8FF-FD8CCD6079B5@acm.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1641"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56521@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 17 18:03:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oD6jU-0000Aw-R0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Jul 2022 18:03:00 +0200 Original-Received: from localhost ([::1]:39184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oD6jT-0001q6-7q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Jul 2022 12:02:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oD6ha-0008Ha-W0 for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 12:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oD6ha-0000fk-MN for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 12:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oD6ha-0007jV-Hi for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 12:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Jul 2022 16:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56521-submit@debbugs.gnu.org id=B56521.165807362929651 (code B ref 56521); Sun, 17 Jul 2022 16:01:02 +0000 Original-Received: (at 56521) by debbugs.gnu.org; 17 Jul 2022 16:00:29 +0000 Original-Received: from localhost ([127.0.0.1]:48397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oD6h2-0007iA-Hw for submit@debbugs.gnu.org; Sun, 17 Jul 2022 12:00:28 -0400 Original-Received: from mail202c50.megamailservers.eu ([91.136.10.212]:47832 helo=mail193c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oD6gy-0007ht-ET for 56521@debbugs.gnu.org; Sun, 17 Jul 2022 12:00:27 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1658073621; bh=O8p9O3UetEHKXcv7BBwZgBibyzMsk6RUxkgAiXskYRY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=aG2RNxEwZTk5MDGMz5cOArTpPW1KgXcSnrSFz1mvBCf/QEP/YCn+qS4/IBs63SKnJ kHHCZqJpsVNBdM155pBPwi7oRHuktuJZZ+QlqZiTDH+TW6pwY9v9uuGhZ3E6IH2MG4 wehxKpmFCzDNLMyaPMm3qmbOWmdp10ZAWTiqfsiI= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail193c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 26HG0Hox085427; Sun, 17 Jul 2022 16:00:19 +0000 In-Reply-To: <71564742-E071-4ABD-B8FF-FD8CCD6079B5@acm.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F27.62D43215.005F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237284 Archived-At: Not much argument here; pushed to master. A couple of notes: I went for the C implementation of `ntake` because I already had the = code, and because an elisp implementation would be slower than `take` = for short lists or small N, and there very point of `ntake` is speed. `nthcdr` has some elaborate code for handling bignum arguments which = makes some kind of sense since it's defined as an iteration of `cdr`. = Currently, `take` and `ntake` require fixnums because bignums didn't = seem to be worth the trouble. Before closing the bug, I'll make the new code pay their way by adding = some calls. `seq-take` is first in line for a makeover.