From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#32637: 27.0.50; window-size-change-functions not run from local hook Date: Sun, 09 Sep 2018 10:40:33 +0200 Message-ID: <5B94DC81.7090104@gmx.at> References: <87musx9dr1.fsf@mail.linkov.net> <5B8F8A0C.1030908@gmx.at> <87musv1ufw.fsf@mail.linkov.net> <5B90D1B8.1000203@gmx.at> <87tvn2ffgf.fsf@mail.linkov.net> <5B92296A.4020603@gmx.at> <87zhwrzgp8.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070902060304050404090509" X-Trace: blaine.gmane.org 1536482352 13086 195.159.176.226 (9 Sep 2018 08:39:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 9 Sep 2018 08:39:12 +0000 (UTC) Cc: 32637@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 09 10:39:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyvFL-0003Ji-FP for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Sep 2018 10:39:07 +0200 Original-Received: from localhost ([::1]:46502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyvHR-0001oU-IR for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Sep 2018 04:41:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyvHI-0001o5-CT for bug-gnu-emacs@gnu.org; Sun, 09 Sep 2018 04:41:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fyvHD-0002nz-B4 for bug-gnu-emacs@gnu.org; Sun, 09 Sep 2018 04:41:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45799) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fyvHC-0002n7-Qj for bug-gnu-emacs@gnu.org; Sun, 09 Sep 2018 04:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fyvHC-0001ZX-O9 for bug-gnu-emacs@gnu.org; Sun, 09 Sep 2018 04:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Sep 2018 08:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32637-submit@debbugs.gnu.org id=B32637.15364824476009 (code B ref 32637); Sun, 09 Sep 2018 08:41:02 +0000 Original-Received: (at 32637) by debbugs.gnu.org; 9 Sep 2018 08:40:47 +0000 Original-Received: from localhost ([127.0.0.1]:50816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyvGx-0001Yr-Fb for submit@debbugs.gnu.org; Sun, 09 Sep 2018 04:40:47 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:42425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyvGv-0001YZ-8l for 32637@debbugs.gnu.org; Sun, 09 Sep 2018 04:40:45 -0400 Original-Received: from [192.168.1.101] ([46.125.250.125]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LgeFd-1fTAxt0Qx3-00nzJq; Sun, 09 Sep 2018 10:40:36 +0200 In-Reply-To: <87zhwrzgp8.fsf@mail.linkov.net> X-Provags-ID: V03:K1:eOUeBITT+EuxkjekE2EIhGAoUcnIwh8OpHH2fPMK8uFD5OKH0zz 2Q1Yt+r8PS2/MilPMc0t9sRDj22wawOHGhrX5+5ISkAYdX5Y0XFg8fizJ7TRVZBOra0AIrW CFR/wjBmgoqAhtdaJaCGxmQmR1JEd6uq6btChGkzVKGyeTxRjI3aIi/ehlWHADxMi2a3iQL 8J+V5PLvN2lfpuFeVDqjQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:pTJZS+XxrtE=:RQ6oo1HoupCWqHCobZ0dHR lWdnCkTmEYJ/6f5/AoQVk7WydBemdIGBZJdwfYmLNU3oW7t7t0ZmWWVYtvKiOLFZMIC9H4cGg Ei54ad3nQcEpSwmZujOyUHkWQC+PNUCAA6Lik2IDcsbaFFQkBuw9oC/ME6tZRmK41sc5c/7+g yv6F/ZNRsHLLs6FNKOoY+Kemej+iJLIg+EfFToCg8IbSEbIvUgYHA0esZlabjBjiGm0aZKGra 2miZ+WP2fwUghNplc2Pjz+tmDtmC6j8RQHy1QDSWvTY9JNHyXZ5deYJEVz7+QEoRIym4p7bu+ PsP2vVcEuF8bJ0hZ/hfRWKZqbKpgVLjjusjghX6ou4CgvQK40TZ1/2V2zEcD+Ff47QyCnAaQT wOiU6iOSqDy8IenAom9vsNODMFFKbpWEwP156S9g3Yp51t88zpZX2UK2NxuFTd/Y3rQg6t5d/ QeM+Uq5Y+yTMmvDlC5acAY0z32qh7H79fNTetF9kLc1UvhhxGvPDzFqEWXqRQm2rV79HA6LrN zSnwtGK0QaW5EncN4NYlgwNo6/DC9DUJW2TtbIuZaxP0ynwWV4X3N0IoHYo9VJ+wAaqYPovCu WQxMx9OJpoLbH3V+RM6wucULa5148MRBqqD12dyD6YHkk+bxZkt19ktQlj6UDfXvJziFnN1Ge ttnqRpw0P9U7XjagpO13se13caDYUcAR9ZUS2A4XZiMMeTrD4a9Wwk7LXl/WF5FlPk65G6+HQ ca6JhkktnWNofW4Thrtz5tDKg1dMQ73z1kcvTgXvcPyJX97YLBhriqn2DTg= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150155 Archived-At: This is a multi-part message in MIME format. --------------070902060304050404090509 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > window-size-change-functions calling code could detect if a window with > a buffer-local hook changed its size, and not to call its hook in this > case. This would be even better than using global hook where you can't > implement such optimization. Agreed. > window-size-change-functions calling code could call it only once > for every frame, even if the same buffer is displayed in multiple > windows. Agreed. > I see that it's not called when the buffer is not displayed in any > window on the frame - this is correct. But what I noted earlier is that > it's not called when the buffer with the buffer-local hook is not the > current-buffer in the selected window (but it's displayed in a > non-selected window on the frame) - this should be fixed to call the hook > regardless if its window is currently selected or not. Agreed. I attach an untested and undocumented patch. Please have a look. martin --------------070902060304050404090509 Content-Type: text/plain; charset=windows-1252; name="window.c.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="window.c.diff" LS0tIGEvc3JjL3dpbmRvdy5jCisrKyBiL3NyYy93aW5kb3cuYwpAQCAtMzQ0Myw3ICszNDQz LDExIEBAIGRlcGVuZHMgb24gdGhlIHZhbHVlIG9mICh3aW5kb3ctc3RhcnQgV0lORE9XKSwg c28gaWYgY2FsbGluZyB0aGlzCiB7CiAgIHN0cnVjdCBmcmFtZSAqZiA9IFhGUkFNRSAoZnJh bWUpOwogICBzdHJ1Y3Qgd2luZG93ICpyID0gWFdJTkRPVyAoRlJBTUVfUk9PVF9XSU5ET1cg KGYpKTsKLSAgTGlzcF9PYmplY3QgZnVuY3Rpb25zID0gVndpbmRvd19zaXplX2NoYW5nZV9m dW5jdGlvbnM7CisKKyAgaWYgKE5JTFAgKFZydW5faG9va3MpCisgICAgICB8fCAhKGYtPmNh bl94X3NldF93aW5kb3dfc2l6ZSkKKyAgICAgIHx8ICEoZi0+YWZ0ZXJfbWFrZV9mcmFtZSkp CisgICAgcmV0dXJuOwogCiAgIGlmIChGUkFNRV9XSU5ET1dfQ09ORklHVVJBVElPTl9DSEFO R0VEIChmKQogICAgICAgLyogSGVyZSB3ZSBpbXBsaWNpdGx5IGV4Y2x1ZGUgdGhlIHBvc3Np YmlsaXR5IHRoYXQgdGhlIGhlaWdodCBvZgpAQCAtMzQ1MSwxMSArMzQ1NSw0MiBAQCBkZXBl bmRzIG9uIHRoZSB2YWx1ZSBvZiAod2luZG93LXN0YXJ0IFdJTkRPVyksIHNvIGlmIGNhbGxp bmcgdGhpcwogCSBvZiBGUkFNRSdzIHJvb3Qgd2luZG93IGFsb25lLiAgKi8KICAgICAgIHx8 IHdpbmRvd19zaXplX2NoYW5nZWQgKHIpKQogICAgIHsKLSAgICAgIHdoaWxlIChDT05TUCAo ZnVuY3Rpb25zKSkKKyAgICAgIExpc3BfT2JqZWN0IGdsb2JhbHMgPSBGZGVmYXVsdF92YWx1 ZSAoUXdpbmRvd19zaXplX2NoYW5nZV9mdW5jdGlvbnMpOworICAgICAgTGlzcF9PYmplY3Qg d2luZG93cyA9IEZ3aW5kb3dfbGlzdCAoZnJhbWUsIFFsYW1iZGEsIFFuaWwpOworICAgICAg LyogVGhlIGJ1ZmZlcnMgZm9yIHdoaWNoIHRoZSBsb2NhbCBob29rIHdhcyBhbHJlYWR5IHJ1 bi4gICovCisgICAgICBMaXNwX09iamVjdCBidWZmZXJzID0gUW5pbDsKKworICAgICAgZm9y ICg7IENPTlNQICh3aW5kb3dzKTsgd2luZG93cyA9IFhDRFIgKHdpbmRvd3MpKQorCXsKKwkg IExpc3BfT2JqZWN0IHdpbmRvdyA9IFhDQVIgKHdpbmRvd3MpOworCSAgTGlzcF9PYmplY3Qg YnVmZmVyID0gRndpbmRvd19idWZmZXIgKHdpbmRvdyk7CisKKwkgIC8qIFJ1biBsb2NhbCBo b29rIG9ubHkgaWYgdGhlIHdpbmRvdyByZWFsbHkgY2hhbmdlZCBzaXplCisJICAgICBhbmQg b25seSBvbmNlIGZvciBlYWNoIGJ1ZmZlciBpbiBjYXNlIHRoZSBidWZmZXIgaXMKKwkgICAg IHNob3duIGluIG1vcmUgdGhhbiBvbmUgd2luZG93IG9mIHRoYXQgZnJhbWUuICAqLworCSAg aWYgKHdpbmRvd19zaXplX2NoYW5nZWQgKFhXSU5ET1cgKHdpbmRvdykpCisJICAgICAgJiYg IUZtZW1xIChidWZmZXIsIGJ1ZmZlcnMpCisJICAgICAgJiYgRmxvY2FsX3ZhcmlhYmxlX3Ag KFF3aW5kb3dfc2l6ZV9jaGFuZ2VfZnVuY3Rpb25zLCBidWZmZXIpKQorCSAgICB7CisJICAg ICAgTGlzcF9PYmplY3QgbG9jYWxzCisJCT0gRmJ1ZmZlcl9sb2NhbF92YWx1ZSAoUXdpbmRv d19zaXplX2NoYW5nZV9mdW5jdGlvbnMsIGJ1ZmZlcik7CisKKwkgICAgICB3aGlsZSAoQ09O U1AgKGxvY2FscykpCisJCXsKKwkJICBpZiAoIUVRIChYQ0FSIChsb2NhbHMpLCBRdCkpCisJ CSAgICBzYWZlX2NhbGwxIChYQ0FSIChsb2NhbHMpLCBmcmFtZSk7CisJCSAgbG9jYWxzID0g WENEUiAobG9jYWxzKTsKKwkJfQorCisJICAgICAgYnVmZmVycyA9IEZjb25zIChidWZmZXIs IGJ1ZmZlcnMpOworCSAgICB9CisJfQorCisgICAgICB3aGlsZSAoQ09OU1AgKGdsb2JhbHMp KQogCXsKLQkgIGlmICghRVEgKFhDQVIgKGZ1bmN0aW9ucyksIFF0KSkKLQkgICAgc2FmZV9j YWxsMSAoWENBUiAoZnVuY3Rpb25zKSwgZnJhbWUpOwotCSAgZnVuY3Rpb25zID0gWENEUiAo ZnVuY3Rpb25zKTsKKwkgIGlmICghRVEgKFhDQVIgKGdsb2JhbHMpLCBRdCkpCisJICAgIHNh ZmVfY2FsbDEgKFhDQVIgKGdsb2JhbHMpLCBmcmFtZSk7CisJICBnbG9iYWxzID0gWENEUiAo Z2xvYmFscyk7CiAJfQogCiAgICAgICB3aW5kb3dfc2V0X2JlZm9yZV9zaXplX2NoYW5nZV9z aXplcyAocik7CkBAIC03NTU3LDYgKzc1OTIsNyBAQCBWYWx1ZSBpcyBhIGxpc3Qgb2YgdGhl IGZvcm0gKFdJRFRIIENPTFVNTlMgVkVSVElDQUwtVFlQRSBIRUlHSFQgTElORVMKICAgRnB1 dCAoUXNjcm9sbF9kb3duLCBRc2Nyb2xsX2NvbW1hbmQsIFF0KTsKIAogICBERUZTWU0gKFF3 aW5kb3dfY29uZmlndXJhdGlvbl9jaGFuZ2VfaG9vaywgIndpbmRvdy1jb25maWd1cmF0aW9u LWNoYW5nZS1ob29rIik7CisgIERFRlNZTSAoUXdpbmRvd19zaXplX2NoYW5nZV9mdW5jdGlv bnMsICJ3aW5kb3ctc2l6ZS1jaGFuZ2UtZnVuY3Rpb25zIik7CiAgIERFRlNZTSAoUXdpbmRv d3AsICJ3aW5kb3dwIik7CiAgIERFRlNZTSAoUXdpbmRvd19jb25maWd1cmF0aW9uX3AsICJ3 aW5kb3ctY29uZmlndXJhdGlvbi1wIik7CiAgIERFRlNZTSAoUXdpbmRvd19saXZlX3AsICJ3 aW5kb3ctbGl2ZS1wIik7Cgo= --------------070902060304050404090509--