From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#22000: Patch addressing the menu-bar frame-resize interaction Date: Tue, 17 Jul 2018 09:48:47 +0200 Message-ID: <5B4D9F5F.20506@gmx.at> References: <87k2p8h1vn.fsf@isaac.fritz.box> <5B4C4911.8040900@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1531813693 28390 195.159.176.226 (17 Jul 2018 07:48:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Jul 2018 07:48:13 +0000 (UTC) Cc: 22000@debbugs.gnu.org, David Engster To: Vivek Dasmohapatra Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 17 09:48:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffKiM-0007Eo-NG for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jul 2018 09:48:06 +0200 Original-Received: from localhost ([::1]:57531 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffKkT-0005J8-KF for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jul 2018 03:50:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffKkI-0005Ii-C1 for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 03:50:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffKkF-0006lj-BV for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 03:50:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39361) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffKkF-0006lT-5U for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 03:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ffKkE-0006v9-Jx for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 03:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jul 2018 07:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22000-submit@debbugs.gnu.org id=B22000.153181375026531 (code B ref 22000); Tue, 17 Jul 2018 07:50:02 +0000 Original-Received: (at 22000) by debbugs.gnu.org; 17 Jul 2018 07:49:10 +0000 Original-Received: from localhost ([127.0.0.1]:44379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffKjO-0006tr-Jf for submit@debbugs.gnu.org; Tue, 17 Jul 2018 03:49:10 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:59333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffKjM-0006ta-75 for 22000@debbugs.gnu.org; Tue, 17 Jul 2018 03:49:08 -0400 Original-Received: from [192.168.1.101] ([213.162.73.72]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MWPOI-1fZMIJ3UTK-00Xb1E; Tue, 17 Jul 2018 09:48:53 +0200 In-Reply-To: X-Provags-ID: V03:K1:0zXNp9kzq1y2NqGEytrX1q2cB7DPK/Aj8ffVk0nb56dVuR9nHVw fy8cKD5tWxs93GFTUmIquBRCh3WsFsWwIl8GA97BO3UUwzOCJ2uUI2ic3ZTeIspMWpCiv6X ZrKLG+JO8IO85P4JkZShqzIu98IvZ6x9ZHWbrvNJRxKuKniFuYUnFUql3KeYJ0DvB4OZUgj yjqwy4xO5R28Cxt6PLc6A== X-UI-Out-Filterresults: notjunk:1;V01:K0:AWY0IDNhayE=:H9bY3C6yyR/wS8QprfzKjA 6sMSQMKs8fI90iQUeKdEMfnoDSAxXqYRMjd7Ppzk6W2H8ZCOzaMcbv2PB+uwoBXu9ZalJgrqx +f9HzdYULN8F0NrtgkdGubv+u/+uqOhHqJ0LeZJOxsQGQvjjwUpZRdyquFqGxjDcSqsiOxm0c 4UU85Qc2K5VNrcvxfJ+oaYM0qSSnl0D4T8rcP25yGbSrgh2c1OkGgtIg1fVilBUP0BBiFfIBm YwI7V7RMsglm+pqbgsz+EfYoZSuU9sW9Zm3LD0p44WnDas8nXsV9zAeT1HTbbtgvdwmnEqb2n 79sqlsyb+K+T+4sICBpvzMDdgk/UY8HWmPnMKMXG+T37OJ+CeJSc4Oaef5AErlDW/f5YOUlNg 2nO6A5gu5tw5rZ+/Q9lxXCc/pe/LuEJOY3mywt7cswXfPoM6c0PqQXS+ckX8hgEt7yxKyfosD V+Oxj2pzpwwmCetsjd9Ps3pZB3/7Ha1TbSmQa610sB1x6dn/KmOPbRWFiGsFXgdwOCA1JD/wd TtrE5aas/q/do+yYyWJ7PKxlhnDKIxiSD28t3oMo7+8tinRyOmtOVbpOpNgteRdBmxNrOAk/c MgA/VVqcoo3W3zgTnR7E1e0Q/uXPi7WH4d7pl5skYPrRUjQDxjetJNbzs/tA/AqFT+1VNRSft lUvn2/rVPvs41O5wIcKV/6AhmnGgp/X6Im0cOLC2AOvbrFd3Ih0kuTOAYXwpwdXr8fxgF0EiQ 17Ml2Kr3GfyZ6cy7RDqj2MYpV0NFDVP1KAb0sZpW7FFzh5E69t9Q/6T7MYJXQ5nRGL/JYZXr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148602 Archived-At: > I have #ifdef'd the calls you mentioned with GTK_CHECK_VERSION guards. Thank you. It builds here now with GTK 3.4.2 and seems to have the intended effect. > I also checked with one of the gnome/gtk devs and wrapping a > widget with strict ideas about its size is how you are supposed > to prevent its size from propagating: I suppose the menu bar is a widget we never want to resize with GTK and we want to get clipped pixelwise which means that the last (rightmost here) entry may be partially visible but opens on a mouse click and shows its submenus. This contrasts with the tool bar where we want a rightmost item either fit or be omitted, that is, never be shown partially. The major problem with your patch is that it completely breaks the initial frame geometry at least here: The nominal (outer) height of the initial frame (with emacs -Q) goes down from 749 to 731 pixels. The height of the initial window goes down from 35 lines (630 pixels) to 33 lines (595 pixels). The height of the menu bar (calculated from the remaining components because 'frame-geometry' sees no difference) seems to go up from 27 to 34 or 44 pixels which means an increase of 7 or 17 pixels. I leave it to your imagination what kind of uproar such behavior might provoke in this our community. So unless mine is very isolated, at the very least we would have to make the behavior optional in order to address the concerns of all users wrt implicit menu bar resizing and the size occupied by the menu bar. And we would have to fix the frame geometry calculations. > I suppose an alternative > would be some widget that doesn't resize or scroll at all, > but the basic approach would be the same. There should be some. I have no idea who is responsible for the tool bar behavior but IIUC that should be the way to go for the menu bar (with different clipping behavior, I suppose). Could people who reported a similar behavior (see bugs 15700, 22898, 31626) test Vivek's patch? I'm not sure whether they get this message automatically, debbugs merging has always escaped my comprehension. David, are you listening? martin