From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: enometh@meer.net, 31695@debbugs.gnu.org
Subject: bug#31695: bug-gnu-emacs@gnu.org
Date: Fri, 08 Jun 2018 10:00:42 +0200 [thread overview]
Message-ID: <5B1A37AA.6060801@gmx.at> (raw)
In-Reply-To: <83bmcmwr5h.fsf@gnu.org>
> Are you sure it's a good idea to put this on the emacs-26 branch?
Yes. As you can see from the comment back then
/* If the new current buffer doesn't appear in the selected
window, go to its old point (see bug#12208). */
if (!EQ (XWINDOW (data->current_window)->contents, new_current_buffer))
that fix was based on the wrong assumption that data->current_window
_is_ the selected window. It is not when data->current_window is not
on the selected frame. That was a thinko and the fix on Emacs 26
corrects it.
> This bug is a mere annoyance, and happens with quite a peculiar frame
> configuration that's probably rarely used, judging by the time it took
> us to collect only 2 reports about it, since the bug was introduced.
> OTOH, we have a somewhat poor record regarding correctness in that
> area, so it's quite possible this fix introduces some new issue.
Maybe we didn't get more reports because some people thought that the
"annoyance" is the expected behavior. Even the OP was "hesitant" to
file the report.
> So unless you are really, REALLY sure this should go to emacs-26, I'd
> prefer to have it on master, and let the dust settle on it before we
> decide it's TRT.
The only justifiable alternative I see is to revert the fix for
Bug#12208 on Emacs 26 since that bug is even more obscure than the
present one.
But whatever you decide the responsibility will be all mine.
martin
next prev parent reply other threads:[~2018-06-08 8:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-03 4:47 bug#31695: bug-gnu-emacs@gnu.org Madhu
2018-06-03 12:21 ` martin rudalics
2018-06-03 16:38 ` Eli Zaretskii
2018-06-04 16:29 ` Eli Zaretskii
2018-06-05 13:36 ` martin rudalics
2018-06-04 20:40 ` Gemini Lasswell
2018-06-05 13:37 ` martin rudalics
2018-06-07 8:39 ` martin rudalics
2018-06-07 15:30 ` Eli Zaretskii
2018-06-08 8:00 ` martin rudalics [this message]
2018-06-08 8:18 ` Eli Zaretskii
[not found] ` <<83po11vghl.fsf@gnu.org>
2018-06-08 13:58 ` Drew Adams
2018-06-08 14:36 ` Eli Zaretskii
2018-06-08 14:38 ` Robert Pluim
[not found] ` <<<83po11vghl.fsf@gnu.org>
[not found] ` <<0b7a8176-03d2-4efd-bf60-e193e8433f85@default>
[not found] ` <<83a7s5uyzi.fsf@gnu.org>
2018-06-08 14:47 ` Drew Adams
2018-06-14 3:32 ` bug#31695: minibuffer command takes window-point from another frame displaying the same buffer Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B1A37AA.6060801@gmx.at \
--to=rudalics@gmx.at \
--cc=31695@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=enometh@meer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.