From: martin rudalics <rudalics@gmx.at>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 31312@debbugs.gnu.org, Andrea Cardaci <cyrus.and@gmail.com>
Subject: bug#31312: Segmentation fault with doom-emacs, NeoTree and Zoom
Date: Wed, 02 May 2018 08:16:26 +0200 [thread overview]
Message-ID: <5AE957BA.6000809@gmx.at> (raw)
In-Reply-To: <87o9hznfam.fsf@gmail.com>
>> Is w in reconsider_clip_changes the same as XWINDOW (selected_window)
>> when it fails?
>
> Nope. In fact, doing
>
> break 13939 if (w != XWINDOW(selected_window))
>
> triggers only just before the bad reconsider_clip_changes call.
>
> #0 redisplay_internal () at ../../src/xdisp.c:13939
> #1 0x0000000000463c16 in redisplay () at ../../src/xdisp.c:13518
> #2 0x00000000005851ae in read_char (commandflag=1, map=XIL(0x5e99db3), prev_event=XIL(0),
> used_mouse_menu=0x7fffffffe41f, end_time=0x0) at ../../src/keyboard.c:2480
> #3 0x00000000005957c5 in read_key_sequence (keybuf=0x7fffffffe570, bufsize=30, prompt=XIL(0),
> dont_downcase_last=false, can_return_switch_frame=true, fix_current_buffer=true,
> prevent_redisplay=false) at ../../src/keyboard.c:9147
> #4 0x0000000000581d55 in command_loop_1 () at ../../src/keyboard.c:1368
> (More stack frames follow...)
> (gdb) p w
> $16 = (struct window *) 0x47d22f0
> (gdb) p sw
> $17 = (struct window *) 0x47d22f0
> (gdb) p XWINDOW(selected_window)
> $18 = (struct window *) 0x61109d0
> (gdb) p w->contents
> $19 = XIL(0)
> (gdb) p XWINDOW(selected_window)->contents
> $20 = XIL(0x493e565)
> (gdb) xpr
> Lisp_Vectorlike
> PVEC_BUFFER
> $21 = (struct buffer *) 0x493e560
> (unsigned char *) 0x4a34568 " *NeoTree*"
I'm probably too silly to understand this. IIUC we are here
/* do_pending_window_change could change the selected_window due to
frame resizing which makes the selected window too small. */
if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw)
sw = w;
/* Clear frames marked as garbaged. */
clear_garbaged_frames ();
/* Build menubar and tool-bar items. */
if (NILP (Vmemory_full))
prepare_menu_bars ();
reconsider_clip_changes (w);
and the only ways this could cause w != XWINDOW(selected_window)
before the last call is either !WINDOWP (selected_window) or that
clear_garbaged_frames or prepare_menu_bars change selected_window.
Can you find the responsible?
martin
next prev parent reply other threads:[~2018-05-02 6:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-29 10:56 bug#31312: Segmentation fault with doom-emacs, NeoTree and Zoom Andrea Cardaci
2018-05-01 13:25 ` Noam Postavsky
2018-05-01 14:33 ` martin rudalics
2018-05-01 23:10 ` Noam Postavsky
2018-05-02 6:16 ` martin rudalics [this message]
2018-05-02 11:52 ` Eli Zaretskii
2018-05-02 12:21 ` Noam Postavsky
2018-05-02 12:45 ` Eli Zaretskii
2018-05-02 13:27 ` Andrea Cardaci
2018-05-02 13:47 ` martin rudalics
2018-05-02 15:06 ` Andrea Cardaci
2018-05-02 15:06 ` Eli Zaretskii
2018-05-02 15:14 ` Andrea Cardaci
2018-05-02 15:30 ` Eli Zaretskii
2018-05-02 13:42 ` martin rudalics
2018-05-02 15:03 ` Eli Zaretskii
2018-05-02 18:43 ` martin rudalics
2018-05-02 19:02 ` Eli Zaretskii
2018-05-03 7:11 ` martin rudalics
2018-05-03 0:04 ` Noam Postavsky
2018-05-03 2:32 ` Eli Zaretskii
2018-05-03 12:21 ` Noam Postavsky
2018-05-03 17:54 ` Eli Zaretskii
2018-05-04 1:18 ` Noam Postavsky
2018-05-02 13:42 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AE957BA.6000809@gmx.at \
--to=rudalics@gmx.at \
--cc=31312@debbugs.gnu.org \
--cc=cyrus.and@gmail.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.