From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59498: 29.0.50; c++-ts-mode get wrong-type-argument error when enabled Date: Sat, 26 Nov 2022 14:11:48 -0800 Message-ID: <5ADA88E0-A105-47B5-B590-2591253781C1@gmail.com> References: <6_5zC6qq_eQV2whwZ7epZMUlEN-yk5iOlJBLuVnNDLzl4RUGCPFnbIN12pG-DyNvCAYlRJTTopEe_RxX2_B7nSJQyBCJrzo915uBA51qW8A=@rjt.dev> <838rjyt15i.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14585"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Randy Taylor , aqua0210@foxmail.com, 59498@debbugs.gnu.org, mardani29@yahoo.es To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 23:13:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oz3Q8-0003dJ-A2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 23:13:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oz3Q0-00019h-Oo; Sat, 26 Nov 2022 17:13:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz3Pz-00019Y-BW for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 17:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oz3Py-0003Kd-Lp for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 17:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oz3Py-0007pz-24 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 17:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 22:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59498 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59498-submit@debbugs.gnu.org id=B59498.166950072130101 (code B ref 59498); Sat, 26 Nov 2022 22:13:02 +0000 Original-Received: (at 59498) by debbugs.gnu.org; 26 Nov 2022 22:12:01 +0000 Original-Received: from localhost ([127.0.0.1]:41616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz3Oz-0007pM-Ak for submit@debbugs.gnu.org; Sat, 26 Nov 2022 17:12:01 -0500 Original-Received: from mail-pg1-f172.google.com ([209.85.215.172]:42664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz3Ou-0007pG-F0 for 59498@debbugs.gnu.org; Sat, 26 Nov 2022 17:11:59 -0500 Original-Received: by mail-pg1-f172.google.com with SMTP id h33so1738133pgm.9 for <59498@debbugs.gnu.org>; Sat, 26 Nov 2022 14:11:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kTeUzIeEBS9AealVTybmBRWmzN1ZR9Spj979j6vZJDQ=; b=jswTZ3rrR53Ku6at7rqiix4ZZgzxxWRMYT9xq6uRz1hPtOdIRUrAlZsedLwoi5YK8h UlTRTgyEt13YjwOGRDkbjaNasKX0/b2VBB2F+cSNT1hyOiYLTot+ksVYvDImPxDasBax BcccnMiyWqofCX9f/ywNfQi4M933Q1R4qDUdDfLMfOCcF6PMxsGBg8p1UOp+Ba4v3mG/ bgnZkVM021FccGCe5vsv3k3O0qwdh5bp/5zy8k9esSrZpF6x/teQknX6D1mbdDXGoE6J UogO8KTXoSpmmWK5zagYmJ8tVYei/HlIAXyGseQEzZGfObnjOerfWoccML7ROQ2lzjED 2H2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kTeUzIeEBS9AealVTybmBRWmzN1ZR9Spj979j6vZJDQ=; b=kkjGYB4CY4Gbi0sQrtaR0E9QvF5PhWutly0otZvXgcMv/gU5hRimJo1pkk8StJtF+b siqMviOMSDRgCfhfpGDfMoLaSy97kyhNEGeNRB3RNbPFwiL8F3BRzv21GxI91B4ADBad BI9oAm2rGkZSkDJ2lRd4mkMd9NDyd3UdvsUO6iU2GgI16zOY4Cz+HniqKTX00y5JN6o+ COVUOgVh3bmQ0zV5yqoBwtww9a/mDbtxycTcyWrbF+lwvC3wpmAV3fW9o9fKCOPZ0AJP K59uGCgTS8K69KlD16uY3HIW0CxPTw4fjEI2LN5a0cVGjuvfnyTYVVvB9edEYDbaKczV tkbw== X-Gm-Message-State: ANoB5pk22UJFVoHrkCu/5hNAdf7n0XLwo6XNQBTa9tCcGL8iqEJrsxNV ImVLx24mgoTO3vpXT6ya4mg= X-Google-Smtp-Source: AA0mqf5UmzNecsvOIi7Uua8hosuA46MiGP/Eirtzswa7f79Ce9SnDkhH7eF25IdqAONGeVzeiYbhGw== X-Received: by 2002:aa7:84c7:0:b0:574:9b8d:1873 with SMTP id x7-20020aa784c7000000b005749b8d1873mr12667054pfn.75.1669500710353; Sat, 26 Nov 2022 14:11:50 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id i5-20020a17090a2a0500b001fe39bda429sm4940639pjd.38.2022.11.26.14.11.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Nov 2022 14:11:49 -0800 (PST) In-Reply-To: <838rjyt15i.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249146 Archived-At: > On Nov 26, 2022, at 3:18 AM, Eli Zaretskii wrote: >=20 >> Cc: Yuan Fu , 59498@debbugs.gnu.org, >> Daniel Mart=C3=ADn >> Date: Thu, 24 Nov 2022 14:39:19 +0000 >> From: Randy Taylor >>=20 >> diff --git a/lisp/progmodes/c-ts-mode.el = b/lisp/progmodes/c-ts-mode.el >> index fc35d9aedda..48f504214e2 100644 >> --- a/lisp/progmodes/c-ts-mode.el >> +++ b/lisp/progmodes/c-ts-mode.el >> @@ -570,6 +570,8 @@ c++-ts-mode >> (setq-local comment-start "// ") >> (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") >> (setq-local comment-end "") >> + (setq-local treesit-comment-start (rx "/" (or (+ "/") (+ "*")))) >> + (setq-local treesit-comment-end (rx (+ (or "*")) "/")) >>=20 >> (treesit-parser-create 'cpp) >=20 > Thanks, but this doesn't look right to me: why should c++-ts-mode set > variables for treesit.el? It is more likely that treesit.el should = use the > buffer-local values of comment-start and comment-end instead, and fall = back > on generic values (if they make sense) only if the local values are = not set. >=20 > Yuan, WDYT? I added treesit-comment-start/end to help indenting comments. So this is = the correct way to use them. The following comment explains why I = created new variables: ;; `comment-start' and `comment-end' assume there is only one type of ;; comment, and that the comment spans only one line. So they are not ;; sufficient for our purpose. Yuan=