From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#30819: [Bug #19655] Patches for GNU Emacs Date: Mon, 26 Mar 2018 11:01:42 +0200 Message-ID: <5AB8B6F6.3090908@gmx.at> References: , <5AAA2CF8.3090001@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1522054818 4215 195.159.176.226 (26 Mar 2018 09:00:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Mar 2018 09:00:18 +0000 (UTC) To: Simona Arizanova , 30819@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 26 11:00:14 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0Nz7-0000vo-9Z for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Mar 2018 11:00:09 +0200 Original-Received: from localhost ([::1]:55306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0O1A-0005iJ-Jm for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Mar 2018 05:02:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0O11-0005hv-I2 for bug-gnu-emacs@gnu.org; Mon, 26 Mar 2018 05:02:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0O0w-00036U-LQ for bug-gnu-emacs@gnu.org; Mon, 26 Mar 2018 05:02:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45718) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0O0w-00036F-HU for bug-gnu-emacs@gnu.org; Mon, 26 Mar 2018 05:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f0O0w-0002lg-1i for bug-gnu-emacs@gnu.org; Mon, 26 Mar 2018 05:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Mar 2018 09:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30819 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30819-submit@debbugs.gnu.org id=B30819.152205491610626 (code B ref 30819); Mon, 26 Mar 2018 09:02:02 +0000 Original-Received: (at 30819) by debbugs.gnu.org; 26 Mar 2018 09:01:56 +0000 Original-Received: from localhost ([127.0.0.1]:53615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0O0p-0002lK-R8 for submit@debbugs.gnu.org; Mon, 26 Mar 2018 05:01:55 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:43065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0O0n-0002l6-Kb for 30819@debbugs.gnu.org; Mon, 26 Mar 2018 05:01:54 -0400 Original-Received: from [192.168.1.100] ([212.95.5.245]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MRXVc-1f71ow3kaG-00Sh32; Mon, 26 Mar 2018 11:01:46 +0200 In-Reply-To: X-Provags-ID: V03:K0:OgKNLSjNhPmqd2axhDJklDDFO+Sw1jPvhjlrJZK3w9uceVKh4IV V9PHHE/5rkmiRpDu3wVwaBpR9m8ngX3U+Xe9vO8xUMlZCAGkMAwpJC/Yrzz4cnz1yTu3cpP TjfjzcpnKUGJS4x0y7A6BW87Gk+7F08iNmrpUPFQu8vbKmYxWUxXJX/QZCq6Uyt6mJsrvB0 WAwCvCgXtXgYip4yjBeiw== X-UI-Out-Filterresults: notjunk:1;V01:K0:9lmIVMPP4Ko=:an0SQ7d3Q8QqBXKPusPNwH HgOepXWDnjnBMkrfBEyH5RAQAoe3Udvp/BpP4841OMIBCNOV078uVtlXGxR8nYWv5y6xzTW34 0ejhxd0VCve49jL2kAf480i4RmaYq+uaCIYFpTBOQVysDQOrqwWn7+dzkZIoO0vt1oXYn/OWJ 10aBsdUtk83ozvpPjT82yd+jwR5HZ46WJY3rqn/x8RSnxscq0V9D0er0+FaXVe2VtCrlQWuXI +MPC1fyLVnDjjL0oMxRBOMO3L180cGgBDHLcIVexHp6Meq73f0E6RhDZwuLEIAr6C+eCU4yqq SriuG3PgMA8Qeu891iCmgobCINvwNosKGQm1cNVMwFmHQoW3/JOVLaKwhBP2veCI+t1Gvv2VN ybwBjN9xvjTbPfKGK8FX8Fa9Rpcjv6QNV6lwYxPpRl05RXXbZuDBk/8/clqsdJQ/st9qtaTrB L/KOl/OejttXOyh5ELmusCkJzQTlF/zPPDBaUU/qVK/FtCOCt3UJlBonOReaqVpmvXLu4hgRH YHi4DzBWBBnur8JBhs7QRO3HQNC6vVXt8hGRubCMa3VZRvcDkpPovDEhQvA6CIo6d5WEHlXfv Cq/B6CrOXxzf/+2K/QESaLu7d4B8rD3Ro/j8LukOwPgAR2nRZQQKk4LzxW5a3hVR4/PK8mycY J+ZUeEYQVhBuInkjJW5jvgkPy8Nqy+rvdZULIV2G1ZFtsRcxt/0A0YIwb7MUJnYT7axU94DFD PX3saVM1Xh/bvoNWU2cngVyN0DcgjBN+MC/KYrjd+6WUKSIPa+X8vOLGpJWadmZzfSrSyZ9j X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144621 Archived-At: Please always make sure to send a copy to the bug address too. > I'm sorry for the delay. My apologies. I was delayed as well. > Here I joined a text file that contains the diffs in the correct order. Thank you. But we now lost the identification of the file to be patched. Please try to make sure that the beginning of such a patch appears like --- a/lisp/help.el 2018-03-03 15:09:47.652000000 +0100 +++ b/lisp/help.el 2018-03-09 20:14:31.492000000 +0100 A few minor comments below: -(defun search-forward-help-for-help() Please always leave one space between function name and arguments as in: -(defun search-forward-help-for-help () - "Allows to research forward a string into the *Metahelp* window" Please always use active voice for doc-strings and terminate them with a period as: - "Search forward *Metahelp* window." (I think you really mean search and not "re"search forward here.) Maybe we also should simply say "help window" instead of " *Metahelp* window". There is no well established nomenclature for this object and few people have an idea what *Metahelp* stands for (and whether it contains a leading space). - (interactive) - ;;Moves the cursor to the *Metahelp* window Please always leave a space after a comment delimiter and use active voice for comments as well and terminate them with a period as: - ;; Move cursor to the *Metahelp* window. The - ;; Do incremental search forward. below is well written in this regard. - (switch-to-buffer-other-window " *Metahelp*") Can you add a comment that explains why you use 'switch-to-buffer-other-window' (and not, for example, 'pop-to-buffer') here? - (isearch-forward nil 1)) Please always use nil or t for inherently boolean arguments like NO-RECURSIVE-EDIT, so - (isearch-forward nil t)) is preferable here. Also, I assume that you have not signed legal papers for Emacs so we have to mark this as a tiny change. Correct? Thanks again for working on this, martin