From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 30320@debbugs.gnu.org, jake.goulding@gmail.com
Subject: bug#30320: 26.0.91; Crash when using lsp-ui-doc-mode
Date: Sun, 11 Feb 2018 10:36:10 +0100 [thread overview]
Message-ID: <5A800E8A.8020807@gmx.at> (raw)
In-Reply-To: <8337283im3.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
>> Maybe a simpler fix would be to process the 'min-width' and
>> 'min-height' frame parameters for graphic frames only.
>
> But then we will not be able to resize TTY frames, is that true? I
> think that ability is a feature we shouldn't lose, as it could be
> useful, certainly with terminal emulators.
Don't worry. The attached patch will make Emacs 26 behave just like
its predecessors with TTY frames.
The 'min-width' and 'min-height' parameters have been added to allow
people to shrink frames to one line just as they can do with tooltip
frames. They hardly make sense for TTY frames.
martin
[-- Attachment #2: frame.c.diff --]
[-- Type: text/plain, Size: 790 bytes --]
diff --git a/src/frame.c b/src/frame.c
index d5b080d..ecab7fe 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -350,10 +350,13 @@ struct frame *
struct frame *f = XFRAME (frame);
Lisp_Object par_size;
- if ((!NILP (horizontal)
- && NUMBERP (par_size = get_frame_param (f, Qmin_width)))
- || (NILP (horizontal)
- && NUMBERP (par_size = get_frame_param (f, Qmin_height))))
+ /* The 'min-width' and 'min-height' parameters have no effect on TTY
+ frames. */
+ if (!(FRAME_TERMCAP_P (f) || FRAME_MSDOS_P (f))
+ && ((!NILP (horizontal)
+ && NUMBERP (par_size = get_frame_param (f, Qmin_width)))
+ || (NILP (horizontal)
+ && NUMBERP (par_size = get_frame_param (f, Qmin_height)))))
{
int min_size = XINT (par_size);
next prev parent reply other threads:[~2018-02-11 9:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 15:10 bug#30320: 26.0.91; Crash when using lsp-ui-doc-mode Jake Goulding
2018-02-01 17:16 ` Eli Zaretskii
2018-02-01 19:52 ` Jake Goulding
2018-02-01 19:54 ` Jake Goulding
2018-02-02 8:21 ` Eli Zaretskii
2018-02-02 16:22 ` Jake Goulding
2018-02-03 9:04 ` martin rudalics
2018-02-03 16:10 ` Jake Goulding
2018-02-03 16:34 ` Eli Zaretskii
2018-02-03 19:43 ` Jake Goulding
2018-02-03 20:10 ` Eli Zaretskii
2018-02-03 21:55 ` Jake Goulding
2018-02-04 18:35 ` Eli Zaretskii
2018-02-04 21:08 ` Jake Goulding
2018-02-04 21:38 ` Jake Goulding
2018-02-05 17:03 ` Eli Zaretskii
2018-02-05 18:43 ` Jake Goulding
2018-02-05 20:14 ` Eli Zaretskii
2018-02-06 9:29 ` martin rudalics
2018-02-10 10:14 ` Eli Zaretskii
2018-02-10 10:45 ` martin rudalics
2018-02-10 12:11 ` Eli Zaretskii
2018-02-10 13:40 ` martin rudalics
2018-02-10 16:38 ` Eli Zaretskii
2018-02-11 9:36 ` martin rudalics [this message]
2018-02-11 15:43 ` Eli Zaretskii
2018-02-12 1:31 ` Jake Goulding
2018-02-12 1:33 ` Jake Goulding
2018-02-12 1:48 ` Jake Goulding
2018-02-12 9:24 ` martin rudalics
2019-10-30 11:06 ` Lars Ingebrigtsen
2018-02-12 9:22 ` martin rudalics
2018-02-12 9:22 ` martin rudalics
2018-02-12 9:22 ` martin rudalics
2018-02-12 18:04 ` Eli Zaretskii
2018-02-10 19:04 ` Jake Goulding
2018-02-02 8:27 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A800E8A.8020807@gmx.at \
--to=rudalics@gmx.at \
--cc=30320@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jake.goulding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.