From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#30399: 27.0.50; tooltips are broken Date: Fri, 09 Feb 2018 10:53:30 +0100 Message-ID: <5A7D6F9A.1010504@gmx.at> References: <87wozn9kyy.fsf@gmx.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090708010908040702090704" X-Trace: blaine.gmane.org 1518169958 6522 195.159.176.226 (9 Feb 2018 09:52:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Feb 2018 09:52:38 +0000 (UTC) To: Stephen Berman , 30399@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 09 10:52:33 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ek5Lw-0000mH-E6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Feb 2018 10:52:20 +0100 Original-Received: from localhost ([::1]:54602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ek5Nx-0001pt-V9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Feb 2018 04:54:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ek5Nd-0001n5-EN for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2018 04:54:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ek5Na-00068j-5c for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2018 04:54:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55008) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ek5NZ-00068T-W2 for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2018 04:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ek5NZ-000881-PK for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2018 04:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Feb 2018 09:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30399-submit@debbugs.gnu.org id=B30399.151817001931217 (code B ref 30399); Fri, 09 Feb 2018 09:54:01 +0000 Original-Received: (at 30399) by debbugs.gnu.org; 9 Feb 2018 09:53:39 +0000 Original-Received: from localhost ([127.0.0.1]:34672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ek5ND-00087R-8i for submit@debbugs.gnu.org; Fri, 09 Feb 2018 04:53:39 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:41079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ek5NB-00087E-8e for 30399@debbugs.gnu.org; Fri, 09 Feb 2018 04:53:37 -0500 Original-Received: from [192.168.1.100] ([213.162.73.16]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LnPnu-1fCGyi3qSU-00hhTx; Fri, 09 Feb 2018 10:53:31 +0100 In-Reply-To: <87wozn9kyy.fsf@gmx.net> X-Provags-ID: V03:K0:ZU0rpz7aBHcTTcqiaedg3M4Y0qNG2DU0mLqc0f10TsHPPDvDbwW v7YSm1HoGFAQO6Rg5sO93p5DVOF/hficGobCZYdA4gejVtzy0j+hqFZ2oX3IbWj6AfqcErk NMAvzhJ8trlPMQsKI49SgDcaJUUw2avYnlhIDnVX6SYhyV3v3ken+0fhMZXA3dYd5Ep3vx/ v764aXXF4sgnFJ2MqjNrg== X-UI-Out-Filterresults: notjunk:1;V01:K0:1TxWNjWcL0w=:EC8F9egMYxWR0hVd+UQEev V2tD87p2UYkbxmfmjcDlfblCA2V+HLc266alIlUrDK8QstWh8b7Oe+ly78MiF1ApV5fmCMMos I+O/FsVKSh9RMk486qFWuuom+laqONr6McYVD3cAu13dN5l/457LHwuWJYwc+wU70mK5En3vG WcdUwh3EMtZz9EkjJKDk4nHqJuMyisltr2PB/mJzMipAl5XnkqXqsUqGs7Xm6I9h/qwGjwpOc Wt5xVSV1uiBK3kZwnNo/aJBKVTcE6WOVYfIqFw9Frs0EwU8XX6hdjfhDTtEndcOSC1G6862mL IPTJj7yF07RH5oD6qnUzqw48t+piJ74rNrotjtPrRP3zs8TV6yrlIrs433AlUcSlu5q8NRu1t aZ5kZEFBxrsnMXqpNTrffHsVMgoU0XRPysg9lalBHWZQkzQhHUTfNPQL95wRWJU7w62a5Kdr4 glaVwArzUaLZe7J6KB22X8oAFGu/TIwFAMVo7o8dzL1TpZ+oHTX81ORxIuOX+QfhX5bGGst5L PN7ET0vj5KXN3H0SO8yns7EkIBcnC+hIlVvv5nO12fQ8or/wRU0zavB4kcVq5y7hPqJQRiPer YgwLQWKhk5AbQctv2DMoydWLokYdgA1OrIqNlIagefAVACkIbLc6SztQkPWtG5ui/kMjoNGkY S76qWM0IkMQbTh59/0H8gXBWFDOzByNM8/NbIB9pum8G7hWWTOZHeOj9Ce4ZPcSvi+gG7q77c P9UyC2SaggPUPj1laqvNSjsjOsz85Khnlh8JkkC1qtwtTzEzzZqaQnlY0tW8P1nZXDSSP1J/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143047 Archived-At: This is a multi-part message in MIME format. --------------090708010908040702090704 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > And here's the buggy behavior (starting with step 2) I see on master > since the above commit: > > 0. emacs -Q > 1. evaluate (tooltip-show "This is a test") > => A GTK+-themed tooltip is displayed for 10 seconds or until there > is an input event, then disappears. > 2. evaluate (x-show-tip "This is a test") > => A GTK+-themed tooltip is displayed and remains displayed, even if > there are input events, until executing step 3 or repeating step 1. This is due to a rather silly omission which should have already defeated a feature in Emacs 26 when calling 'x-show-tip' (you've been warned - Lisp code should call 'tooltip-show'). > 3. evaluate (let (x-gtk-use-system-tooltips) > (tooltip-show "This is a test")) > => A non-toolkit tooltip is displayed and remains displayed, even if > there are input events, until the end of the Emacs session (at least > I haven't found a way to get rid of it); however, if the GTK+-themed > tooltip from step 2 is still displayed when the above sexp is > evaluated, then after 10 (not 5) seconds the GTK+-themed tooltip > disappears (but the non-toolkit tooltip remains). > 4. evaluate (let (x-gtk-use-system-tooltips) > (x-show-tip "This is a test")) > => A non-toolkit tooltip is displayed and remains displayed, even if > there are input events, until the end of the Emacs session AFAICT; if > the tooltip from step 3 is still displayed when the above sexp is > evaluated, it is just moved by this step but does not disappear, and > if the GTK+-themed tooltip from step 2 is still displayed that > tooltip also remains displayed (unlike in step 3). Let-binding 'x-gtk-use-system-tooltips' is a more delicate issue. As a rule, options should never be let-bound but since the customizer is always right we'll probably have to fix this as well. Please try the attached fix. And please test it also with the inverse scenario (setq x-gtk-use-system-tooltips nil) (let ((x-gtk-use-system-tooltips t)) (tooltip-show "Test")) Thanks, martin --------------090708010908040702090704 Content-Type: text/plain; charset=windows-1252; name="gtk-tooltip.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="gtk-tooltip.diff" ZGlmZiAtLWdpdCBhL3NyYy94Zm5zLmMgYi9zcmMveGZucy5jDQppbmRleCBkYjFjZTMxLi45 ZjBkOTQ2IDEwMDY0NA0KLS0tIGEvc3JjL3hmbnMuYw0KKysrIGIvc3JjL3hmbnMuYw0KQEAg LTYwNzcsNyArNjA3Nyw3IEBAIHN0YXRpYyB2b2lkIGNvbXB1dGVfdGlwX3h5IChzdHJ1Y3Qg ZnJhbWUgKiwgTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0LA0KIC8qIFNUUklORyBhcmd1bWVu dCBvZiBsYXN0IGB4LXNob3ctdGlwJyBjYWxsLiAgKi8NCiBzdGF0aWMgTGlzcF9PYmplY3Qg dGlwX2xhc3Rfc3RyaW5nOw0KIA0KLS8qIEZSQU1FIGFyZ3VtZW50IG9mIGxhc3QgYHgtc2hv dy10aXAnIGNhbGwuICAqLw0KKy8qIE5vcm1hbGl6ZWQgRlJBTUUgYXJndW1lbnQgb2YgbGFz dCBgeC1zaG93LXRpcCcgY2FsbC4gICovDQogc3RhdGljIExpc3BfT2JqZWN0IHRpcF9sYXN0 X2ZyYW1lOw0KIA0KIC8qIFBBUk1TIGFyZ3VtZW50IG9mIGxhc3QgYHgtc2hvdy10aXAnIGNh bGwuICAqLw0KQEAgLTY1NDIsMTYgKzY1NDIsMjAgQEAgc3RhdGljIHZvaWQgY29tcHV0ZV90 aXBfeHkgKHN0cnVjdCBmcmFtZSAqLCBMaXNwX09iamVjdCwgTGlzcF9PYmplY3QsDQogICAg IH0NCiANCiAjaWZkZWYgVVNFX0dUSw0KLSAgLyogVGhlIEdUSysgc3lzdGVtIHRvb2x0aXAg d2luZG93IGNhbiBiZSBmb3VuZCB2aWEgdGhlIHhfb3V0cHV0DQotICAgICBzdHJ1Y3R1cmUg b2YgdGlwX2xhc3RfZnJhbWUsIGlmIGl0IHN0aWxsIGV4aXN0cy4gICovDQotICBpZiAoeF9n dGtfdXNlX3N5c3RlbV90b29sdGlwcyAmJiBOSUxQICh0aXBfbGFzdF9mcmFtZSkpDQotICAg IHJldHVybiBRbmlsOw0KLSAgZWxzZSBpZiAoIXhfZ3RrX3VzZV9zeXN0ZW1fdG9vbHRpcHMN Ci0JICAgJiYgKE5JTFAgKHRpcF9mcmFtZSkNCi0JICAgICAgIHx8ICghZGVsZXRlDQotCQkg ICAmJiBGUkFNRVAgKHRpcF9mcmFtZSkNCi0JCSAgICYmIEZSQU1FX0xJVkVfUCAoWEZSQU1F ICh0aXBfZnJhbWUpKQ0KLQkJICAgJiYgIUZSQU1FX1ZJU0lCTEVfUCAoWEZSQU1FICh0aXBf ZnJhbWUpKSkpKQ0KKyAgLyogQW55IEdUSysgc3lzdGVtIHRvb2x0aXAgY2FuIGJlIGZvdW5k IHZpYSB0aGUgeF9vdXRwdXQgc3RydWN0dXJlIG9mDQorICAgICB0aXBfbGFzdF9mcmFtZSwg cHJvdmlkZWQgdGhhdCBmcmFtZSBpcyBzdGlsbCBsaXZlLiAgQW55IEVtYWNzDQorICAgICB0 b29sdGlwIGlzIGZvdW5kIHZpYSB0aGUgdGlwX2ZyYW1lIHZhcmlhYmxlLiAgTm90ZSB0aGF0 IHRoZSBjdXJyZW50DQorICAgICB2YWx1ZSBvZiB4X2d0a191c2Vfc3lzdGVtX3Rvb2x0aXBz IG1pZ2h0IG5vdCBiZSB0aGUgc2FtZSBhcyB1c2VkDQorICAgICBmb3IgdGhlIHRvb2x0aXAg d2UgaGF2ZSB0byBoaWRlLCBzZWUgQnVnIzMwMzk5LiAgKi8NCisgIGlmICgoTklMUCAodGlw X2xhc3RfZnJhbWUpICYmIE5JTFAgKHRpcF9mcmFtZSkpDQorICAgICAgfHwgKCF4X2d0a191 c2Vfc3lzdGVtX3Rvb2x0aXBzDQorCSAgJiYgIWRlbGV0ZQ0KKwkgICYmIEZSQU1FUCAodGlw X2ZyYW1lKQ0KKwkgICYmIEZSQU1FX0xJVkVfUCAoWEZSQU1FICh0aXBfZnJhbWUpKQ0KKwkg ICYmICFGUkFNRV9WSVNJQkxFX1AgKFhGUkFNRSAodGlwX2ZyYW1lKSkpKQ0KKyAgICAvKiBF aXRoZXIgdGhlcmUncyBubyB0b29sdGlwIHRvIGhpZGUgb3IgaXQncyBhbiBhbHJlYWR5IGlu dmlzaWJsZQ0KKyAgICAgICBFbWFjcyB0b29sdGlwIGFuZCB3ZSBkb24ndCB3YW50IHRvIGNo YW5nZSBpdHMgdHlwZS4gIFJldHVybg0KKyAgICAgICBxdWlja2x5LiAgKi8NCiAgICAgcmV0 dXJuIFFuaWw7DQogICBlbHNlDQogICAgIHsNCkBAIC02NTYyLDEwICs2NTY2LDkgQEAgc3Rh dGljIHZvaWQgY29tcHV0ZV90aXBfeHkgKHN0cnVjdCBmcmFtZSAqLCBMaXNwX09iamVjdCwg TGlzcF9PYmplY3QsDQogICAgICAgc3BlY2JpbmQgKFFpbmhpYml0X3JlZGlzcGxheSwgUXQp Ow0KICAgICAgIHNwZWNiaW5kIChRaW5oaWJpdF9xdWl0LCBRdCk7DQogDQotICAgICAgaWYg KHhfZ3RrX3VzZV9zeXN0ZW1fdG9vbHRpcHMpDQorICAgICAgLyogVHJ5IHRvIGhpZGUgdGhl IEdUSysgc3lzdGVtIHRpcCBmaXJzdC4gICovDQorICAgICAgaWYgKEZSQU1FUCAodGlwX2xh c3RfZnJhbWUpKQ0KIAl7DQotCSAgLyogVGhlIEdUSysgc3lzdGVtIHRvb2x0aXAgd2luZG93 IGlzIHN0b3JlZCBpbiB0aGUgeF9vdXRwdXQNCi0JICAgICBzdHJ1Y3R1cmUgb2YgdGlwX2xh c3RfZnJhbWUuICAqLw0KIAkgIHN0cnVjdCBmcmFtZSAqZiA9IFhGUkFNRSAodGlwX2xhc3Rf ZnJhbWUpOw0KIA0KIAkgIGlmIChGUkFNRV9MSVZFX1AgKGYpKQ0KQEAgLTY1NzMsMzMgKzY1 NzYsMzcgQEAgc3RhdGljIHZvaWQgY29tcHV0ZV90aXBfeHkgKHN0cnVjdCBmcmFtZSAqLCBM aXNwX09iamVjdCwgTGlzcF9PYmplY3QsDQogCSAgICAgIGlmICh4Z19oaWRlX3Rvb2x0aXAg KGYpKQ0KIAkJd2FzX29wZW4gPSBRdDsNCiAJICAgIH0NCi0JICBlbHNlDQotCSAgICB0aXBf bGFzdF9mcmFtZSA9IFFuaWw7DQogCX0NCi0gICAgICBlbHNlDQorDQorICAgICAgLyogUmVz ZXQgdGlwX2xhc3RfZnJhbWUsIGl0IHdpbGwgYmUgcmVhc3NpZ25lZCB3aGVuIHNob3dpbmcg dGhlDQorCSBuZXh0IEdUSysgc3lzdGVtIHRvb2x0aXAuICAqLw0KKyAgICAgIHRpcF9sYXN0 X2ZyYW1lID0gUW5pbDsNCisNCisgICAgICAvKiBOb3cgbG9vayB3aGV0aGVyIHRoZXJlJ3Mg YW4gRW1hY3MgdGlwIGFyb3VuZC4gICovDQorICAgICAgaWYgKEZSQU1FUCAodGlwX2ZyYW1l KSkNCiAJew0KLQkgIGlmIChGUkFNRVAgKHRpcF9mcmFtZSkpDQotCSAgICB7DQotCSAgICAg IHN0cnVjdCBmcmFtZSAqZiA9IFhGUkFNRSAodGlwX2ZyYW1lKTsNCisJICBzdHJ1Y3QgZnJh bWUgKmYgPSBYRlJBTUUgKHRpcF9mcmFtZSk7DQogDQotCSAgICAgIGlmIChGUkFNRV9MSVZF X1AgKGYpKQ0KKwkgIGlmIChGUkFNRV9MSVZFX1AgKGYpKQ0KKwkgICAgew0KKwkgICAgICBp ZiAoZGVsZXRlIHx8IHhfZ3RrX3VzZV9zeXN0ZW1fdG9vbHRpcHMpDQogCQl7DQotCQkgIGlm IChkZWxldGUpDQotCQkgICAgew0KLQkJICAgICAgZGVsZXRlX2ZyYW1lICh0aXBfZnJhbWUs IFFuaWwpOw0KLQkJICAgICAgdGlwX2ZyYW1lID0gUW5pbDsNCi0JCSAgICB9DQotCQkgIGVs c2UNCi0JCSAgICB4X21ha2VfZnJhbWVfaW52aXNpYmxlIChmKTsNCi0NCi0JCSAgd2FzX29w ZW4gPSBRdDsNCisJCSAgLyogRGVsZXRlIHRoZSBFbWFjcyB0b29sdGlwIGZyYW1lIHdoZW4g REVMRVRFIGlzIHRydWUNCisJCSAgICAgb3Igd2UgY2hhbmdlIHRoZSB0b29sdGlwIHR5cGUg ZnJvbSBhbiBFbWFjcyBvbmUgdG8NCisJCSAgICAgYSBHVEsrIHN5c3RlbSBvbmUuICAqLw0K KwkJICBkZWxldGVfZnJhbWUgKHRpcF9mcmFtZSwgUW5pbCk7DQorCQkgIHRpcF9mcmFtZSA9 IFFuaWw7DQogCQl9DQogCSAgICAgIGVsc2UNCi0JCXRpcF9mcmFtZSA9IFFuaWw7DQorCQl4 X21ha2VfZnJhbWVfaW52aXNpYmxlIChmKTsNCisNCisJICAgICAgd2FzX29wZW4gPSBRdDsN CiAJICAgIH0NCiAJICBlbHNlDQogCSAgICB0aXBfZnJhbWUgPSBRbmlsOw0KIAl9DQorICAg ICAgZWxzZQ0KKwl0aXBfZnJhbWUgPSBRbmlsOw0KIA0KICAgICAgIHJldHVybiB1bmJpbmRf dG8gKGNvdW50LCB3YXNfb3Blbik7DQogICAgIH0NCkBAIC02NzIxLDcgKzY3MjgsMTAgQEAg d2l0aCBvZmZzZXQgRFkgYWRkZWQgKGRlZmF1bHQgaXMgLTEwKS4NCiAgIGlmIChTQ0hBUlMg KHN0cmluZykgPT0gMCkNCiAgICAgc3RyaW5nID0gbWFrZV91bmlieXRlX3N0cmluZyAoIiAi LCAxKTsNCiANCisgIGlmIChOSUxQIChmcmFtZSkpDQorICAgIGZyYW1lID0gc2VsZWN0ZWRf ZnJhbWU7DQogICBmID0gZGVjb2RlX3dpbmRvd19zeXN0ZW1fZnJhbWUgKGZyYW1lKTsNCisN CiAgIGlmIChOSUxQICh0aW1lb3V0KSkNCiAgICAgdGltZW91dCA9IG1ha2VfbnVtYmVyICg1 KTsNCiAgIGVsc2UNCg== --------------090708010908040702090704--