From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#30320: 26.0.91; Crash when using lsp-ui-doc-mode Date: Tue, 06 Feb 2018 10:29:04 +0100 Message-ID: <5A797560.9000602@gmx.at> References: <83po5oeil8.fsf@gnu.org> <83a7wrer8i.fsf@gnu.org> <5A757B30.9070402@gmx.at> <83y3ka9gmg.fsf@gnu.org> <83mv0pal74.fsf@gnu.org> <83y3k88ux5.fsf@gnu.org> <834lmv8j3u.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1517909309 30319 195.159.176.226 (6 Feb 2018 09:28:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Feb 2018 09:28:29 +0000 (UTC) Cc: 30320@debbugs.gnu.org To: Eli Zaretskii , Jake Goulding Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 06 10:28:25 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eizY1-0007CT-UT for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Feb 2018 10:28:18 +0100 Original-Received: from localhost ([::1]:45769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiza3-0008Hk-6r for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Feb 2018 04:30:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eizZn-0008Dn-56 for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2018 04:30:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eizZj-0006WG-7x for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2018 04:30:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51637) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eizZj-0006W1-46 for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2018 04:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eizZi-0004Vs-Fz for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2018 04:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Feb 2018 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30320 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30320-submit@debbugs.gnu.org id=B30320.151790935917260 (code B ref 30320); Tue, 06 Feb 2018 09:30:02 +0000 Original-Received: (at 30320) by debbugs.gnu.org; 6 Feb 2018 09:29:19 +0000 Original-Received: from localhost ([127.0.0.1]:59533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eizZ1-0004UK-G8 for submit@debbugs.gnu.org; Tue, 06 Feb 2018 04:29:19 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:56778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eizYy-0004Tz-GL for 30320@debbugs.gnu.org; Tue, 06 Feb 2018 04:29:16 -0500 Original-Received: from [192.168.1.100] ([212.95.5.24]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MVayZ-1eDFn84AEJ-00YyVX; Tue, 06 Feb 2018 10:29:10 +0100 In-Reply-To: <834lmv8j3u.fsf@gnu.org> X-Provags-ID: V03:K0:Dqv/4L3lagKH70aNmqOPlUo1T9NmXhOik5TAP7vWTQaWKZ4Y5Dm iRfkZN6ifA/I42yMidQaPscQXiXsw8nBhA7mloH/ufCrUXoPCfd+GacwjTBPLjpbD3xqn8M 0WNBCmzlE6p00fgPxyJuzd0QEkC1glRlvF79cg8QlVg0Xd9AVfPT5iykahZ/RxJ9NT7ZbJr if4f0Pk/2Cf1z5ySlRfvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:v2sNfPLzLy0=:n9CqTxxg1XsJPg9eT8n7Tf Gmsk+SzTlmHPFTw/sJN1yuGiYcgIgVVJ+4wHGVcejXRzSc0Qz2pG117zHVi7sINnAz8n1bIFV ZypVUrlX6iYgK24eI3FDjFlPt6UAJAiA8JlTZCMsPK8Mq1/n5JNYwsvMlkFF0HBpnOixxtSJM VQFwa8db+n8zpsIr2hw/tRLKH2H/j3JGZNOfR1Vn4c3Eb8m86+Ttr8YIVDadIO/QS1qBWYrVa LAKyU974jn9Lig1iPIKq95r2yypYCk10DaYnxZa8yHSqa8FE2e8C5KWSDx3dnSCUEhSIalCEC 55SonBcxHOqDr9t+wAXzJVcN/Y9ZuVixt+QeWHo7smbpYURt4XHcYYGnDdRQqYYzDWXLZpc0c sF04HMMv2knE03pLIRBHbIkVZrvIOexWxwu3QzLzAa+BI/po+wUIOHKzTdWqHLww95BnEewTV AVQ8P1rpOnnBG/+5pYylelNqZ3Xh/r4obD5rR9M736cWBp9xI1Io5owGrqQAxO3ohDARRKMfM GtOcR0Dh+LV/xQHtAB5pNZDewCt0U9SDI3NHxvrsL2I0ol2CFug1sXz+OnWxNeCi35mZfaE21 OwUdM9TY9K8miic5YTbBQBWzNpKpJNT/QJKD1ucBtOc9Ocpof5fXiXLf2nuImtvM6w9EY63lF X/lDFJvevhuYAWOOHtNnuRGGpYMLsZM4fv0+cV/gpWG1218Ri1vhNZJR8zwoAtPaHlf7xxNG9 JcWClmfXBzOO8zmoGCblSICsQhT/SfeCuQAsJ3B8OH0b3RcEcr1boqUmjCOT4wBa6XoIhCGM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142967 Archived-At: > As for preventing such crashes even though some Lisp does nonsensical > things: I think a TTY frame cannot be less than 3 or 4 lines plus the > number of lines used for the menu bar. Martin, WDYT about adding > these limitations to adjust_frame_size? A better location is when adjusting min_size in frame_windows_min_size here: int min_size = XINT (par_size); /* Don't allow phantom frames. */ if (min_size < 1) min_size = 1; As you see we currently allow 1 here for width and height measured in characters. Feel free to change this any way you want - FRAME_TERMCAP_P conditioned it shouldn't hurt and be suitable for the release version. If you want me to do it, please tell me the value(s) you consider appropriate and where to apply it. I never cared about this because I never was able to crash Emacs when using small sizes. martin