all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: m.sujith@gmail.com, 30182@debbugs.gnu.org
Subject: bug#30182: Update
Date: Sun, 04 Feb 2018 11:01:03 +0100	[thread overview]
Message-ID: <5A76D9DF.6040704@gmx.at> (raw)
In-Reply-To: <83efm2bc3m.fsf@gnu.org>

 > That commentary was outdated.  I updated it now.

Thanks.

 > Please take a look
 > and tell if anything there needs clarification or any other change.

One question I'd ask myself is how we avoid that redisplay is
reentered during maybe_quit.  And I would like to know which settings
can disrupt redisplay and whether and which, if any, parts of
redisplay (mode lines and echo area) may get through after such a
disruption, probably to avoid garbling the display.

 > I believe that what I wrote in the message to which you were replying
 > was based on incorrect interpretation of what actually happens.  With
 > the correct interpretation, there's no asynchronous entry into
 > redisplay, if "asynchronous" is interpreted literally.  So the
 > measures I described above are unnecessary, but there is a need to
 > block input around C fragments that cannot tolerate changes in global
 > state.

I must admit that I never thought of maybe_quit being able to process
input when a function like 'copy-sequence' executes "normally".  Maybe
this should be emphasized in the Elisp manual's section on Quitting.
I don't even understand what it's good for to process input just after
a few conses or calculating the length of some short list.

 > This now raises the question: should we block input around the 2 calls
 > to Fcopy_sequence in timer_check, on the emacs-26 branch?  I tend to
 > think we should, because letting arbitrary Lisp change the timer lists
 > while Fcopy_sequence runs could cause hard-to-debug bugs.  WDYT?

It cannot possibly harm so I think we should.

 >> And one thing that is obviously needed is some guidance on what should
 >> be allowed in the mode line and what should be avoided.  For example,
 >> having `mode-line-buffer-identification' install a timer is something
 >> that should be avoided IMO.
 >
 > If we protect Fcopy_sequence as indicated above, I think such a
 > limitation would no longer be necessary.

If the :eval form in 'mode-line-format' changes an arbitrary list
which is about to be copied, a similar crash could be provoked.  Or am
I missing something?

martin





  reply	other threads:[~2018-02-04 10:01 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-20  6:26 bug#30182: 27.0.50; Crash when doing mouse-over on modeline Sujith
2018-01-20  6:28 ` bug#30182: Update Sujith
2018-01-20 10:35   ` martin rudalics
2018-01-20 10:45     ` Sujith
2018-01-20 14:12       ` martin rudalics
2018-01-20 15:27         ` Eli Zaretskii
2018-01-21  2:15         ` Sujith
2018-01-21  3:39           ` Eli Zaretskii
2018-01-21  3:55             ` Sujith
2018-01-21 16:15               ` Eli Zaretskii
2018-01-21 18:29                 ` Sujith
2018-01-22  9:15                   ` martin rudalics
2018-01-22 15:09                     ` Sujith
2018-01-22 17:37                       ` Eli Zaretskii
2018-01-22 18:59                         ` martin rudalics
2018-01-22 20:40                           ` Eli Zaretskii
2018-01-23 18:44                             ` martin rudalics
2018-01-23 19:53                               ` Eli Zaretskii
2018-01-24  8:39                                 ` martin rudalics
2018-01-23  2:49                           ` Sujith
2018-01-23 16:18                             ` Eli Zaretskii
2018-01-23 17:07                               ` Sujith
2018-01-23 17:25                                 ` Eli Zaretskii
2018-01-23 18:10                                   ` Eli Zaretskii
2018-01-23 18:45                                     ` martin rudalics
2018-01-23 19:51                                       ` Eli Zaretskii
2018-01-24  8:38                                         ` martin rudalics
2018-01-24 19:10                                           ` Eli Zaretskii
2018-01-24 20:05                                             ` martin rudalics
2018-01-23 18:44                                   ` martin rudalics
2018-01-23 19:59                                     ` Eli Zaretskii
2018-01-24  8:39                                       ` martin rudalics
2018-01-24 19:13                                         ` Eli Zaretskii
2018-01-24 20:06                                           ` martin rudalics
2018-01-27  8:26                             ` martin rudalics
2018-01-28  0:53                               ` Sujith
2018-01-28  8:26                                 ` martin rudalics
2018-01-29  5:13                                   ` Sujith
2018-01-29 10:04                                     ` martin rudalics
2018-01-29 15:50                                       ` Eli Zaretskii
2018-01-30  8:30                                         ` martin rudalics
2018-01-30 13:32                                           ` Eli Zaretskii
2018-01-31  9:31                                             ` martin rudalics
2018-01-31 14:43                                               ` Eli Zaretskii
2018-02-01  2:29                                               ` Sujith
2018-02-01  9:26                                                 ` martin rudalics
2018-02-01 17:44                                                   ` Eli Zaretskii
2018-02-02  8:28                                                     ` martin rudalics
2018-02-02  8:37                                                       ` martin rudalics
2018-02-02 16:00                                                       ` Eli Zaretskii
2018-02-03  9:03                                                         ` martin rudalics
2018-02-03 10:29                                                           ` Eli Zaretskii
2018-02-04 10:01                                                             ` martin rudalics [this message]
2018-02-04 18:21                                                               ` Eli Zaretskii
2018-02-06  9:28                                                                 ` martin rudalics
2018-02-10  9:47                                                                   ` martin rudalics
2018-02-02 14:14                                                     ` Noam Postavsky
2018-02-02 16:11                                                       ` Eli Zaretskii
2018-02-03  9:04                                                       ` martin rudalics
2018-02-03 10:30                                                         ` Eli Zaretskii
2018-02-04 10:01                                                           ` martin rudalics
2018-02-04 18:01                                                             ` Eli Zaretskii
2018-01-29 15:53                                   ` Eli Zaretskii
2018-01-30  8:30                                     ` martin rudalics
2018-01-30 13:34                                       ` Eli Zaretskii
2018-01-31  9:31                                         ` martin rudalics
2018-01-31 14:44                                           ` Eli Zaretskii
2018-01-21 18:37           ` Sujith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A76D9DF.6040704@gmx.at \
    --to=rudalics@gmx.at \
    --cc=30182@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=m.sujith@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.