all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: "Basil L. Contovounesios" <contovob@tcd.ie>, 30207@debbugs.gnu.org
Subject: bug#30207: 27.0.50; [PATCH] other-window-for-scrolling returns window on daemon frame
Date: Mon, 22 Jan 2018 19:59:47 +0100	[thread overview]
Message-ID: <5A6634A3.3040403@gmx.at> (raw)
In-Reply-To: <87inbtvqci.fsf@tcd.ie>

 > I believe this issue and its potential resolution share some ground with
 > bug#27210 in that the daemon frame is counterintuitively considered
 > visible in the following repeat-until condition in
 > Fother_window_for_scrolling:
 >
 >    do
 >      window = Fnext_window (window, Qnil, Qt);
 >    while (! FRAME_VISIBLE_P (XFRAME (WINDOW_FRAME (XWINDOW (window))))
 >           && ! EQ (window, selected_window));
 >
 > Until a more thorough review of the visibility of the initial daemon
 > frame is reached, I propose the attached patch to additionally ignore
 > the daemon frame in the aforementioned repeat-until condition.  I assume
 > the overhead of the additional loop logic and IS_DAEMON invariant is
 > negligible compared to the rest of the function.
 >
 > An alternative approach to the attached patch would be to limit "other
 > window scrolling" to frames in the current terminal, as per the spirit
 > of bug#5616:
 >
 >
 >
 >
 > or at least prioritise the current terminal's frames.  WDYT?

I think all your proposals are good and make sense.  Which one would
you like most?

martin





  reply	other threads:[~2018-01-22 18:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 15:57 bug#30207: 27.0.50; [PATCH] other-window-for-scrolling returns window on daemon frame Basil L. Contovounesios
2018-01-22 18:59 ` martin rudalics [this message]
2018-01-23  0:07   ` Basil L. Contovounesios
2018-01-23  0:29     ` Noam Postavsky
2018-01-23  1:06       ` Basil L. Contovounesios
2018-01-23  1:29         ` Noam Postavsky
2018-01-23 13:28     ` Basil L. Contovounesios
2018-05-02 18:57       ` Basil L. Contovounesios
2018-05-02 19:44         ` Eli Zaretskii
2018-05-03 13:03           ` Basil L. Contovounesios
2018-05-03 19:00             ` Eli Zaretskii
2018-05-03 22:44               ` Basil L. Contovounesios
2018-05-10 23:48                 ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A6634A3.3040403@gmx.at \
    --to=rudalics@gmx.at \
    --cc=30207@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.