From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#30182: Update Date: Mon, 22 Jan 2018 19:59:28 +0100 Message-ID: <5A663490.3050409@gmx.at> References: <87k1wdqc4q.fsf@gmail.com> <87inbxqc1l.fsf@gmail.com> <5A631B7F.3030308@gmx.at> <878tcs3j23.fsf@gmail.com> <5A634E53.7010205@gmx.at> <87mv182bzk.fsf@gmail.com> <83a7x7sww6.fsf@gnu.org> <87efmj27d5.fsf@gmail.com> <83vafvqjbf.fsf@gnu.org> <87inbvxdz8.fsf@gmail.com> <5A65AB97.1030401@gmx.at> <87po62kk10.fsf@gmail.com> <831sih23rh.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040805010309030402080003" X-Trace: blaine.gmane.org 1516647515 20303 195.159.176.226 (22 Jan 2018 18:58:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Jan 2018 18:58:35 +0000 (UTC) Cc: 30182@debbugs.gnu.org To: Eli Zaretskii , Sujith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 22 19:58:30 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edhIN-0004Dy-Hj for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jan 2018 19:58:15 +0100 Original-Received: from localhost ([::1]:59244 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edhKN-00006o-Nx for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jan 2018 14:00:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edhKC-0008Rn-Jx for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 14:00:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edhK6-0002Fj-U5 for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 14:00:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58749) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edhK6-0002FU-Qn for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 14:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1edhK6-0004FX-6p for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 14:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jan 2018 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30182 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30182-submit@debbugs.gnu.org id=B30182.151664758216279 (code B ref 30182); Mon, 22 Jan 2018 19:00:02 +0000 Original-Received: (at 30182) by debbugs.gnu.org; 22 Jan 2018 18:59:42 +0000 Original-Received: from localhost ([127.0.0.1]:38410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edhJm-0004ET-2W for submit@debbugs.gnu.org; Mon, 22 Jan 2018 13:59:42 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:56918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edhJk-0004EE-Ds for 30182@debbugs.gnu.org; Mon, 22 Jan 2018 13:59:40 -0500 Original-Received: from [192.168.1.100] ([213.162.73.147]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Ln7wj-1fInMG2nWf-00hJFC; Mon, 22 Jan 2018 19:59:33 +0100 In-Reply-To: <831sih23rh.fsf@gnu.org> X-Provags-ID: V03:K0:MabufjvZYtP8yl3dhiiht35nIm9Vf/+4yVNDjfA+gZacfPhm6v8 Rk2OLtKGwDQ/GDa/s3oC1L+CctN+3jFYvq0DlYppX0i73wREL8++9G73Fv+uPr7xle7dbNB VOVMY94HKzpqcG2U0TA9oafsAYxt07xWKjosBDgiF6BW+P2zfdmSgxfFkj3TpxuPlaSA7kk mdKZAV6kAY7lVYi7kMVFQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Qmaog8BHOVU=:aODAsUgKhgCHEzA8Sd3/bJ 7bVlF1keAMJqsKt8UGodh567P6/uQ/cDgSF3Zfg2b1t3d1hXZohdSsYOVfrWt8F6ncQCsj3mK jF1DVeT0n+3EQ4jc6UZeOiezSTaOy5SYrgvIR0R2K9vCdXwVKSg2jNV9VusX9aReO0AaPnajb lmfCuiHccUWiXMDO+i/561RXFFI9AdxD75ber97SWWcbBh5hPv2uc1cGpnijkCV8KJe24d/H6 Yv3kjDSe6jAvybsze6QnUR5W3P4LHWwyt5F2p3WpXAVsafuJ567obBifg+RhrOdmcqygGwiF+ CJ1tTFhMfgQtCT/aAzXzbgeWju6FbXnmfWF0WqTjp0ykCOHUbDrV2e8EQqpz6qodfHweAsspL FLBFYegU9jMmH3dosTSiC37YCefX6Y06GaWST8K7h5eZYWzs67S0t4FFKOBFOmKGpa+PYJhye nusAhjjFTdyac3GiiLtG3n/BWllbwKq9tUQuo1woPo+vk23wdUwzwkJ7iTgjzSAV+bLZcCxg7 JvRNa0D+pzncS8Qz99Tr1zYNNGyyqK9GgTYv/XcVD8ZGFv+7MOvgxK2nPqJxaKAY7zrxl1ibB QDy+amx98UN9v/aPjYxtxZx5Hou6E9J0WrLCWee10Jw3wWmIuvBXDtg2NUW+z8T3hidk0d2Y+ VV3UcacPov9+nWRh4Flntxdxsy6gDSuNA6yZTXmZ/2NbteVf9bAxFvaG30oWjFPcpwOwrTxO/ 30SNWsTZ2lVTD36jf8Ud7GTbcPR7q0fqbVb+Ng7rp8exQDLad7VpsVnR13qT/BhLQOtmVrsZ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142386 Archived-At: This is a multi-part message in MIME format. --------------040805010309030402080003 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > The above list has 5 elements, not 4. Wouldn't that imply that a timer was added after `copy-sequence' started? > Martin, did you try reproducing this on your GNU/Linux box? Did you > succeed? So far I have condensed a ~50 lines excerpt from w3m.el which should include all necessary ingredients to shorten the mode line text as w3m does, but to no avail. > /* Only DX and DY have changed. */ > tip_f = XFRAME (tip_frame); > if (!NILP (tip_timer)) > { > - Lisp_Object timer = tip_timer; > - > + call1 (Qcancel_timer, tip_timer); > tip_timer = Qnil; > - call1 (Qcancel_timer, timer); > } > > block_input (); > > Note that the old code copied the tip timer, then nullified it, and > then canceled it using the copy. While the new code cancels first and > then nullifies. So that code really had some purpose? OTOH why would someone had bothered to write it in the first place. And if that someone was Gerd, he probably had enough prior experience with timer variables to put it there. Sujith, can you try the attached patch? > The crash seems to be caused by an element of timer-list becoming nil > somehow. We need to understand how that happens. The relevant > players are (1) the fact that w3m.el schedules a timer from a > mode-line's :eval form, and (2) the tool-tip machinery, in particular > its canceling timer. And it sounds like by the time copy-sequence > runs and tries to copy timer-list, the damage to the list is already > done. Also, an important thing to remember is that copy-sequence > copies the list, but doesn't copy the elements, so the elements are > shared with the original list. Hmm... The list with the 5 timers seems pretty innocuous to me. I still wonder why concat decided to reserve only 4 elements for its copy. martin --------------040805010309030402080003 Content-Type: text/plain; charset=windows-1252; name="xfns.c.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="xfns.c.diff" ZGlmZiAtLWdpdCBhL3NyYy94Zm5zLmMgYi9zcmMveGZucy5jCmluZGV4IDQzYzU1Y2MuLjkx N2ZkZDUgMTAwNjQ0Ci0tLSBhL3NyYy94Zm5zLmMKKysrIGIvc3JjL3hmbnMuYwpAQCAtNjUy Niw4ICs2NTI2LDEwIEBAIHN0YXRpYyB2b2lkIGNvbXB1dGVfdGlwX3h5IChzdHJ1Y3QgZnJh bWUgKiwgTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0LAogewogICBpZiAoIU5JTFAgKHRpcF90 aW1lcikpCiAgICAgewotICAgICAgY2FsbDEgKFFjYW5jZWxfdGltZXIsIHRpcF90aW1lcik7 CisgICAgICBMaXNwX09iamVjdCB0aW1lciA9IHRpcF90aW1lcjsKKwogICAgICAgdGlwX3Rp bWVyID0gUW5pbDsKKyAgICAgIGNhbGwxIChRY2FuY2VsX3RpbWVyLCB0aW1lcik7CiAgICAg fQogCiAjaWZkZWYgVVNFX0dUSwpAQCAtNjc1OSw4ICs2NzYxLDEwIEBAIHdpdGggb2Zmc2V0 IERZIGFkZGVkIChkZWZhdWx0IGlzIC0xMCkuCiAJICB0aXBfZiA9IFhGUkFNRSAodGlwX2Zy YW1lKTsKIAkgIGlmICghTklMUCAodGlwX3RpbWVyKSkKIAkgICAgewotCSAgICAgIGNhbGwx IChRY2FuY2VsX3RpbWVyLCB0aXBfdGltZXIpOworCSAgICAgIExpc3BfT2JqZWN0IHRpbWVy ID0gdGlwX3RpbWVyOworCiAJICAgICAgdGlwX3RpbWVyID0gUW5pbDsKKwkgICAgICBjYWxs MSAoUWNhbmNlbF90aW1lciwgdGltZXIpOwogCSAgICB9CiAKIAkgIGJsb2NrX2lucHV0ICgp OwoK --------------040805010309030402080003--