From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document'
Date: Mon, 18 Dec 2017 08:26:31 +0100 [thread overview]
Message-ID: <5A376DA7.2060806@gmx.at> (raw)
In-Reply-To: <jwvefnsivod.fsf-monnier+gmane.emacs.devel@gnu.org>
> I think what Eli is getting at is that instead of save-window-excursion
> we could just do add a `set-window-buffer` before `set-window-point`.
>
> I think it would make a lot of sense, actually, since
> save-window-excursion saves the whole window-config (i.e. data about
> all windows in the current frame), whereas we're only going to touch the
> selected window.
`save-window-excursion' is a pain. But as I mentioned in my last mail,
`set-window-buffer' is not so innocuous either. We'd have to care about
the selectd window's old_pointm, start_at_line_beg and start slots at
least. Something `save-window-excursion' (maybe) does auto-magically.
So I doubt we should do such a change in the release.
martin
prev parent reply other threads:[~2017-12-18 7:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171216141055.30854.67661@vcs0.savannah.gnu.org>
[not found] ` <20171216141056.8391A24612@vcs0.savannah.gnu.org>
2017-12-16 15:04 ` [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document' Stefan Monnier
2017-12-16 16:04 ` Eli Zaretskii
2017-12-16 22:23 ` Stefan Monnier
2017-12-17 15:44 ` Eli Zaretskii
2017-12-17 17:54 ` martin rudalics
2017-12-17 20:22 ` Eli Zaretskii
2017-12-17 21:20 ` martin rudalics
2017-12-18 3:09 ` Stefan Monnier
2017-12-18 7:26 ` martin rudalics [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A376DA7.2060806@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.