all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Paul Eggert <eggert@cs.ucla.edu>,
	 Stefan Monnier <monnier@IRO.UMontreal.CA>,
	emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961)
Date: Fri, 15 Dec 2017 19:17:01 +0100	[thread overview]
Message-ID: <5A34119D.6000407@gmx.at> (raw)
In-Reply-To: <c18a20e9-c260-79eb-80bd-6a811a337bea@cs.ucla.edu>

 > That's a good idea. However, some calls to FOR_EACH_FRAME do assume
 >  that frame-list is non-nil, while others don't. So when we remove the
 >  eassume from FOR_EACH_FRAME, we should add it to callers that have
 >  the assumption (otherwise --enable-gcc-warnings would sometimes
 >  rightly complain). I installed the attached.

I'm confused.  How did you recognize the "callers that have the
assumption"?  What about the call in check_glyph_memory?

martin



  reply	other threads:[~2017-12-15 18:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20171215073120.7671.79446@vcs0.savannah.gnu.org>
     [not found] ` <20171215073122.52703204D3@vcs0.savannah.gnu.org>
2017-12-15 16:23   ` [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961) Stefan Monnier
2017-12-15 17:13     ` Paul Eggert
2017-12-15 18:17       ` martin rudalics [this message]
2017-12-15 19:09         ` Paul Eggert
2017-12-16  9:42           ` martin rudalics
2017-12-17  0:50             ` Paul Eggert
2017-12-17 10:46               ` martin rudalics
2017-12-18  0:39                 ` Paul Eggert
2017-12-18  7:26                   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A34119D.6000407@gmx.at \
    --to=rudalics@gmx.at \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.