From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#29627: 25.3; x-show-tip does not display text when x-gtk-use-tooltips is nil and left/right-margin-width is set Date: Sun, 10 Dec 2017 15:28:55 +0100 Message-ID: <5A2D44A7.4010502@gmx.at> References: <83shcju0kv.fsf@gnu.org> <5A2D03EB.1070007@gmx.at> <83k1xuu141.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1512916218 14881 195.159.176.226 (10 Dec 2017 14:30:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 10 Dec 2017 14:30:18 +0000 (UTC) Cc: 29627@debbugs.gnu.org, terlar@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 10 15:30:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eO2cP-0003jY-Ua for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Dec 2017 15:30:14 +0100 Original-Received: from localhost ([::1]:44876 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eO2cX-00053m-8d for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Dec 2017 09:30:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eO2cM-00052a-4E for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2017 09:30:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eO2cH-0001Ot-1I for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2017 09:30:10 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45955) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eO2cG-0001OC-SZ for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2017 09:30:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eO2cG-0005XF-KB for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2017 09:30:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Dec 2017 14:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29627 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29627-submit@debbugs.gnu.org id=B29627.151291615121161 (code B ref 29627); Sun, 10 Dec 2017 14:30:04 +0000 Original-Received: (at 29627) by debbugs.gnu.org; 10 Dec 2017 14:29:11 +0000 Original-Received: from localhost ([127.0.0.1]:54632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eO2bP-0005VE-AZ for submit@debbugs.gnu.org; Sun, 10 Dec 2017 09:29:11 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:52391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eO2bN-0005Um-GM for 29627@debbugs.gnu.org; Sun, 10 Dec 2017 09:29:10 -0500 Original-Received: from [192.168.1.100] ([46.125.250.118]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LgdBZ-1ereJc2rKP-00o29s; Sun, 10 Dec 2017 15:29:01 +0100 In-Reply-To: <83k1xuu141.fsf@gnu.org> X-Provags-ID: V03:K0:P1f9zAiGt+X1sqStQHmx/67GcyYPPAaK5YvW/IPB1aH+pKzbmeJ rfrDCiG77C7+ueaU9Blwz5RjCv655a0BtgakhN/OU0cHSOnODXFaEFwifqdRAzwcyc1xkdy srKfCIM51SQRHQs0ZTg1XZkpmKoRXQf1kQ7LevcT1jYH46/zg7fvki+vafQl4lxnqhbKc10 ZwfFbHfuc63ojG+xBoE9Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:EqQwAqcC31k=:v9r7IrzNR9qaSJwMeVg7iG HSme+oqAWMes0QnMoGKNTqYkmaq411Rtkb0fIJy7BG2NDwA/YfTh49SuExQUW6IQXtSSN0+MP JmAfjgBYFSBXkhr3+ic0IbITzDf09JQhlsd3OQoc9dv0QX3014r8WsQ/BGP+Qau4bw5YrXJN+ yU0ILcCElKoXyZRfXd9irJWtl0MauF83SHD2WLLyP+EqFPS9iJmPbmtoOmscZ9SZM5HnM3LK6 9U7d8INvD5jOTHYXlO3FzY7nl28X+66r3ydJ7ChbQzH7vhMTats1gE1Lj6i1IUJhflNEFb2Ij EJxKLcCvTO79nXMSjn1vhsmJV/dowpPpkMF9kD2rXDGhOer03ZpBqsL9izoeKBqDP7r/weP32 oq8Jq9qwSLxsn9bFCK07+KqyVUF11Tbpba2xicz9sVnYVfk6w/3k8eIrbFTPiUrUOs8F13INB NF2DSJys8zf8dRN2gUJsw8ncR2tNOAzXEIz0l/fQhL4VYBDJd6U9C3aEWCMthYs9GOVLpJjyr V0/WCgwKHW2S7XBhQQljk8y75dELaia5M27AOBq7GHenFjKacqzwkLY/dWHkZjIVxBISEXfy8 YKtVi3DeoDH6hnOlZZebwsDhtQblgDaPqzt8Uk5ltudQiOV9hTZBGaaAHZsjpX/vWnYtOjMbv XEx3DUd435Y8Erw0Ne56cmZk1sWvRM8yGgLdpSVajhg0OuwZfNXBkpGL6EAJDhH8jBYwKFq2+ Pq89FRRhGciEw/ohFSwJeN6sgC0+4VPAvv6uX+j+WsUVJhY/YFgsi8pF1oygMd25a6MEqgwy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140897 Archived-At: > First, I didn't make the window a pseudo-window; it was always a > pseudo-window. The line > > w->pseudo_window_p = true; > > existed in x-show-tip ever since Emacs 21. Ah, sorry. I misread both ChangeLog entry and diffs (and was probably mislead by this change - Currently only used for menu bar windows of frames. */ + Currently only used for menu bar windows, for tool bar windows, + and for tooltips. */ ) > I didn't feel comfortable > with changing that now, certainly not on the release branch. Sure so. > And you will see that window_box_left does this for pseudo-windows: > > if (w->pseudo_window_p) > return FRAME_INTERNAL_BORDER_WIDTH (f); > > which is just another example of the above-mentioned assumption about > pseudo-windows being margin-less. Right. > So from_x remained (almost) zero, unlike in normal windows, and the > already displayed text was deleted. > > For some reason that I cannot identify, and don't really care about, > the original recipe did work until Emacs 24.3. But it could only work > by sheer luck, or maybe something else was preventing the window of > the tooltip frame to acquire display margins. I just made this > official with my changes, that's all. > > As for why I forced the tip buffer have zero margins, instead of doing > the same with the window in which that buffer is displayed, then: > > . why does it matter? the buffer is a temporary buffer generated > specifically for showing the tip text; > . I thought doing that with the window is more complex, what with > all the different ways one can affect a window's parameters > > Having said all that, if you see problem(s) caused by my change, > please describe them; I'm not married to the fix I pushed. It's OK. My concern was that turning tooltip windows into pseudo-windows would have meant a quite substantial change for the release branch. Thanks for the explanations, martin