From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#56227: 29.0.50; Eshell globs ending with '/' should match directories only Date: Sat, 25 Jun 2022 18:45:35 -0700 Message-ID: <59d27492-84bb-02d1-0c10-55b8e861aeb7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38326"; mail-complaints-to="usenet@ciao.gmane.io" To: 56227@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 26 03:46:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5HLn-0009rM-1Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jun 2022 03:46:11 +0200 Original-Received: from localhost ([::1]:45328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5HLl-0005Sk-LC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jun 2022 21:46:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5HLe-0005Qp-O5 for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2022 21:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52566) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5HLe-0003qt-FJ for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2022 21:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5HLe-0004dD-Do for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2022 21:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2022 01:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56227 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165620794417770 (code B ref -1); Sun, 26 Jun 2022 01:46:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Jun 2022 01:45:44 +0000 Original-Received: from localhost ([127.0.0.1]:46463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5HLM-0004cY-1D for submit@debbugs.gnu.org; Sat, 25 Jun 2022 21:45:44 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:52598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5HLJ-0004cO-8o for submit@debbugs.gnu.org; Sat, 25 Jun 2022 21:45:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5HLH-0005Jd-WF for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2022 21:45:40 -0400 Original-Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]:35418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5HLG-0003p0-II for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2022 21:45:39 -0400 Original-Received: by mail-pj1-x102b.google.com with SMTP id x1-20020a17090abc8100b001ec7f8a51f5so9153188pjr.0 for ; Sat, 25 Jun 2022 18:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:message-id:date:mime-version:content-language :content-transfer-encoding; bh=e7azTgV7w7cMkhwskbfQkKvIXbBHgp07iNoOhujF5II=; b=FRXcg7VPIP0qXHf/kHoeIj9OO0+8w8p9p7ZS/xetvYNwsD5td7VF10s7O/UZzwMNPE k0rNylP7rsEqL8m/+g+QojL26DO5lOQQw2kjLPqhGBFAOYyzpUEOtySOjj/4BVLVf9aL 2gWQiN2cyIYNPQ/E6/Cy4pWQxwQ8VFeRhjfHx5BCk9+zRyNN6erZyACBHAiOWAILUkMY 5Y1xQJZtgvRQykpPVBukpN/e4NvUitUhVAyAchmqDTGwFbMbP3NqYj6boOG00fh8n8az emJT4yAix7jTzsqiPKzcXqb3g2bfXUAvBixTcaVlEJZOkMQWr3VBmBV/RDUHSoW2iKUg F9LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language:content-transfer-encoding; bh=e7azTgV7w7cMkhwskbfQkKvIXbBHgp07iNoOhujF5II=; b=6A4D58Hdy3gPF0LfS2XWb74U4Of63opT4Aut0FMFMrKAHX+VG8zt9BKUs2cqwIUaym zLKtKzZFCcQvmOdePAaywhKwTKf/B7Sm+PdhSJvnHbiscJyIdLGaDJskfjtoviU5P20E 1O1Pe97/RY/E97YTCFMsXj7Hakt6D1FpuXd3Gw5ozCI2x275z7YObmuDlIPgaOhohq9J XkceIP/4HZ5xUg+3skp+n7tA8W3WIlA4xt8sWBziGorGDbyX5gOaNAmBc2t9pw766UqE FoS47zkZBIBiJHb65ZNlfJajTbXh8v4LeHiQ+KKo7xVLj7L45xWE8dOHyxijNThuvPHE nJlg== X-Gm-Message-State: AJIora9mRbtKSwZPyHZIFlcjyoeJ+Utr7soq9hHNmsry+KyWCk9zh1o/ 4VowYEoDNxMkvPyBfs0Xh30t6CkWvHU= X-Google-Smtp-Source: AGRyM1uaK4eLrkMb+VbrTrvq4HMLD08h+vWL6FM+EzJL57LYcTeA3rX/WR5cP3L0yWRKOyzBA9l6bg== X-Received: by 2002:a17:90a:5ae1:b0:1db:d0a4:30a4 with SMTP id n88-20020a17090a5ae100b001dbd0a430a4mr7562626pji.128.1656207936757; Sat, 25 Jun 2022 18:45:36 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id jg6-20020a17090326c600b0016a087cfad8sm4273996plb.264.2022.06.25.18.45.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jun 2022 18:45:35 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.org:119 Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::102b; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x102b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235297 Archived-At: In regular shells, the pattern '*' matches any (non-dot) file, whereas '*/' only matches directories: $ echo * admin args config.log config.status doc etc leim lib lib-src lisp lwlib Makefile nextstep nt oldXMenu src test $ echo */ admin/ doc/ etc/ leim/ lib/ lib-src/ lisp/ lwlib/ nextstep/ nt/ oldXMenu/ src/ test/ However, in Eshell, both of these do the same thing: ~ $ echo * ("Makefile" "admin/" "args" "config.log" "config.status" "doc/" "etc/" "leim/" "lib-src/" "lib/" "lisp/" "lwlib/" "nextstep/" "nt/" "oldXMenu/" "src/" "test/") ~ $ echo */ ("Makefile" "admin/" "args" "config.log" "config.status" "doc/" "etc/" "leim/" "lib-src/" "lib/" "lisp/" "lwlib/" "nextstep/" "nt/" "oldXMenu/" "src/" "test/") For consistency with other shells, and to make Eshell's globbing more expressive, I think we should make the latter match directories only. While this technically changes an existing behavior, it should be a safe change to make, since there's currently no reason I'm aware of to add a trailing slash to an Eshell glob. Patch forthcoming; just getting a bug number...