all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, dalanicolai@gmail.com
Cc: 43617@debbugs.gnu.org
Subject: bug#43617: 27.1; Define-minor-mode keybindings not get precedence over global  keymap
Date: Sat, 26 Sep 2020 08:25:37 -0700 (PDT)	[thread overview]
Message-ID: <59b95abb-1c57-4a94-b6e0-7f4bdeef72ee@default> (raw)
In-Reply-To: <878scwljdp.fsf@gnus.org>

> Ah, it just works for "j" by accident -- define-minor-mode does not
> evaluate anything in the keymap form.

It should.  According to its doc string.

> So there's no bug here in define-minor-mode, but the
> here is wrong.  It should be:
> 
> (define-minor-mode pdf-continuous-scroll-mode-5
>   "Emulate continuous scroll with two synchronized buffers"
>   nil
>   " Continuous"
>   `((,(kbd "j") . (lambda () (interactive) (print "pushed j")))
>     (,(kbd "C-n") . (lambda () (interactive)(print "pushed C-n"))))
>   (print "toggled minor mode"))
> 
> So I'm closing this bug report.

I don't agree that there's no bug (IIUC).

I think there's either a doc bug (if you think
the current behavior is what we want - I don't)
or a behavior bug (if you think the doc's
described behavior is what we want - I do).

The doc string says that KEYMAP can be:

 an expression that returns either a keymap or
 a list of (KEY . BINDING) pairs where KEY and
 BINDING are suitable for `define-key'

The cons ((kbd "C-n") . 'foo) is exactly such a
(KEY . BINDING) pair - both KEY and BINDING are
suitable arguments for `define-key'.

Yes, it's true that the _result of evaluating_
(kbd ...) is ALSO an acceptable arg for
`define-key'.  But `define-key' doesn't _require_
its KEY arg to be, say, a string or vector.
`define-key' evaluates its arg.  And a list
(kbd ...) is an acceptable arg for `define-key'.

You can write

 (define-key map (kbd "C-n") 'foo)

Or you can write

 (define-key map "
" 'foo)

where that string with char ?\n (Control-J) is
the result of evaluating the sexp (kbd "C-n").

Or you can write

 (define-key map "\n" 'foo)

`define-minor-mode' should accept any expression
that `define-key' accepts for KEY.  In the case
of `C-n' that means (kbd "C-n"), "\n", and "
".





  reply	other threads:[~2020-09-26 15:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 18:10 bug#43617: 27.1; Define-minor-mode keybindings not get precedence over global keymap dalanicolai
2020-09-26 14:04 ` Lars Ingebrigtsen
2020-09-26 14:09   ` Lars Ingebrigtsen
2020-09-26 15:25     ` Drew Adams [this message]
2020-09-26 15:32       ` Andreas Schwab
2020-09-26 16:04         ` Drew Adams
2020-09-27 11:00           ` dalanicolai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59b95abb-1c57-4a94-b6e0-7f4bdeef72ee@default \
    --to=drew.adams@oracle.com \
    --cc=43617@debbugs.gnu.org \
    --cc=dalanicolai@gmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.