From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#29111: 26.0.90; Erc keep-place module broken with new default of switch-to-buffer-preserve-window-point Date: Fri, 03 Nov 2017 08:58:48 +0100 Message-ID: <59FC21B8.5030508@gmx.at> References: <87inetcppp.fsf@gmail.com> <59FAEA9C.1050608@gmx.at> <877ev7zz3e.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1509695978 31281 195.159.176.226 (3 Nov 2017 07:59:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Nov 2017 07:59:38 +0000 (UTC) Cc: 29111@debbugs.gnu.org To: Jay Kamat Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 03 08:59:32 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAWsy-0007E3-0J for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Nov 2017 08:59:28 +0100 Original-Received: from localhost ([::1]:35305 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAWt3-0000BS-83 for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Nov 2017 03:59:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAWsd-0008QJ-Qs for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 03:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAWsY-0004tU-QH for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 03:59:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39927) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAWsY-0004tL-NC for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 03:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eAWsY-00049E-A5 for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 03:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Nov 2017 07:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29111 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29111-submit@debbugs.gnu.org id=B29111.150969593815934 (code B ref 29111); Fri, 03 Nov 2017 07:59:02 +0000 Original-Received: (at 29111) by debbugs.gnu.org; 3 Nov 2017 07:58:58 +0000 Original-Received: from localhost ([127.0.0.1]:48608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAWsU-00048w-AY for submit@debbugs.gnu.org; Fri, 03 Nov 2017 03:58:58 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:49361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAWsS-00048j-Vw for 29111@debbugs.gnu.org; Fri, 03 Nov 2017 03:58:57 -0400 Original-Received: from [192.168.1.100] ([46.125.249.119]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MIhDo-1e8L0z0jxA-002IT3; Fri, 03 Nov 2017 08:58:49 +0100 In-Reply-To: <877ev7zz3e.fsf@gmail.com> X-Provags-ID: V03:K0:XeocXfl6V7dYA0n+WR0FiUcNEuILwbkoUamC0tuRkMzw/RYIYMw AS0jLQM6v/OBWWkUC2eI/rnfqsl/T26H5gtYMFuVFY0hd1IYt7D2omjYxinJ4pefoWU9Zm2 ZhEhS4wDXTIXBPDnTj/HryXKhCAzC7mU8SiImRAzP+Sv+2sfE9TYilPkh+/hrFp0JWZKrUh t1HeRG67pAxGV0yCjiUQg== X-UI-Out-Filterresults: notjunk:1;V01:K0:B9+dTcaqCIc=:aM6MPK2FBToRqDbocdgdd0 3qhgsms+aPqNbLvQk9yU0TlbnnHg5gjmJvCHjmJzqjn86iu11LCfMYAWFpma9HVmjfMAorDSh FU9wpyJpSlg4ltU4CYceoloGTqdo+d2vDBjRmtjJ96zbKKtYHBg41qkn7ivZrTdtzvDgK0kBZ AR5gNBPbsBuYJcipe+OxBbilbm3W2Hqf+lv/riYE3ytt4dV1IF5PU9unTiokYGa/GfBc+OaMl 6ntRzFTUe1bIWYVBqSa+u/125386SpIMWbq6OAntxmQBruKahFdxqy4GW/zluwVI2hr5p3djm U+GeTSSHSje5wLwUXPjULVuwmgRIKMavtgTOUnZTm6X49d7kBGT3qFs4/6zDMhiHjalkz5liM clRl1i+iq5+tizHFMquWZz+p/vrAvcNH12IxLEJiLpRrssEu6rFrrqrzQpDALvHKYYPXvpg6y 66oJfrLomAAgiksuDqij8ZIa8EBtrqJ+bzNp5AnAzQdYopFxIEZkNNg1RPE57JrGv8c0AZ2XG tO694KWi/eESoU/yGzUm2UjxwUryFKC++ziHm6ip47sgU603nQjKQqJxwKGokPUHvrrqAK9K3 UMqOACXDolEIOcUaJTGjEWoy8RsSWiebFKAxxBq6Hk3Xlx+X45w7fMBF5c5YpErdSIQsllst0 /eaXGI545mOxMQR6x+ADNC0Knt1ZK4ZxX229A9xgnoBcBIstIL7Dz19Sg6zrsAhJa7dy9zOML RwRRMVHQ5Ga7WzpKZvSm0q7ffQoOiCQeuL23EwPIL5AKKV7HOvYJctkIEze+iw0t3Zuk90Ks X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139392 Archived-At: > I tried this, and it seems to restore keep-place functionality when > switching to buffers with M-x erc-track-switch-buffer, but not with C-= x > b. I suspect the call to switch-to-buffer in C-x b isn't handled by er= c, > so changing the function won't help. Obviously, I don't think that's a= n > acceptable solution. "keep place" means "preserve point" so it's somewhat surprising that this is a problem in the first place. Can you explain why and how the keep place mechanism and the =E2=80=98switch-to-buffer-preserve-window-po= int=E2=80=99 mechanisms differ? Is =E2=80=98window-point-insertion-type=E2=80=99 invo= lved somehow? > I can think of two solutions right now: > > 1. Add a new configuration option which allows keep-place mode to > disable this setting dynamically, and on enabling keep-place, add erc > buffers to the exempted list. I took a look at `switch-to-buffer' and = I > don't see any way this can be done without a new variable. I personall= y > would like to use the new default for non-erc buffers, and I would > suspect that others would like to turn it on selectively as well. Alternatively, we could allow =E2=80=98switch-to-buffer-preserve-window-p= oint=E2=80=99 have a buffer local value which would override the customizable value and add a new value, say 'always', which would allow the user to override a local 'nil' while the default 't' would have the local 'nil' prevail. Maybe we'd then need a 'never' too ... > 2. Make it impossible to miss that this variable must be turned off wh= en > keep-place is enabled. If this isn't done, people's config will silent= ly > break (which is pretty bad). I would think that keep-place should thro= w > an error when this variable is t, to be safe (since it doesn't work at= > all when it is). > > What do you think? I would be happy if keep-place would work out of th= e > box for new users of erc, but I'm not sure if that's possible... Since =E2=80=98keep-place=E2=80=99 is some sort of a minor mode, enabling= it should warn the user about the =E2=80=98switch-to-buffer-preserve-window-point=E2=80=99= incompatibility. But I'm not familiar with =E2=80=98define-erc-module=E2= =80=99 so we'd probably need someone knowledgeable to do that. martin