From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#28978: 26.0; Regression: separate, dedicated `*Completions*' frame no longer has parameter `minibuffer' Date: Mon, 30 Oct 2017 20:00:08 +0100 Message-ID: <59F776B8.3070301@gmx.at> References: <4d0c5535-246a-4356-914f-3c8d030ba9c9@default> <59F0412F.9090206@gmx.at> <22c73180-e9a6-416f-9e28-da98d07908f8@default> <59F1957F.80900@gmx.at> <59F2ED8C.3010400@gmx.at> <31caab4d-f332-48a7-9736-ccd172073672@default> <59F443A7.1020207@gmx.at> <4851dc90-59c3-49a9-b03c-add382e9b8bf@default> <59F5B8F1.1050909@gmx.at> <59F61A30.30300@gmx.at> <2cb4dbe7-57a6-4a87-9897-224f2d602abe@default> <59F6E1C9.5030702@gmx.at> <07ad0bf0-ecf4-4c0c-97c5-665e1ec77312@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1509390085 16807 195.159.176.226 (30 Oct 2017 19:01:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Oct 2017 19:01:25 +0000 (UTC) To: Drew Adams , 28978-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 30 20:01:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9FJ5-0002aH-Ll for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 20:01:07 +0100 Original-Received: from localhost ([::1]:42179 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9FJC-0007st-Vp for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 15:01:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9FJ5-0007qb-49 for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 15:01:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9FJ0-0004fD-Af for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 15:01:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33955) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9FJ0-0004f0-62 for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 15:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e9FIz-0003Mj-Rw for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 15:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Oct 2017 19:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28978 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28978-done@debbugs.gnu.org id=D28978.150939002912891 (code D ref 28978); Mon, 30 Oct 2017 19:01:01 +0000 Original-Received: (at 28978-done) by debbugs.gnu.org; 30 Oct 2017 19:00:29 +0000 Original-Received: from localhost ([127.0.0.1]:42636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9FIT-0003Lq-83 for submit@debbugs.gnu.org; Mon, 30 Oct 2017 15:00:29 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:60520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9FIR-0003Ld-Bp for 28978-done@debbugs.gnu.org; Mon, 30 Oct 2017 15:00:27 -0400 Original-Received: from [192.168.1.100] ([46.125.249.102]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LzcIM-1d4iMO41XG-014lfn; Mon, 30 Oct 2017 20:00:15 +0100 In-Reply-To: <07ad0bf0-ecf4-4c0c-97c5-665e1ec77312@default> X-Provags-ID: V03:K0:uGFwmP0WPukWHSVlU4tMf4fLK7D8nbfm/jQ2ua9snb4B2PSz/k+ KDl0LcgbPv4Xyfkvycl/jV96+nF3eB6x8J8yO9W7n18BLYgPmM3CCfATYAQ0ZHYuqIMdrH+ 5vllsvGBJJlsEU88geAEwVnHOdKqwFzbIunYC8zEd7hnpJc1WkZZyB/pIM1mK+pAnijjwEZ HgYiRiZIaNbBJgtJZMoJg== X-UI-Out-Filterresults: notjunk:1;V01:K0:aXt+ufwGfZo=:p0I5UtkVefmDvGpmLE3Y2b 7mV9Pp/CXvNWe2fKUBvZxabqX6G4NHFeAMUKbjctpwr4eCTDu9m4iYkiZM6rTD17GkdcBiob7 ApsUtBGKDTunqYeSJkrA+d9y0Pl5iG3uwHGM9Fs3Esod8j5UnRIN7RGvtv2mTYDau75psFPha aBqZhLhtnaq2/4gWyLsR3Hydb9JUqspkJdaswfo5AaXxPhr0vItLycFKcBT2a+xyFP9mOFZFw 4GiyiRTGEdTC8KxN43Pl9uHZoC8CljrbYBYPdRoJpDR4khVEMmReRY+MufSwqGqsDDndIOScj p2MpmatMHvMHmngPGS4r3oAMwtmIwGNy6H0TGIDgRE07sJRnaES6NG2sqOIZ/4qWwl0udG0HI 7V/XSyTw6PtjhNJGSOI99NYecOCuAHm6DfIMCM6sFJ1yfhCP6WNd8BMAZtnhwVEd4WJnv2C3J yyENXdLVLGVHVtycL/LhgmEgWG2v0gc3edKRuXCJWzC4XZjSCJZgEZWFsQ1oGiqcfmWeCQNZ7 gPKfOhUoQ6vOSW5/FT8MYu8D73dmEAejKt9vJ7IodNrKq27mL663C9RAvZwz8Yym7uY9ft+HB 5NJcqfMKi0umub/myNsfu8AsXXMNfm1WipRNiEFLS1rLc43LWBqZEEVjp7y2AbQTFjv6VE5fh kixZstfDYisbeD1RFV+BRugZkNEO7EyFb250NXEh9SlDUh2lyk/5wDCkhGHpMgUQS1oQPvdEu HVVLvptELWxyeKL1K8JcKx2W1JWZvB2QW65YqKDeoYFx1l/Fli8rTBKLr1sJF0aEvNIq+13A X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139201 Archived-At: > Before your change, a separate *Completions* frame didn't > have a minibuffer-window value for its frame parameter > `minibuffer' - it used another frame's minibuffer. Before > your change checking that parameter was a reasonable way > to check whether the frame had an active minibuffer window. Your check does not do that. It tries to check whether this-frame has no minibuffer window and no minibuffer window is active. Given the Emacs 25 manual which says about the 'minibuffer' parameter Whether this frame has its own minibuffer. The value `t' means yes, `nil' means no, `only' means this frame is just a minibuffer. If the value is a minibuffer window (in some other frame), the frame uses that minibuffer. your check was not reasonable. A reasonable equivalent check working for Emacs 25 and Emacs 26 could be (and (not (memq (frame-parameter this-frame 'minibuffer) '(t only))) (not (active-minibuffer-window))) > Return window selected just before minibuffer window was selected. I used this. > I don't think "currently active minibuffer window" is > the same thing as currently selected minibuffer window. > > For one thing, a window is not "active". (Nor is it > "current", you will say, and that's right.) You probably > meant "window of the active minibuffer". I tried to change the documentation in that sense. > For another thing, if a minibuffer window is selected > does that necessarily mean that the minibuffer is active? > I don't think so, but I'm not an expert in this stuff. You can always switch to a minibuffer window without making its buffer active. > Thanks for fixing this. Thanks for the suggestions, martin