From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#28978: 26.0; Regression: separate, dedicated `*Completions*' frame no longer has parameter `minibuffer' Date: Mon, 30 Oct 2017 09:24:41 +0100 Message-ID: <59F6E1C9.5030702@gmx.at> References: <4d0c5535-246a-4356-914f-3c8d030ba9c9@default> <59F0412F.9090206@gmx.at> <22c73180-e9a6-416f-9e28-da98d07908f8@default> <59F1957F.80900@gmx.at> <59F2ED8C.3010400@gmx.at> <31caab4d-f332-48a7-9736-ccd172073672@default> <59F443A7.1020207@gmx.at> <4851dc90-59c3-49a9-b03c-add382e9b8bf@default> <59F5B8F1.1050909@gmx.at> <59F61A30.30300@gmx.at> <2cb4dbe7-57a6-4a87-9897-224f2d602abe@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1509351918 31056 195.159.176.226 (30 Oct 2017 08:25:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Oct 2017 08:25:18 +0000 (UTC) To: Drew Adams , 28978-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 30 09:25:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e95Nb-00072K-TE for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 09:25:08 +0100 Original-Received: from localhost ([::1]:39145 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e95Nh-0003mo-Mi for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 04:25:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e95Na-0003ja-7K for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 04:25:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e95NW-0008Aj-8k for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 04:25:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60832) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e95NW-0008Ab-4Y for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 04:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e95NV-0003GZ-Rp for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 04:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Oct 2017 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28978 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28978-done@debbugs.gnu.org id=D28978.150935190012544 (code D ref 28978); Mon, 30 Oct 2017 08:25:01 +0000 Original-Received: (at 28978-done) by debbugs.gnu.org; 30 Oct 2017 08:25:00 +0000 Original-Received: from localhost ([127.0.0.1]:41280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e95NU-0003GF-6S for submit@debbugs.gnu.org; Mon, 30 Oct 2017 04:25:00 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:58499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e95NS-0003G2-Ax for 28978-done@debbugs.gnu.org; Mon, 30 Oct 2017 04:24:58 -0400 Original-Received: from [192.168.1.100] ([46.125.249.102]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LqQnR-1dVdpG3BIX-00e8bl; Mon, 30 Oct 2017 09:24:47 +0100 In-Reply-To: <2cb4dbe7-57a6-4a87-9897-224f2d602abe@default> X-Provags-ID: V03:K0:gVYgmRXWVXXlUdgH7xbCF5n/ikGnq9VnSOASzdYm4geEkcRr/iy 1Xhh3+Y34rIozp5cyPH8uVy/bYdGWjnZT461kPDcWi9sU4tYZXn15MbtrSg730GCRUoY/HQ vs5ahH/rXMoUNAJ8RIZ1JcwGR4MgMDk6iZ7bz+AgnPP4VDrSJpzCJvVDlqdz299qEPZhp37 ZUgkKXu9gCL4tC9y0ERKQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:yEWM+nWXEXE=:CJbImIL8ZDs2j4AgGy9pu+ xt2M9Le7AlxyifWWux1h+iBuK2UUNv4vx+aoAIDlX7s2EzswTLw+oP5m1Y6qBx/j74pY7/0Zh RMXU+3lqFHdhn2Mj9RwXW7YmtC3mSSHbYIJXfXCyJJucJ9djoeo2I+WrgpQJUQNk0b6iG13Tp nn5pYARL2VgMxcCNK/UfSHbH6o26QMUda0MntOoM5t07GSH1hQ1knceX6nqYRgUdsHjRv7sBU s/kJ3ao4JDs5UdI9WffIFtBwgUn+KbXlZe+beomISj+fAIzrDRFRl+180ZTQ/XnOI+IigyUeT tn4WjQNkaeJJTOveJfLyAIEYMpGGwwBx14+lBPZtG92+YiUAVMczUweM7FCVWpke2Y9yhgSnS KPETmAZUhRHRBG6Z/U9UZfC+a5qcerY/FnQWN2dDeo/LkEkKaT+stl6RNHrTEH61R42EWX/Wt 78f53w6KhkrLSbWNfwgcLg/LCc9lVGkPKIfIiU6FWmbTs1QKXruPlrG+d6VpA1+IH1brfogBs PxlNTh/l5Vad+hgiKvrk39WS+QzNK1J/1MDsbVy9mXxHYc6HWQJvykVXXteC+ZZBZIwjtDX0U NDsRAc2/TfrsJuBcQEIS1zGmDt0NOgGXb2WOGakJ2kAktQQ4tQnkK76egHzqSzDep/KfrgIKb v0TSQaNl9dwJ3T+iGnec4L5j2rYz/5BAuPTN+Qi4kjjXQut4JCdgtrdmNDlhyqTEUDzQ2P6Ji Fi/04P9hYaUhcOyaryddM694JFUSxB1eXBpZ6H6FVSOMQ3DkdrZjUnOmf0HPB2U6o9b7oWt/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139176 Archived-At: > I was checking the `minibuffer' parameter of THIS-FRAME, > to see if it was the `active-minibuffer-window'. But it > should be just as good to check that the frame of the > `active-minibuffer-window' is THIS-FRAME. > > I don't think the code you showed earlier corresponds to > the same thing. IIUC, the test you suggested earlier > checks whether the window that was selected immediately > before the current minibuffer window was selected is the > same as the selected window of THIS-FRAME. That's not > the same thing as what I need to test, AFAICT. But your > latest suggestion seems to check what I've been checking, > and it should work OK in all Emacs versions. If you told me with plain words what you really wanted to check then I might come up with another suggestion. But "checking the `minibuffer' parameter of THIS-FRAME, to see if it was the `active-minibuffer-window'" could not have possibly done anything reasonable even before my changes. That test simply failed/succeeded accidentally with Emacs 25 and just produces the opposite result with Emacs 26. > Return the window that was selected immediately > before the current minibuffer window was selected. Looks good but I need a first line that fits into 67 characters. Pretty please suggest a suitable first line and whatever you consider important for the rest. Also, since we nowhere specify "the current minibuffer window" wouldn't "the currently active minibuffer window" be better? martin