all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Drew Adams <drew.adams@oracle.com>, 28978@debbugs.gnu.org
Subject: bug#28978: 26.0; Regression: separate, dedicated `*Completions*' frame no longer has parameter `minibuffer'
Date: Sat, 28 Oct 2017 10:45:27 +0200	[thread overview]
Message-ID: <59F443A7.1020207@gmx.at> (raw)
In-Reply-To: <31caab4d-f332-48a7-9736-ccd172073672@default>

 > So the meaning of frame-parameter `minibuffer' has changed.

Not really.  It should specify the minibuffer window used by that frame
if the frame doesn't have its own minibuffer window.  Otherwise, it's t
if this is a normal frame with its own minibuffer window and 'only if
it's a minibuffer-only frame.  nil only serves as an initial value where
it's up to Emacs to decide which minibuffer window to choose (something
it eventually may have to do anyway).

 > I will need to adjust my code somehow.
 >
 > How would you suggest I change the test I have been using,
 > to detect a frame that has the active minibuffer (versus
 > the case I reported, where dedicated frame `*Completions*'
 > has no minibuffer)?

I would try

(eq (minibuffer-selected-window) (frame-selected-window this-frame))

It's a pity that you were not around when I tried to discuss the
associated code here.  Maybe together we would have found a more
convenient solution.

martin





  reply	other threads:[~2017-10-28  8:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 20:20 bug#28978: 26.0; Regression: separate, dedicated `*Completions*' frame no longer has parameter `minibuffer' Drew Adams
2017-10-25  7:45 ` martin rudalics
2017-10-25 14:47   ` Drew Adams
2017-10-26  7:57     ` martin rudalics
2017-10-26 14:01       ` Drew Adams
2017-10-27  8:25         ` martin rudalics
2017-10-27 14:19           ` Drew Adams
2017-10-28  8:45             ` martin rudalics [this message]
2017-10-28 19:15               ` Drew Adams
2017-10-29 11:18                 ` martin rudalics
2017-10-29 15:59                   ` Drew Adams
2017-10-29 18:13                     ` martin rudalics
2017-10-29 23:56                       ` Drew Adams
2017-10-30  8:24                         ` martin rudalics
2017-10-30 14:32                           ` Drew Adams
2017-10-30 19:00                             ` martin rudalics
2017-10-30 19:16                               ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59F443A7.1020207@gmx.at \
    --to=rudalics@gmx.at \
    --cc=28978@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.