From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook Date: Sun, 15 Oct 2017 14:12:30 +0200 Message-ID: <59E350AE.3060005@gmx.at> References: <1508054203.3504379.1139170720.0D0E99E9@webmail.messagingengine.com> <59E32D49.4030007@gmx.at> <1508065717.3534312.1139251176.600E646A@webmail.messagingengine.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1508069598 16225 195.159.176.226 (15 Oct 2017 12:13:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 15 Oct 2017 12:13:18 +0000 (UTC) Cc: 28844@debbugs.gnu.org To: Paul Rankin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 15 14:13:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3hmx-0002Lp-O6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Oct 2017 14:13:03 +0200 Original-Received: from localhost ([::1]:57135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3hn5-0000Ma-0P for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Oct 2017 08:13:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3hmz-0000MJ-Gv for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 08:13:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3hmw-0007s2-BR for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 08:13:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60575) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3hmw-0007rw-7t for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 08:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3hmw-0002hG-1l for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 08:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Oct 2017 12:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28844-submit@debbugs.gnu.org id=B28844.150806956810347 (code B ref 28844); Sun, 15 Oct 2017 12:13:02 +0000 Original-Received: (at 28844) by debbugs.gnu.org; 15 Oct 2017 12:12:48 +0000 Original-Received: from localhost ([127.0.0.1]:41023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3hmi-0002gp-0G for submit@debbugs.gnu.org; Sun, 15 Oct 2017 08:12:48 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:53669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3hmf-0002gY-T7 for 28844@debbugs.gnu.org; Sun, 15 Oct 2017 08:12:46 -0400 Original-Received: from [192.168.1.100] ([46.125.250.23]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MMkgl-1eAZw33Eb9-008e6h; Sun, 15 Oct 2017 14:12:36 +0200 In-Reply-To: <1508065717.3534312.1139251176.600E646A@webmail.messagingengine.com> X-Provags-ID: V03:K0:DURq7ikMc5BKS6jMqGvOhtc8cn77cni5EYYzfT8oH2slWiz96ng O8Giz4UV50QRmTbzlluOLd1TSG6v+5aNTQJyekig9Ewqm8nVVAQsd2Qtj5HNBIezc8+sLn4 m3qcpKv6BWxa1xO4qIkKMcyiUTITZIm5ep9UyKadMQj75a/XnAMtpWZZs4xctXD/KzifT5h IygSHmTCxEL+Th+wb+PVg== X-UI-Out-Filterresults: notjunk:1;V01:K0:BRC9Zqfe5i0=:kAZcNFGmGw4pNk21Zi7faU rrdP/27gtMciSAZwbXFwKb8PMXnhtErycOoYTyi2qZSuaMnE+s3/WyNyAvKoOEf7vz9Efs5oD Hjo/cvQ5BihHvYtiihguPW8NVhuBJc+gDYq6nB7lbwOjGZZ7fgeZkdV/s2uEDQ+81ZHRjEXmH 2Iq3MzXhk/aLkWwo9HBY1ZNiNvdpo4FZ4h4plrXfbwOqzOID5y7iZVNmQe0CK+zTCMd2uwfHX hqRMo1QlEyLIFDo10BqEk0SAN8yop0l9egu+BfanJWq8v9vsKxN+0gvLshnhU94+jOnPwDcQZ 6aOVZn8iw1BVr5xEIUhnMB+ZZT5gIvKKmpL4fOSJWzvfhI2tAVlZKa3t/Wr+94LzmF3idCXnP MF+QwhIW2bOIsuuFWTTsJzdQIyeXCIUz4NNXbaOnWXTw/83Rqv+/Ikk4RhAEPt/4Pu/oFmCPh 6VdCrfhHdd0NvWYL+lrdRftSRbfQdAjLbDs0P+svE7OFEKwD8azCCXAEKrWzlWVM1t9L0iEcM KtTGfsWYM54PnzEwYBbaxW3DNJ0NIZIIXlIjwywAvF43x1jRxwAqKW7PvolzOgYw7/wXJOVoP hDNwEqwJbEjjZ4sprTnj4S6KvBrUcpR4+lpfqcItLLgKneQPIjmBEPTo3JVCjlPIEcwL8guTA jlRzsaCv/dcxncaQprYQ1s3KCgpN14mmAAQCRHeCU5lliOPuTtbSzFIWz0R5U9g8TDO8qitCI p1SRLdr0VofFQOgS60A3iZPdEbDjzHMMCFbB6ZmTtpY5i5F6q8OBV0z9vFLLaHJr3MuB0mvy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138451 Archived-At: >> =E2=80=98window-configuration-change-hook=E2=80=99 is still run way t= oo often, for >> example, when windows get resized. =E2=80=98window-size-change-funct= ions=E2=80=99 might >> be better. But if you need such a hook, wouldn't you also need it wh= en >> line numbers occupy more or less columns, for example, during scrolli= ng? >> >> Otherwise, why can't you use =E2=80=98display-line-numbers-mode-hook=E2= =80=99? > > Thanks for pointing me to display-line-numbers-mode-hook, but I=E2=80=99= ve > found that it=E2=80=99s not enough to just check when the mode is enab= led. We > need to alert other concerned modes whenever display-line-numbers-mode= > changes the margins, e.g. due to scrolling from line 99 to 100 (which > will increase the width from 2 to 3). That's what I meant when I said that "if you need such a hook, wouldn't you also need it when line numbers occupy more or less columns, for example, during scrolling?" You could use =E2=80=98window-scroll-functions=E2=80=99 (remembering the = old line number widths) for scrolling but this would not handle simple point movements. Eli will decide what to do. If an existing hook must be chosen, I'd rather (mis-)use =E2=80=98window-size-change-functions=E2=80=99 - strictl= y spoken, display of line numbers never affects the size of windows (something which is not true vice-versa IIUC). But better, provide a separate hook like =E2=80=98line-number-width-changed-functions=E2=80=99 with the corre= sponding window as argument (and maybe the old line number width as second). martin