From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#28189: 26.0.50; Emacs uses deprecated function gtk_window_parse_geometry Date: Sun, 03 Sep 2017 13:49:30 +0200 Message-ID: <59ABEC4A.3050209@gmx.at> References: <599D40CB.1090100@gmx.at> <599D80D1.6090508@gmx.at> <59A13F90.5080804@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1504439449 16730 195.159.176.226 (3 Sep 2017 11:50:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Sep 2017 11:50:49 +0000 (UTC) To: Philipp Stephani , 28189@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 03 13:50:34 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doTPn-0002V7-Dc for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Sep 2017 13:50:11 +0200 Original-Received: from localhost ([::1]:35355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doTPt-0002BK-2m for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Sep 2017 07:50:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doTPi-00026S-Pk for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2017 07:50:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doTPe-0007ml-2p for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2017 07:50:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36241) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1doTPd-0007mc-VX for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2017 07:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1doTPd-0007cN-MR for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2017 07:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2017 11:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28189-submit@debbugs.gnu.org id=B28189.150443938529255 (code B ref 28189); Sun, 03 Sep 2017 11:50:01 +0000 Original-Received: (at 28189) by debbugs.gnu.org; 3 Sep 2017 11:49:45 +0000 Original-Received: from localhost ([127.0.0.1]:44922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doTPM-0007bl-3M for submit@debbugs.gnu.org; Sun, 03 Sep 2017 07:49:45 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:54623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doTPK-0007bX-43 for 28189@debbugs.gnu.org; Sun, 03 Sep 2017 07:49:42 -0400 Original-Received: from [192.168.1.100] ([46.125.249.17]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M6vSj-1dbuIt3vrp-00wjPU; Sun, 03 Sep 2017 13:49:35 +0200 In-Reply-To: X-Provags-ID: V03:K0:vWbcz7T4yljeQvmlvWkCHGMgCC486KfjcLAa7bhmi3h4eY+R32L xMBMZa5+rQMYJEHI8MwHdDupGH7LWUDyM3EbFdw69GYc0D70G61unxWfvMp13mk6SptKYZG 0yhEpgncDHQqnLL0wrtYWI1DF4wWaKRYGy096gixjcmGrcjUPkVwyDSjFtbfTnPjZBUL9KF 7hWPvflshDc+J2vJsuSPQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ruexM76APtM=:LYtWhFaubmIQEwOjab+dRG rtooYacZ3sqD8bq9a8v3alnIm6dzgOO1STAPXyEQ95lqI8O+9JHbdbJm4KkNaEfp+gQDE1hVb QLCThXvUkSDb01m25RvkZKZnlpuPcjcv6XrgzYuuZns4JrGEiA9UMt4i0a1byAXdmzkRg+XSC OeXHhk2j46ga2aBGtOXkTdzTao9emi4zMjWz2JmVxTQ6I7b1BZImWFaznQwF7rE12sFj0GnGe gUD1YOWAFBRWmu4g0XN+vAiQo2k7n2zsWdD+45itbYD73zTvwMaSgZw30aAuyaz1UzdhlLkw9 SKznewZIgHmxDAOARHa/yt+QjpXj8KTEznMKy1dxyNOSTniwn3fonduS4QCiV81+4wBF/jlIn zJ5oszZb1DJAfftyD+Bope/zdvE/kblQuLUXJ+oZbvBPVON89Tfo0QVNMe9CZhSlK/Ltn8Gv6 rz9BVwlACO6tB4mJyHMc/0EtKYJ1bq+nK6MHvlmWGkjrHX062DguzGNL9JWRD9BGpOOHk9Ti2 mXNGw7P1Ne6jYPntkpigYpSAyH891kKVOp2PqgOQOrfO7o/VyoPJzpDP+t1IWhHSDhqpiicnf a2/E50Tevky+OoUKxWzdjkI4kqTkQwBvI74h0npxHLiWUsGbR7CMwu0MdJ3ZSmCGLVbvR6O4G Rl1NoXop/pQXQl+rR1fSHyzLJMJ82JCj5y2+5KSQX6sAWNliE+rDAooUe/YFUGxxH85cHIQWe 7GPol+8VDkE1iBzMb7pEAz1gpdJtL8OKIxK65Ix+F1otKrTk1Gep0lCBL6tAxk3SEYLz+ak2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136537 Archived-At: > OK, I've pushed all the "simple" changes for now. Belated thanks. Do you think the warnings cited in bug#26855: 25.2; Menus off screen, gtk errors are handled by your changes (I've been too lazy to check that)? This is one of our few clients with GTK 3.22, sadly building from Emacs 25 only. >> This one >> >> +#if GTK_CHECK_VERSION (3, 16, 0) >> + emacs_abort (); >> +#else >> >> looks a bit harsh and the corresponding logic appears quite contrived. >> Maybe the entire function should be rewritten. >> > > The underlying issue here is that GTK no longer seems to have a concept of > a "background color", but Emacs still assumes that concept exists. I understand. But can't we catch that in a less intimidating way? >> Removing the gtk_adjustment_changed calls should be tested ASAP. > > > How could that be tested? By removing these calls as you proposed and waiting till someone with GTK 3.22 hollers. >> +#if GTK_CHECK_VERSION (3, 22, 0) >> + /* FIXME: We should pass the GDK event to this function instead of >> + * synthesizing it. */ >> >> (I think you might want to get this from event_handler_gdk) >> > > I don't think that's possible, because the filter is run before the GTK > event is even created, so it has no access to it. In fact, Emacs appears to > swallow most X events before they are translated to GTK events. > This should be fixed "for real" by creating a gtk3term, which doesn't use > any X functions. It appears to me that the current "X with a bit of GTK > sprinkled on top" can't work any more. I have no ideas of the implications of such an approach and whether it's feasible. We would first have to find all instances where we use an X solution instead of a GTK one and fix them. After that we would have to decide whether the cases where no adequate GTK solution was found can be simply removed or ignored for GTK built Emacsen. Unless you are prepared to do that, I see no-one here to tackle such a task. Daniel Colascione has proposed to "go GTK-only" a couple of months ago but seems to keep a low profile since then (like all others involved in that thread). Thanks again for all the work, martin