From: martin rudalics <rudalics@gmx.at>
To: Philipp Stephani <p.stephani2@gmail.com>, 28189@debbugs.gnu.org
Subject: bug#28189: 26.0.50; Emacs uses deprecated function gtk_window_parse_geometry
Date: Sun, 03 Sep 2017 13:49:30 +0200 [thread overview]
Message-ID: <59ABEC4A.3050209@gmx.at> (raw)
In-Reply-To: <CAArVCkR215c7uzKmVqMw_bCPnVvpRJ=LiY_fbzS38=jZx+9rUA@mail.gmail.com>
> OK, I've pushed all the "simple" changes for now.
Belated thanks. Do you think the warnings cited in
bug#26855: 25.2; Menus off screen, gtk errors
are handled by your changes (I've been too lazy to check that)? This is
one of our few clients with GTK 3.22, sadly building from Emacs 25 only.
>> This one
>>
>> +#if GTK_CHECK_VERSION (3, 16, 0)
>> + emacs_abort ();
>> +#else
>>
>> looks a bit harsh and the corresponding logic appears quite contrived.
>> Maybe the entire function should be rewritten.
>>
>
> The underlying issue here is that GTK no longer seems to have a concept of
> a "background color", but Emacs still assumes that concept exists.
I understand. But can't we catch that in a less intimidating way?
>> Removing the gtk_adjustment_changed calls should be tested ASAP.
>
>
> How could that be tested?
By removing these calls as you proposed and waiting till someone with
GTK 3.22 hollers.
>> +#if GTK_CHECK_VERSION (3, 22, 0)
>> + /* FIXME: We should pass the GDK event to this function instead of
>> + * synthesizing it. */
>>
>> (I think you might want to get this from event_handler_gdk)
>>
>
> I don't think that's possible, because the filter is run before the GTK
> event is even created, so it has no access to it. In fact, Emacs appears to
> swallow most X events before they are translated to GTK events.
> This should be fixed "for real" by creating a gtk3term, which doesn't use
> any X functions. It appears to me that the current "X with a bit of GTK
> sprinkled on top" can't work any more.
I have no ideas of the implications of such an approach and whether it's
feasible. We would first have to find all instances where we use an X
solution instead of a GTK one and fix them. After that we would have to
decide whether the cases where no adequate GTK solution was found can be
simply removed or ignored for GTK built Emacsen.
Unless you are prepared to do that, I see no-one here to tackle such a
task. Daniel Colascione has proposed to "go GTK-only" a couple of
months ago but seems to keep a low profile since then (like all others
involved in that thread).
Thanks again for all the work, martin
next prev parent reply other threads:[~2017-09-03 11:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 20:22 bug#28189: 26.0.50; Emacs uses deprecated function gtk_window_parse_geometry Philipp
2017-08-23 8:46 ` martin rudalics
2017-08-23 10:38 ` Philipp Stephani
2017-08-23 13:19 ` martin rudalics
2017-08-23 23:26 ` Philipp Stephani
2017-08-24 9:37 ` martin rudalics
2017-08-25 9:28 ` Philipp Stephani
2017-08-26 9:29 ` martin rudalics
2017-08-27 13:34 ` Philipp Stephani
2017-09-03 11:49 ` martin rudalics [this message]
2017-09-19 15:35 ` Philipp Stephani
2017-09-19 16:38 ` Philipp Stephani
2017-09-23 11:22 ` Philipp Stephani
2017-09-23 13:21 ` martin rudalics
2017-09-23 13:28 ` Eli Zaretskii
2017-09-23 16:32 ` Philipp Stephani
2017-09-23 16:48 ` Eli Zaretskii
2017-09-23 18:28 ` martin rudalics
2017-09-23 18:31 ` Eli Zaretskii
2017-09-23 16:36 ` Philipp Stephani
2017-09-23 18:29 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59ABEC4A.3050209@gmx.at \
--to=rudalics@gmx.at \
--cc=28189@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.