From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#28189: 26.0.50; Emacs uses deprecated function gtk_window_parse_geometry Date: Sat, 26 Aug 2017 11:29:52 +0200 Message-ID: <59A13F90.5080804@gmx.at> References: <599D40CB.1090100@gmx.at> <599D80D1.6090508@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1503739880 25798 195.159.176.226 (26 Aug 2017 09:31:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 26 Aug 2017 09:31:20 +0000 (UTC) To: Philipp Stephani , 28189@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 26 11:31:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlXQm-0005pe-4t for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Aug 2017 11:31:04 +0200 Original-Received: from localhost ([::1]:56723 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlXQt-0001MV-4P for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Aug 2017 05:31:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlXQn-0001MF-Ob for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2017 05:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlXQk-0002S3-KD for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2017 05:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47313) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlXQk-0002Rz-H5 for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2017 05:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dlXQk-00017l-Au for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2017 05:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Aug 2017 09:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28189-submit@debbugs.gnu.org id=B28189.15037398074258 (code B ref 28189); Sat, 26 Aug 2017 09:31:02 +0000 Original-Received: (at 28189) by debbugs.gnu.org; 26 Aug 2017 09:30:07 +0000 Original-Received: from localhost ([127.0.0.1]:55993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlXPq-00016b-P3 for submit@debbugs.gnu.org; Sat, 26 Aug 2017 05:30:06 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:50711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlXPo-00014p-MV for 28189@debbugs.gnu.org; Sat, 26 Aug 2017 05:30:05 -0400 Original-Received: from [192.168.1.100] ([46.125.250.113]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MMTZa-1dtksc34Xe-008Myo; Sat, 26 Aug 2017 11:29:56 +0200 In-Reply-To: X-Provags-ID: V03:K0:asbEhJ30LAv7DBhftvxa4Kkd+xvgdzOENzwE9lMxlRz0ZKXjavr q9Umw/IXat2M4/BkUrfUnTPNNYall2Q4T2LI5B51Uvdz9rIxrZ6Pa4Q9E6yzecT+G+fTVNV S4u0Gwc/0t+HYN12HlYvf5F3kw/vPNORtkSmKwswigZ/Nd0BPUFbJcyG1jLAM2svNWP/nfC tuDA81RI5kKs6ySaBtkSg== X-UI-Out-Filterresults: notjunk:1;V01:K0:1huFqebou5E=:lbbRgjPgWrdETbjQymAhQ0 bKeuHMOIqnWdOtnVd6J07DNRuH3C/8A3KlFsuYcBBUtiizJpygG+Gl7A42J2MAC2cFcbOTHr0 bc1zsX5qg0JnvnnrPgtCOZHfV8NAOD0d2MjH2qGSjp3grnNzU0MkDIdN/clcKMi6EtGoMsGc1 wMT/kYiHWjmGpb4heZ6ysYHMnExdFcFqfl3mxhTdee9Qn0VqkbrssnTucbbpdMjIlbvfxF5p8 qWsIaUG6sYrDGoM8c5vJZjCFYQv0hy9wcI9u6HGibFWxqRcyjBRW9uu33LUyThT0I9LFKaaky RSO3v0YaPOdy5CFpdjHxf0ARbkPgwI2fZjD3Wp+AqnuHEWMe0cmoJL1hDx2MLMkZi1zEzEtaw Nu/BGlbNo5QfsOKp0NGj+ixm5BsjiFZazO1TWaKZgb/9pxWcoBjZvGGvoI41gVvY5Z7vvj1Yk Ep2LmxxfYZVPxtYCyx4ia3YvXujJkmNo7LiuneRi/+m8FvE7RGUAh1jUb8a4wGRVfZ+lsLiMo lU2HW9tJbD1sGWPAoE0NxwJtZJVta3dWKdbhhV2b27vFOHadh6GJ2z+TQTc+auSENYQJjaMjr DI4CuhEIsaS000AVDMttOppKpdyBA8Oj1OrgJRDQ6NvqkOoVROYLxnM03mnGvLE0ogn+/edQB zEMAsaW0TvOIzciC5VZZz9D/xUou2nzxr5g9/99DiRS8XFKtSoGF5XOncpYpMe/2feDORuFm9 v5w66AeOkT/cc7CBf2/5oamR8nYL2IC0mAEB9FOyWm8CSjUuLikshNhXAn38FtCZEpr/Qhhe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136224 Archived-At: > I've attached a patch that fixes all deprecation warnings. It's not > intended to be installed as-is, more as a baseline for discussion. Som= e of > the functions have straightforward replacements, others are harder to > replace, yet others have vanished altogether. I think you should install most of it right now so we have enough time to test it before a release. There are people who build with GTK 3.22 and could tell us whether it breaks anything (substantially, at least). The sooner we know the better. This one +#if GTK_CHECK_VERSION (3, 16, 0) + emacs_abort (); +#else looks a bit harsh and the corresponding logic appears quite contrived. Maybe the entire function should be rewritten. Removing the gtk_adjustment_changed calls should be tested ASAP. The changes where an alternative is provided like this one +#if GTK_CHECK_VERSION (3, 20, 0) + GdkDevice *gdev + =3D gdk_seat_get_pointer (gdk_display_get_default_seat (gdpy)); +#else GdkDevice *gdev =3D gdk_device_manager_get_client_pointer (gdk_display_get_device_manager (gdpy)); +#endif should be installed in any case and this one +#if GTK_CHECK_VERSION (3, 20, 0) + gtk_widget_set_focus_on_click (wb, FALSE); +#else gtk_button_set_focus_on_click (GTK_BUTTON (wb), FALSE); +#endif obviously too. This one +#if GTK_CHECK_VERSION (3, 16, 0) + g_object_set (settings, + "gtk-menu-bar-accel", EMACS_CLASS, + "gtk-key-theme-name", "Emacs", + NULL); +#else /* Remove F10 as a menu accelerator, it does not mix well with Emacs = key bindings. It doesn't seem to be any way to remove properties, so we set it to "" which in means "no key". */ @@ -5243,6 +5283,7 @@ xg_initialize (void) "gtk-key-theme-name", "Emacs", EMACS_CLASS); +#endif looks good too. All monitor/screen related changes seem harmless to me and should be provided as well. I'm not sure what you mean here + /* FIXME: This function assumes that GdkMonitor objects are never + * destroyed, even if the monitor is unplugged. That=E2=80=99s probab= ly the + * case, but should be verified. */ If this is a problem it is a problem already now. Or am I missing something? Maybe the menu related changes (although self-contained) should be done in a separate fix. In particular this - /* Adjust coordinates to be root-window-relative. */ + /* Adjust coordinates to be root-window-relative, but not for + * GTK+ 3.22, where the menu position is frame-relative. */ and the subsequent +#if GTK_CHECK_VERSION (3, 22, 0) + /* FIXME: We should pass the GDK event to this function instead of + * synthesizing it. */ (I think you might want to get this from event_handler_gdk) look more complicated and at least warrant larger comments. I have no idea about the cairo related change. But the XSync change looks definitely good too. Thanks, martin