From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Gildea Newsgroups: gmane.emacs.bugs Subject: bug#44673: [PATCH] Use lexical-binding in time-stamp.el Date: Mon, 16 Nov 2020 09:33:15 -0800 Message-ID: <59996.1605547995@quatro> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21204"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44673@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 16 18:34:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1keiOK-0005OF-JW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Nov 2020 18:34:12 +0100 Original-Received: from localhost ([::1]:55642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keiOJ-0006cC-Ki for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Nov 2020 12:34:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keiOA-0006Zx-8k for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 12:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keiO9-0003W1-U3 for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 12:34:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1keiO9-0006rH-RI for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 12:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Gildea Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Nov 2020 17:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44673 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160554801026321 (code B ref -1); Mon, 16 Nov 2020 17:34:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Nov 2020 17:33:30 +0000 Original-Received: from localhost ([127.0.0.1]:57086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keiNe-0006qT-3C for submit@debbugs.gnu.org; Mon, 16 Nov 2020 12:33:30 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:43598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keiNc-0006qM-LK for submit@debbugs.gnu.org; Mon, 16 Nov 2020 12:33:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keiNc-0006EW-0D for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 12:33:28 -0500 Original-Received: from tigger.sg.gildea.net ([99.65.78.170]:38032 helo=quatro.sg.gildea.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keiNZ-0003GA-Ri for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 12:33:27 -0500 Original-Received: from quatro (localhost [IPv6:::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by quatro.sg.gildea.net (Postfix) with ESMTPS id 9C811BFB24; Mon, 16 Nov 2020 09:33:15 -0800 (PST) In-Reply-To: Message from stefan@marxist.se of 15 Nov 2020 16:57:00 -0800 X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 27.1 Content-ID: <59995.1605547995.1@quatro> Received-SPF: pass client-ip=99.65.78.170; envelope-from=stepheng+emacs@gildea.com; helo=quatro.sg.gildea.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 12:33:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193451 Archived-At: > Do you think we could safely enable lexical-binding in time-stamp.el? > I ran the test suite with the attached patch and all tests are still > passing. I reviewed the code, and lexical binding looks good to me. Thank you. < Stephen