all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font'
@ 2014-01-23 16:21 Drew Adams
  2014-01-24  3:11 ` Glenn Morris
  0 siblings, 1 reply; 9+ messages in thread
From: Drew Adams @ 2014-01-23 16:21 UTC (permalink / raw)
  To: 16529

emacs -Q

M-: (set-face-attribute 'default nil :font "-outline-Lucida Console-normal-normal-normal-mono-14-*-*-*-c-*-iso8859-1")

That correctly sets the font for the current frame.  However, it does
NOT set the font for future frames, as the doc says it should and as it
does in previous Emacs versions (e.g. 24.3).

Similarly, this does not work anymore:

M-: (set-face-attribute 'default t :font "-outline-Lucida Console-normal-normal-normal-mono-14-*-*-*-c-*-iso8859-1")

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2014-01-17 on ODIEONE
Bzr revision: 116059 michael.albinus@gmx.de-20140117182409-gz695p2c951idlee
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 'CFLAGS=-O0 -g3' LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font'
  2014-01-23 16:21 bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font' Drew Adams
@ 2014-01-24  3:11 ` Glenn Morris
  2014-01-24 17:43   ` Juanma Barranquero
  0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2014-01-24  3:11 UTC (permalink / raw)
  To: 16529


Works for me.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font'
  2014-01-24  3:11 ` Glenn Morris
@ 2014-01-24 17:43   ` Juanma Barranquero
  2014-01-25 12:01     ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Juanma Barranquero @ 2014-01-24 17:43 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 16529

> Works for me.

Doesn't work for me. Perhaps is Windows-specific.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font'
  2014-01-24 17:43   ` Juanma Barranquero
@ 2014-01-25 12:01     ` Eli Zaretskii
  2014-01-25 12:57       ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2014-01-25 12:01 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: 16529

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Fri, 24 Jan 2014 18:43:37 +0100
> Cc: 16529@debbugs.gnu.org
> 
> > Works for me.
> 
> Doesn't work for me. Perhaps is Windows-specific.

Could you please bisect this?  I have no idea how does the font
parameter get propagated to other frames (it's not via
default-frame-alist), so I don't know where to look for the cause of
this problem.

Thanks.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font'
  2014-01-25 12:01     ` Eli Zaretskii
@ 2014-01-25 12:57       ` Eli Zaretskii
  2014-01-25 14:59         ` martin rudalics
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2014-01-25 12:57 UTC (permalink / raw)
  To: lekktu, martin rudalics; +Cc: 16529

> Date: Sat, 25 Jan 2014 14:01:55 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 16529@debbugs.gnu.org
> 
> > From: Juanma Barranquero <lekktu@gmail.com>
> > Date: Fri, 24 Jan 2014 18:43:37 +0100
> > Cc: 16529@debbugs.gnu.org
> > 
> > > Works for me.
> > 
> > Doesn't work for me. Perhaps is Windows-specific.
> 
> Could you please bisect this?

Actually, I think I found the revision to blame.  The problem started
to happen between Dec 25 and Dec 26.  This commit sounds relevant:

  revno: 115757
  committer: martin rudalics <rudalics@gmx.at>
  branch nick: trunk
  timestamp: Thu 2013-12-26 11:31:42 +0000
  message:
    Some more tinkering with Bug#16051.

    * window.c (resize_frame_windows): Don't let the size of the
    root window drop below the frame's default character size.
    Never ever delete any subwindows - let the window manager do the
    clipping.

    * w32fns.c (x_set_tool_bar_lines): Rewrite calculation of number
    of toolbar lines needed when they exceed the height of the root
    window.
    (unwind_create_frame_1): New function.
    (Fx_create_frame): Generally inhibit calling the window
    configuration change hook here.  Remove extra call to
    change_frame_size - it's not needed when we don't run the
    configuration change hook.

Martin, could you take a look, please?





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font'
  2014-01-25 12:57       ` Eli Zaretskii
@ 2014-01-25 14:59         ` martin rudalics
  2014-01-25 15:43           ` Eli Zaretskii
  2014-01-25 16:41           ` Drew Adams
  0 siblings, 2 replies; 9+ messages in thread
From: martin rudalics @ 2014-01-25 14:59 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: lekktu, 16529

 > Martin, could you take a look, please?

Should be fixed now (apparently setting face attributes can run Lisp
code from within Fx_create_frame and if that really happens it looks
like a bad idea to me).

martin





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font'
  2014-01-25 14:59         ` martin rudalics
@ 2014-01-25 15:43           ` Eli Zaretskii
  2014-01-25 16:47             ` martin rudalics
  2014-01-25 16:41           ` Drew Adams
  1 sibling, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2014-01-25 15:43 UTC (permalink / raw)
  To: martin rudalics; +Cc: lekktu, 16529

> Date: Sat, 25 Jan 2014 15:59:05 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: lekktu@gmail.com, 16529@debbugs.gnu.org
> 
>  > Martin, could you take a look, please?
> 
> Should be fixed now

It is for me, thanks.

> (apparently setting face attributes can run Lisp code from within
> Fx_create_frame and if that really happens it looks like a bad idea
> to me).

Why do you think it is a bad idea?





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font'
  2014-01-25 14:59         ` martin rudalics
  2014-01-25 15:43           ` Eli Zaretskii
@ 2014-01-25 16:41           ` Drew Adams
  1 sibling, 0 replies; 9+ messages in thread
From: Drew Adams @ 2014-01-25 16:41 UTC (permalink / raw)
  To: martin rudalics, Eli Zaretskii; +Cc: lekktu, 16529

> Should be fixed now

Thanks.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font'
  2014-01-25 15:43           ` Eli Zaretskii
@ 2014-01-25 16:47             ` martin rudalics
  0 siblings, 0 replies; 9+ messages in thread
From: martin rudalics @ 2014-01-25 16:47 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: lekktu, 16529

 >> (apparently setting face attributes can run Lisp code from within
 >> Fx_create_frame and if that really happens it looks like a bad idea
 >> to me).
 >
 > Why do you think it is a bad idea?

Because, as someone remarked, at that time the frame is "not official
yet".  I haven't looked into the details but, if I understand correctly,
NOT running Lisp code in Fx_create_frame can detrimentally affect the
appearance of future frames.  Such design doesn't strike me as
particularly sane.  But maybe all functions run are of the benign type.

martin





^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2014-01-25 16:47 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-23 16:21 bug#16529: 24.3.50; regression: `set-face-attribute' broken for attribute `:font' Drew Adams
2014-01-24  3:11 ` Glenn Morris
2014-01-24 17:43   ` Juanma Barranquero
2014-01-25 12:01     ` Eli Zaretskii
2014-01-25 12:57       ` Eli Zaretskii
2014-01-25 14:59         ` martin rudalics
2014-01-25 15:43           ` Eli Zaretskii
2014-01-25 16:47             ` martin rudalics
2014-01-25 16:41           ` Drew Adams

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.