From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Dan Knapp" Newsgroups: gmane.emacs.bugs Subject: Apple event opens file at wrong line; patch included Date: Fri, 11 Apr 2008 06:59:57 -0400 Message-ID: <5961bfde0804110359r4af14219oe7a1e7c2e01ffdf8@mail.gmail.com> References: <9895FFC8-C5BD-4E23-B6B4-B21C67A00653@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_41322_23666219.1207911597423" X-Trace: ger.gmane.org 1207911617 1989 80.91.229.12 (11 Apr 2008 11:00:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Apr 2008 11:00:17 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 11 13:00:49 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JkGzw-0002pk-3N for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Apr 2008 13:00:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JkGzI-0001wz-Go for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Apr 2008 07:00:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JkGzB-0001wq-1J for bug-gnu-emacs@gnu.org; Fri, 11 Apr 2008 07:00:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JkGz8-0001wK-Vd for bug-gnu-emacs@gnu.org; Fri, 11 Apr 2008 06:59:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JkGz8-0001wF-Qh for bug-gnu-emacs@gnu.org; Fri, 11 Apr 2008 06:59:58 -0400 Original-Received: from wa-out-1112.google.com ([209.85.146.180]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JkGz8-0001Ss-7G for bug-gnu-emacs@gnu.org; Fri, 11 Apr 2008 06:59:58 -0400 Original-Received: by wa-out-1112.google.com with SMTP id k34so345853wah.10 for ; Fri, 11 Apr 2008 03:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; bh=Jsi9DfqjE3EvCOLG3qpxt8auc7sYD+kycPRmuKmGOCM=; b=voe6ks1GqhkW8mcNfTukWWIcQVjzBNeh+kyYNV8FJ7kUBsHfzchxvRXS/dVj/8WMfwKDB3j6RHXKwvbnng0zAiyX8ERUg6aH5KZ/N710wWLIO619vd2bGuPqQnp2ER4jofALIbtHbnBCsXt6q/eJZT0KhlslUpGCxsBx+kmNJro= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=pvBqVMZRrPITjtzM4dJ32mMymj2mywV5AL2K3nrAfIzyd7gwLWqRQvdC7vU0C40/obhwY8MLZA6ZTyh+JGc/FgPabSQ1nNpa1+I/BH88juaisxiLwXJn/fm/9wXusMvadpxbM33bOlYh59b2MjM1OtW8muIjm8UAkwmFXkuaZz8= Original-Received: by 10.114.13.1 with SMTP id 1mr3250268wam.4.1207911597448; Fri, 11 Apr 2008 03:59:57 -0700 (PDT) Original-Received: by 10.115.108.15 with HTTP; Fri, 11 Apr 2008 03:59:57 -0700 (PDT) In-Reply-To: <9895FFC8-C5BD-4E23-B6B4-B21C67A00653@gmail.com> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:17833 Archived-At: ------=_Part_41322_23666219.1207911597423 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline (This is a re-send; the original was, perhaps, caught by the spam trap because I wasn't subscribed to the list?) Go to XCode and configure it to use Emacs.app as an external editor. Compile a file which produces errors or warnings. Double-click one of them in the build window. Emacs.app comes to the foreground and activates a buffer with that file, going to the line immediately preceding the one it should be on. I took the liberty of fixing this on my copy, and am hoping the fix can be rolled into upstream: diff /tmp/mac-win.old.el /tmp/mac-win.el 1742c1742 < (goto-line line) --- > (goto-line (+ 1 line)) Diff finished. Thu Apr 10 14:48:21 2008 This should be applied against the file /Applications/Emacs.app/Contents/Resources/lisp/term/mac-win.el Thanks in advance. In GNU Emacs 22.1.50.1 (i386-apple-darwin8.10.1, Carbon Version 1.6.0) of 2007-11-06 on seijiz.local Windowing system distributor `Apple Inc.', version 10.5.2 configured using `configure '--prefix=/Applications/Emacs.app/Contents/Resources' '--with-carbon' '--without-x' '--libexecdir=/Volumes/Emacs/Emacs.app/Contents/MacOS/libexec' 'CFLAGS=-arch i386 -arch ppc -isysroot /Developer/SDKs/MacOSX10.4u.sdk -DUSE_ATSUI -DUSE_MAC_TSM'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil locale-coding-system: iso-8859-1 default-enable-multibyte-characters: t Major mode: Diff Minor modes in effect: encoded-kbd-mode: t iswitchb-mode: t desktop-save-mode: t mac-print-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t unify-8859-on-encoding-mode: t utf-translate-cjk-mode: t auto-compression-mode: t line-number-mode: t Recent input: C-n C-p C-x 1 C-n C-n C-n M-f M-f M-f M-f M-b M-b C-a M-< C-s l i n e C-s C-s C-s C-s C-s C-r C-r C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-a C-p C-l C-p C-l C-p C-l C-n C-n C-n C-e M-b ( + SPC 1 SPC C-e ) C-n C-n C-n C-n C-n C-n C-n C-n C-e C-M-b C-M-f C-x C-e M-x c o m p i l e - f i e b y t e - c o n m p m p m a c w y C-x b C-M-b C-n C-n C-l C-x 1 C-p C-x C-w / t m p / m a c - w i n . e l C-x C-f / t m p / C-g C-x C-f / t m p / m a c - w i n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n M-f M-f C-k SPC l i n e ) C-_ C-_ C-k SPC i n e ) l i n e ) C-x C-w m a c - w i n . o l d . e l C-x b e s h p u s h d SPC / t m p l s d i f SPC m a c f SPC m a c - w i n SPC m a c M-x r e p o r t - e m Recent messages: Saving file /tmp/mac-win.el... Wrote /tmp/mac-win.el Quit Undo! [2 times] Saving file /tmp/mac-win.old.el... Wrote /tmp/mac-win.old.el Loading diff...done Loading diff-mode...done Making completion list... Loading emacsbug...done -- Dan Knapp "An infallible method of conciliating a tiger is to allow oneself to be devoured." (Konrad Adenauer) ------=_Part_41322_23666219.1207911597423 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline (This is a re-send; the original was, perhaps, caught by the spam trap because I wasn't subscribed to the list?)

Go to XCode and configure it to use Emacs.app as an external editor.  Compile a file which produces errors or warnings.  Double-click one of them in the build window.  Emacs.app comes to the foreground and activates a buffer with that file, going to the line immediately preceding the one it should be on.

I took the liberty of fixing this on my copy, and am hoping the fix can be rolled into upstream:

diff  /tmp/mac-win.old.el /tmp/mac-win.el
1742c1742
<                  (goto-line line)
---
>                  (goto-line (+ 1 line))
Diff finished.  Thu Apr 10 14:48:21 2008


This should be applied against the file
/Applications/Emacs.app/Contents/Resources/lisp/term/mac-win.el

Thanks in advance.



In GNU Emacs 22.1.50.1 (i386-apple-darwin8.10.1, Carbon Version 1.6.0)
of 2007-11-06 on seijiz.local
Windowing system distributor `Apple Inc.', version 10.5.2
configured using `configure  '--prefix=/Applications/Emacs.app/Contents/Resources' '--with-carbon' '--without-x' '--libexecdir=/Volumes/Emacs/Emacs.app/Contents/MacOS/libexec' 'CFLAGS=-arch i386 -arch ppc -isysroot /Developer/SDKs/MacOSX10.4u.sdk -DUSE_ATSUI -DUSE_MAC_TSM''

Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
locale-coding-system: iso-8859-1
default-enable-multibyte-characters: t

Major mode: Diff

Minor modes in effect:
encoded-kbd-mode: t
iswitchb-mode: t
desktop-save-mode: t
mac-print-mode: t
tooltip-mode: t
mouse-wheel-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
unify-8859-on-encoding-mode: t
utf-translate-cjk-mode: t
auto-compression-mode: t
line-number-mode: t

Recent input:
C-n C-p <tab> <return> C-x 1 C-n C-n C-n M-f M-f M-f
M-f M-b M-b C-a M-< C-s l i n e C-s C-s C-s C-s C-s
C-r C-r C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s
C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-a C-p C-l
C-p C-l C-p C-l C-n C-n C-n C-e M-b ( + SPC 1 SPC C-e
) C-n C-n C-n C-n C-n C-n C-n C-n C-e C-M-b C-M-f C-x
C-e M-x c o m p i l e - f i <tab> <backspace> <backspace>
e <tab> <backspace> <tab> <tab> <M-backspace> b y t
e - c o n m p <backspace> <backspace> <backspace> m
p <tab> <tab> <tab> <return> m a c <tab> w <tab> <return>
y C-x b <return> C-M-b C-n C-n C-l C-x 1 C-p C-x C-w
/ t m p / m a c - w i n . e l <return> C-x C-f / t
m p / C-g C-x C-f / t m p / m a c - w i n <tab> <return>
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n
C-n C-n C-n M-f M-f C-k SPC l i n e ) C-_ C-_ C-k SPC
i n e ) <backspace> <backspace> <backspace> <backspace>
l i n e ) C-x C-w m a c - w i n . o l d . e l <return>
C-x b e s h <return> p u s h d SPC / t m p <return>
l s <return> d i f SPC m a c <backspace> <backspace>
<backspace> <backspace> f SPC m a c - w i n <tab> SPC
m a c <tab> <return> M-x r e p o <tab> r t - e m <tab>
<return>

Recent messages:
Saving file /tmp/mac-win.el...
Wrote /tmp/mac-win.el
Quit
Undo! [2 times]
Saving file /tmp/mac-win.old.el...
Wrote /tmp/mac-win.old.el
Loading diff...done
Loading diff-mode...done
Making completion list...
Loading emacsbug...done



--
Dan Knapp
"An infallible method of conciliating a tiger is to allow oneself to be devoured." (Konrad Adenauer) ------=_Part_41322_23666219.1207911597423--