From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Merten Newsgroups: gmane.emacs.bugs Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Date: Thu, 03 Oct 2019 22:53:43 +0200 Message-ID: <5960.1570136023@eskebo> References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> <87o8z3mhi5.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="202444"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 30063@debbugs.gnu.org, Simen =?UTF-8?Q?Heggest=C3=B8yl?= To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 03 23:11:37 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iG8Ns-000qDW-HN for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 23:11:36 +0200 Original-Received: from localhost ([::1]:40160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG8NS-0002ye-3f for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 17:11:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42751) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG8NL-0002yU-K4 for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 17:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iG8NK-00008t-EM for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 17:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60777) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iG8NK-000087-BN for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 17:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iG8NK-00018J-2h for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 17:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Merten Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2019 21:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs Original-Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.15701370464331 (code B ref 30063); Thu, 03 Oct 2019 21:11:02 +0000 Original-Received: (at 30063) by debbugs.gnu.org; 3 Oct 2019 21:10:46 +0000 Original-Received: from localhost ([127.0.0.1]:41364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG8N2-00017j-2p for submit@debbugs.gnu.org; Thu, 03 Oct 2019 17:10:44 -0400 Original-Received: from mout.kundenserver.de ([212.227.17.10]:55517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG86p-0000gY-7k for 30063@debbugs.gnu.org; Thu, 03 Oct 2019 16:53:59 -0400 Original-Received: from eskebo.homelinux.merten-home.de ([5.40.155.5]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1M8hIl-1iBzEl15Sz-004fxv; Thu, 03 Oct 2019 22:53:50 +0200 Original-Received: by eskebo.homelinux.merten-home.de (Postfix, from userid 1000) id D6BC2C015E; Thu, 3 Oct 2019 22:53:48 +0200 (CEST) In-reply-to: <87o8z3mhi5.fsf@gnus.org> Comments: In-reply-to Lars Ingebrigtsen message dated "Sun, 29 Sep 2019 14:09:06 +0200." X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.5.1 X-Provags-ID: V03:K1:0yclGBEr5FcG+WrQjtOoK66KUbY7YjDsFf9f/WZSYv+US6gd0hM +iJMR2JRsGyfyZXML9qBQFZtoCe3XqianrL/vWde4QfZlGuw7h0n1kVvlACqNnFNgmCjPSd 6kueN59+Iw+CNe/oSsBE65Nto07eQpLYLu9OjtJmzhPwl9wKjHRejoseaNuxQ4EC7sdB/gw jpKVAeK6mNdSwujsZ4G/A== X-UI-Out-Filterresults: notjunk:1;V03:K0:4p67hREUObM=:7UAY+V89Qm5+KUK+eKamQj J+4mDByH5C867S7Pug0XnwWre3TBiHGXx3p4aaCg4kzGNQQ4gTDYpV64emkbbMnEDXITRPNNE /7BXwdPxnR7e9qJeea/VBxhkIXAemFrnf+GQzzMTqYU/y1YBKizE6l37Hw2700bnFwsIOhern 3I7uAnDpMtLIxr7upliQiu/i10xUPy78BEF5UliRYsjs3qrf5NPhjojtKlgpLRNah8WDwJVyZ +KGYOXp4TM6AGbherp441duMBQPAXXa2x3SVNiZCJmTPU3XotPvWaW+t8Y2h6iD7EGvxIrJy3 jLqFuouWSUeNg2OkyprUmiyP5518RtVeRn9ulsibaBvuXrPxJ7zIsXQCN1db6bSUW2JX5iTRh 7G6vLFIeCD1t8PAeG+GM9wDjQXZY6FFA90xz7V5ZjAIjiCd5QqmjTGWTC7/2/Kb7Y12ltB4UE 6cprhlyNgo2KmGAqHgKf3nBBYte2ugQ3pf7UK6z2sjikzL30X1kM+ELCp+JNkUr7byg5sXX7a /FH8nZXtuwOqGwQC0TZPSiuNK9AAhUJ6V9E2skB5WBdwoByUqdI/TcZ4MRfT2uJ8utO8AjT7t RB/xF7IJWicw68TKj90F/Kk7PE9ehj0A8Y7MjwZyzD+KJ3RKGnUgpmsvE154ppL5x92PASijg 0OL6TzuB/R+UNp7SEgRDLq/QqpyzGc1rUw4rBj9fEDVkafNEq9h/KCbHplTJ7kW2DRdssU+Rx FYYL7ncBWaiq6ZXEIhon3wBS4+tME/IHyR/Cn6Lx9jPYabaHE2FW6wutA7Vip9zzVEN6H/lE X-Mailman-Approved-At: Thu, 03 Oct 2019 17:10:42 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168286 Archived-At: Hi all! Sorry for not looking into this for so long. This whole part of `rst.el' needs a couple of improvements. I did not write this code and frankly did not care much about it - besides adding some FIXMEs. 4 days ago Lars Ingebrigtsen wrote: > Simen Heggest=F8yl writes: >=20 >> * lisp/textmodes/rst.el (rst-compile-pdf-preview): Warn about missing >> executables when attempting to compile and preview an RST file as PDF. >> (Bug#30218) >=20 > [...] >=20 >> + (unless (executable-find pdf-compile-program) >> + (error "Cannot find executable `%s'" pdf-compile-program)) >> + (unless (executable-find rst-pdf-program) >> + (error "Cannot find executable `%s'" rst-pdf-program)) >=20 > Others pointed out that it might be nice to report error messages back > from the pdf commands, and that's true, but I think this patch makes > sense, too, because it gives good, early feedback on a likely problem, > so I think it should be applied. Well, IMHO this patch would be less than optimal. There is already (defcustom rst-compile-toolsets ...) There is an `executable-find' already for the default values. Although it only takes an alternative if it doesn't find the first guess. This is also less than optimal :-( . `rst-pdf-program' on the other hand is not yet integrated in `rst-compile-toolsets'. This is a necessary improvement. A good solution IMHO would be to have a reasonable list of defaults for (all) the executables in `rst-compile-toolsets', then check this list of defaults for executability and then set the default customization accordingly. If none of the defaults is found the customization for the respective symbol should be set to nil and the error should appear when the executable is to be used. [...browsing through the code...] Ok, a sensible solution would need quite an effort. So it's probably best to apply this patch now and when at any point in the future I come up with a more general solution it will do something equivalent or rather something better. Gr=FC=DFe Stefan