From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18093: 24.4.50; `delsel.el' fixes for use with `completion.el' Date: Wed, 23 Jul 2014 13:58:43 -0700 (PDT) Message-ID: <592101d8-bb6f-4ee3-ae58-e28f0126f09a@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1406149247 4131 80.91.229.3 (23 Jul 2014 21:00:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Jul 2014 21:00:47 +0000 (UTC) To: 18093@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 23 23:00:40 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XA3eP-0000e4-6K for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jul 2014 23:00:37 +0200 Original-Received: from localhost ([::1]:46915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA3eO-00023J-O4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jul 2014 17:00:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA3e8-00022J-IM for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 17:00:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XA3dx-0007cX-Td for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 17:00:20 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA3dx-0007cT-Qb for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 17:00:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XA3dw-0005a6-Ei for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 17:00:08 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jul 2014 21:00:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18093 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.140614916421258 (code B ref -1); Wed, 23 Jul 2014 21:00:07 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Jul 2014 20:59:24 +0000 Original-Received: from localhost ([127.0.0.1]:35927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XA3dD-0005Wk-EL for submit@debbugs.gnu.org; Wed, 23 Jul 2014 16:59:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53164) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XA3dA-0005WC-Tg for submit@debbugs.gnu.org; Wed, 23 Jul 2014 16:59:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XA3cv-00077l-8K for submit@debbugs.gnu.org; Wed, 23 Jul 2014 16:59:15 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:53638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA3cv-00077h-5o for submit@debbugs.gnu.org; Wed, 23 Jul 2014 16:59:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA3cl-0001u2-SV for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 16:59:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XA3cc-00074m-JZ for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 16:58:55 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:46239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA3cc-00074h-CS for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 16:58:46 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s6NKwigV008982 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 Jul 2014 20:58:45 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6NKwhva019276 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 23 Jul 2014 20:58:44 GMT Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6NKwh6M013498 for ; Wed, 23 Jul 2014 20:58:43 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6691.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91765 Archived-At: `delsel.el' should be updated to play well with library `completion.el'. The following should be done (or equivalent): 1. (put 'completion-separator-self-insert-command 'delete-selection t) (put 'completion-separator-self-insert-autofilling 'delete-selection t) 2. If `last-command' is `complete' and `this-command' has `delete-selection' property `supersede' or `kill', replace the last inserted completion with the string that was completed. (defun delete-active-region (&optional killp) (cond ((and (eq last-command 'complete) ; See `completion.el'. (boundp 'cmpl-last-insert-location)) ;; Do not delete region if a `self-insert-command'. Delete it onl= y if a ;; supersede or a kill. (when (and (symbolp this-command) (memq (get this-command 'delete-selection) '(supersede = kill))) (delete-region (point) cmpl-last-insert-location) ; Free var her= e. (insert cmpl-original-string) ; Free var here. (setq completion-to-accept nil))) ; Free var here. (killp ; Do not let `kill-region' change `this-c= ommand' (let (this-command) (if (or (> emacs-major-version 24) (and (=3D emacs-major-version 24) (< emacs-minor-versio= n 4))) (kill-region (point) (mark) 'REGION) (kill-region (point) (mark))))) ((boundp 'region-extract-function) ; Emacs 24.4+ (funcall region-extract-function 'delete-only)) (t (delete-region (point) (mark)))) (deactivate-mark) t) In GNU Emacs 24.4.50.1 (i686-pc-mingw32) of 2014-06-28 on ODIEONE Bzr revision: 117431 rgm@gnu.org-20140628015517-eku6hj8mpgcvfnso Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/snapshot/trunk --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib 'CPPFLAGS=3D-DGC_MCHECK=3D1 -Ic:/Devel/emacs/include''