From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Stephan Stahl" Newsgroups: gmane.emacs.devel Subject: Re: fix to make log-view.el work with svn Date: Fri, 11 Jan 2008 15:15:05 +0100 (CET) Message-ID: <59209.88.217.20.211.1200060905.squirrel@www.franken.de> References: <58567.88.217.35.200.1199972009.squirrel@www.franken.de> <6esl15j6u2.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1200060966 23619 80.91.229.12 (11 Jan 2008 14:16:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Jan 2008 14:16:06 +0000 (UTC) Cc: Stephan Stahl , emacs-devel@gnu.org To: "Glenn Morris" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 11 15:16:27 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JDKgK-00088D-Rt for ged-emacs-devel@m.gmane.org; Fri, 11 Jan 2008 15:16:25 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JDKfx-0006s7-6m for ged-emacs-devel@m.gmane.org; Fri, 11 Jan 2008 09:16:01 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JDKfK-00066z-ES for emacs-devel@gnu.org; Fri, 11 Jan 2008 09:15:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JDKfJ-000667-K6 for emacs-devel@gnu.org; Fri, 11 Jan 2008 09:15:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JDKfJ-00065c-8H for emacs-devel@gnu.org; Fri, 11 Jan 2008 09:15:21 -0500 Original-Received: from mail-n.franken.de ([193.175.24.27]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JDKfF-0003Fw-0S; Fri, 11 Jan 2008 09:15:17 -0500 Original-Received: from www.franken.de (melissa.franken.de [193.175.24.34]) by mail-n.franken.de (Postfix) with ESMTP id A7CED801AC3C; Fri, 11 Jan 2008 15:15:05 +0100 (CET) Original-Received: from 88.217.20.211 (SquirrelMail authenticated user eos) by www.franken.de with HTTP; Fri, 11 Jan 2008 15:15:05 +0100 (CET) In-Reply-To: <6esl15j6u2.fsf@fencepost.gnu.org> User-Agent: SquirrelMail/1.4.6 X-Priority: 3 (Normal) Importance: Normal X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:86746 Archived-At: Hi Glenn. Glenn Morris wrote: > "Stephan Stahl" wrote: > >> lisp/log-view.el is said to work with svn but it does not work for >> me unless i patch these lines (or change the variable by hand..). >> Maybe someone wants to apply this change to the emacs sources. > > What version of Emacs, and please give a recipe starting from -Q > showing a problem. Happend with: GNU Emacs 23.0.0.1 (i386-mingw-nt5.1.2600) of 2007-08-18 on TPAD which is the 'current' one from http://ntemacs.sourceforge.net/ I just opened a file under svn control and did C-x v l and then pressed d= to view the diff for the last and previous version. Result was: log-view-current-file: Search failed: "^\\(?:Working file: \\(?1:.+\\)\\|= \\(?:SCCS/s\\.\\|Changes to \\)\\(?1:.+\\):\\) " > The current version of vc-svn in the CVS trunk uses "Working file" > (singular) AFAICS, so I don't see why that change would be needed. I did take a look at emacs-snapshot installed on my debian laptop and you= are right vc-svn uses "Working file" there! GNU Emacs 23.0.50.1 (i486-pc-linux-gnu, GTK+ Version 2.12.3) of 2008-01-0= 6 on eligiac, modified by debian from http://emacs.orebokech.com SO SORRY, guess i was too fast and will simply patch the file on my compu= ter at work.. Regards and thanks for the quick response, Stephan