From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Warnings about keymaps Date: Fri, 11 Sep 2009 13:34:14 -0400 Message-ID: <58wglpeqx.fsf@fencepost.gnu.org> References: <83ocph26p7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1252690508 407 80.91.229.12 (11 Sep 2009 17:35:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Sep 2009 17:35:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 11 19:35:01 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MmA1U-00020W-P4 for ged-emacs-devel@m.gmane.org; Fri, 11 Sep 2009 19:35:01 +0200 Original-Received: from localhost ([127.0.0.1]:55909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmA1U-0000IM-0q for ged-emacs-devel@m.gmane.org; Fri, 11 Sep 2009 13:35:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmA0q-0008RG-Bf for emacs-devel@gnu.org; Fri, 11 Sep 2009 13:34:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmA0l-0008OD-M3 for emacs-devel@gnu.org; Fri, 11 Sep 2009 13:34:19 -0400 Original-Received: from [199.232.76.173] (port=58870 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmA0l-0008O8-Jx for emacs-devel@gnu.org; Fri, 11 Sep 2009 13:34:15 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:48902) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MmA0l-0006Hd-C4 for emacs-devel@gnu.org; Fri, 11 Sep 2009 13:34:15 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MmA0k-000858-Ok; Fri, 11 Sep 2009 13:34:14 -0400 X-Spook: strategic pre-emptive MD5 ANC nuclear oil kilo class SAPO X-Ran: 3A\H3_7E9pS*@4I}x9zLD'yF?,$J'ho.)>(2u(d&evG.~}_XQk`'7I\!_-8T3(^ZViDn}V X-Hue: white X-Attribution: GM In-Reply-To: <83ocph26p7.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Sep 2009 12:04:20 +0300") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115194 Archived-At: Eli Zaretskii wrote: > emacs/lisp/cvs-status.el:93:22:Warning: variable assignment to constant > `cvs-status-mode-map' I think this is because easy-mmode-defmap defines cvs-status-mode-map as a constant. Then, later on, the define-derived-mode macro tries to do a defvar on cvs-status-mode-map. The simple change is to make easy-mmode-defmap use defvar instead of defconst; the slightly more correct thing (that I could not get to work...) is to make define-derived-mode only defvar the mode map if it is not already defined.