all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>, Akib Azmain Turja <akib@disroot.org>
Cc: 59963@debbugs.gnu.org
Subject: bug#59963: 29.0.50; 'window-max-chars-per-line' doesn't always work on GUI without fringe
Date: Mon, 12 Dec 2022 09:18:28 +0100	[thread overview]
Message-ID: <58cc3d32-65f9-d4ad-4668-732af0f3aa36@gmx.at> (raw)
In-Reply-To: <83ilihudcr.fsf@gnu.org>

 > Using left/right-fringe-width in window-max-chars-per-line is IMO
 > wrong, we should use window-fringes (which will return correct values
 > both when the window has its private valuesm, either via
 > set-window-fringes or via assignment of left/right-fringe-width, and
 > when it doesn't).

This should have been done at the time that function was installed.  If
you do it now, you may break valid code like

(let (max-chars)
   (setq right-fringe-width 0)
   (setq max-chars (window-max-chars-per-line))
   (set-window-buffer nil (window-buffer))
   max-chars)

which currently yields 79 and would yield 80 with your proposal.

martin





  reply	other threads:[~2022-12-12  8:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11 11:13 bug#59963: 29.0.50; 'window-max-chars-per-line' doesn't always work on GUI without fringe Akib Azmain Turja via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-11 14:43 ` Eli Zaretskii
2022-12-11 14:50   ` Akib Azmain Turja via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <87o7sac78t.fsf@disroot.org>
2022-12-11 15:21     ` Akib Azmain Turja via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-11 16:14       ` Eli Zaretskii
2022-12-12  8:18         ` martin rudalics [this message]
2022-12-12 13:10           ` Eli Zaretskii
2022-12-12 16:50             ` martin rudalics
2022-12-14 15:21             ` Eli Zaretskii
2022-12-15 15:53               ` Akib Azmain Turja via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-17 12:05                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58cc3d32-65f9-d4ad-4668-732af0f3aa36@gmx.at \
    --to=rudalics@gmx.at \
    --cc=59963@debbugs.gnu.org \
    --cc=akib@disroot.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.