From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Undo mode Date: Sat, 22 Jan 2022 09:08:46 +0000 Message-ID: <58bb8030d5ed075bc9df@heytings.org> References: <86tudyw1ir.fsf@mail.linkov.net> <6d8355dee1bb42a18fd0@heytings.org> <87h79xxw7t.fsf@yahoo.com> <6d8355dee13363ee16cd@heytings.org> <83wnitnvum.fsf@gnu.org> <6d8355dee168648eba0c@heytings.org> <83lez9noq8.fsf@gnu.org> <6d8355dee1d428e87037@heytings.org> <83fspgoozi.fsf@gnu.org> <6d8355dee1e5981e5c5a@heytings.org> <835yqcnt1l.fsf@gnu.org> <58bb8030d598aedf86e1@heytings.org> <831r10nodm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="pMgLMuyRP0" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27191"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, juri@linkov.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 22 10:13:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBCSm-0006tK-8A for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 10:13:36 +0100 Original-Received: from localhost ([::1]:41548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBCSk-0006LR-UY for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 04:13:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBCOC-00049r-Kv for emacs-devel@gnu.org; Sat, 22 Jan 2022 04:08:52 -0500 Original-Received: from heytings.org ([95.142.160.155]:36412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBCOA-0005bR-OR; Sat, 22 Jan 2022 04:08:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1642842526; bh=FGgO4A1Zi04IKE+Jt4aUZn956LHTiiYPXP8EtiQ5GQc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=QkoJFzYuJbT/0FVZyNDvz+ZCS+PkYBh554p9w/BpqmuzwzH2xsaIP7FpJX+Rv/ccT je6joA+RPqFdr737y7vnx12DNG1o0dXV6lEk2oHVpa0ICn8+YPGJewMW33LGio31uP 8RyZVc01jsL2CDjwx5E05uSYtcVCS6QL0n/Np9b6ztwk5QifChtaMKGc9YaYYwLUCv ibUfx+1+GRPx02ynhuxfKM9dbcp8Px9ZOufvKFr9ufyM6wRXmJNPlcs+Zg4QfSj5ed VxxI5Ry5kLA8UNKHMaBQ3Kqzkg0+zhv3tkJcxQzL5kWYZW3S8H2XsCsqCfgcU/o9lT IuVLwf76NHrdA== In-Reply-To: <831r10nodm.fsf@gnu.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285179 Archived-At: --pMgLMuyRP0 Content-Type: text/plain; charset=us-ascii; format=flowed >> The point is that there should be no more than one menu item for that >> feature. There are two, that's one too much. There is no reason to >> turn that feature, which has no practical effect except that it uses a >> few more bytes in the heap, on and off from the menu. > > I already explained why it would be very unusual to have a feature that > can only be turned on from the menu, but cannot be turned off. I see no > reason for such strange behavior for this single mode. > Which is why I suggested to remove the possibility of enabling it from the menu. See the attached patch (again). --pMgLMuyRP0 Content-Type: text/x-diff; name=Fix-Undelete-Frame-menu-item.patch Content-Transfer-Encoding: base64 Content-ID: <58bb8030d57316db5f60@heytings.org> Content-Disposition: attachment; filename=Fix-Undelete-Frame-menu-item.patch RnJvbSBhZjVkZWEzMGNjNDBjYTdiOGFhYmM1ODg5OGIxZTJiZDc1NWJlYWU2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBTYXQsIDIyIEph biAyMDIyIDA4OjIxOjQxICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEZpeCBV bmRlbGV0ZSBGcmFtZSBtZW51IGl0ZW0NCg0KKiBsaXNwL21lbnUtYmFyLmVs IChtZW51LWJhci1maWxlLW1lbnUpOiBSZXBsYWNlIHRoZSBjaGVja2JveCB3 aXRoIGENCmEgZGlzYWJsZWQgaXRlbSB3aXRoIGEgdG9vbHRpcCB0ZWxsaW5n IHRoYXQgdGhlIG1vZGUgaXMgZGlzYWJsZWQuDQotLS0NCiBsaXNwL21lbnUt YmFyLmVsIHwgMTQgKysrKysrKy0tLS0tLS0NCiAxIGZpbGUgY2hhbmdlZCwg NyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0 IGEvbGlzcC9tZW51LWJhci5lbCBiL2xpc3AvbWVudS1iYXIuZWwNCmluZGV4 IDgxN2MyZDQ4NWUuLjhkNGFjMTY5MmYgMTAwNjQ0DQotLS0gYS9saXNwL21l bnUtYmFyLmVsDQorKysgYi9saXNwL21lbnUtYmFyLmVsDQpAQCAtMTA4LDE1 ICsxMDgsMTUgQEAgbWVudS1iYXItZmlsZS1tZW51DQogICAgIChiaW5kaW5n cy0tZGVmaW5lLWtleSBtZW51IFtzZXBhcmF0b3ItdGFiXQ0KICAgICAgIG1l bnUtYmFyLXNlcGFyYXRvcikNCiANCi0gICAgKGJpbmRpbmdzLS1kZWZpbmUt a2V5IG1lbnUgW3VuZGVsZXRlLWZyYW1lLW1vZGVdDQotICAgICAgJyhtZW51 LWl0ZW0gIkFsbG93IFVuZGVsZXRpbmcgRnJhbWVzIiB1bmRlbGV0ZS1mcmFt ZS1tb2RlDQotICAgICAgICAgICAgICAgICAgOmhlbHAgIkFsbG93IGZyYW1l cyB0byBiZSByZXN0b3JlZCBhZnRlciBkZWxldGlvbiINCi0gICAgICAgICAg ICAgICAgICA6YnV0dG9uICg6dG9nZ2xlIC4gdW5kZWxldGUtZnJhbWUtbW9k ZSkpKQ0KLQ0KKyAgICAoYmluZGluZ3MtLWRlZmluZS1rZXkgbWVudSBbZGlz YWJsZWQtdW5kZWxldGUtZnJhbWUtbW9kZV0NCisgICAgICAnKG1lbnUtaXRl bSAiVW5kZWxldGUgRnJhbWUiIHVuZGVsZXRlLWZyYW1lDQorICAgICAgICAg ICAgICAgICAgOnZpc2libGUgKG51bGwgdW5kZWxldGUtZnJhbWUtbW9kZSkN CisgICAgICAgICAgICAgICAgICA6ZW5hYmxlIG5pbA0KKyAgICAgICAgICAg ICAgICAgIDpoZWxwICJVbmRlbGV0ZS1GcmFtZSBtb2RlIGlzIGN1cnJlbnRs eSBkaXNhYmxlZCIpKQ0KICAgICAoYmluZGluZ3MtLWRlZmluZS1rZXkgbWVu dSBbdW5kZWxldGUtbGFzdC1kZWxldGVkLWZyYW1lXQ0KICAgICAgICcobWVu dS1pdGVtICJVbmRlbGV0ZSBGcmFtZSIgdW5kZWxldGUtZnJhbWUNCi0gICAg ICAgICAgICAgICAgICA6ZW5hYmxlIChhbmQgdW5kZWxldGUtZnJhbWUtbW9k ZQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNhciB1bmRl bGV0ZS1mcmFtZS0tZGVsZXRlZC1mcmFtZXMpKQ0KKyAgICAgICAgICAgICAg ICAgIDp2aXNpYmxlIHVuZGVsZXRlLWZyYW1lLW1vZGUNCisgICAgICAgICAg ICAgICAgICA6ZW5hYmxlIHVuZGVsZXRlLWZyYW1lLS1kZWxldGVkLWZyYW1l cw0KICAgICAgICAgICAgICAgICAgIDpoZWxwICJVbmRlbGV0ZSB0aGUgbW9z dCByZWNlbnRseSBkZWxldGVkIGZyYW1lIikpDQogDQogICAgIDs7IERvbid0 IHVzZSBkZWxldGUtZnJhbWUgYXMgZXZlbnQgbmFtZSBiZWNhdXNlIHRoYXQg aXMgYSBzcGVjaWFsDQotLSANCjIuMzQuMQ0KDQo= --pMgLMuyRP0--