From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string Date: Mon, 05 Dec 2022 21:38:14 +0100 Message-ID: <58E4C303-E76E-495B-90C3-6DAAB79FCFED@thornhill.no> References: <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> <87o7shx580.fsf@thornhill.no> <848BAB21-6F05-4CE2-BCD7-F0CE0FC1ED5F@thornhill.no> <9990C324-CCC5-4B15-9112-FAB6508E41A8@gmail.com> <6344E557-688E-44C5-BF84-CA88999BAF4E@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16348"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , 59833@debbugs.gnu.org, jostein@kjonigsen.net, 59833-done@debbugs.gnu.org To: Yuan Fu , Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 21:40:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2IG5-00040I-IU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 21:40:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2IFw-0000YZ-Cr; Mon, 05 Dec 2022 15:40:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2IFv-0000YI-36 for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 15:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2IFu-000492-RK for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 15:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2IFu-0001M9-Mo for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 15:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59833 X-GNU-PR-Package: emacs Original-Received: via spool by 59833-done@debbugs.gnu.org id=D59833.16702727565191 (code D ref 59833); Mon, 05 Dec 2022 20:40:02 +0000 Original-Received: (at 59833-done) by debbugs.gnu.org; 5 Dec 2022 20:39:16 +0000 Original-Received: from localhost ([127.0.0.1]:38281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2IFA-0001La-9x for submit@debbugs.gnu.org; Mon, 05 Dec 2022 15:39:16 -0500 Original-Received: from out-32.mta0.migadu.com ([91.218.175.32]:41906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2IF6-0001LN-Rd for 59833-done@debbugs.gnu.org; Mon, 05 Dec 2022 15:39:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670272751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1hKkihXwzZqAoQL/PO8cjuTs4Sw+JmwVJNYKCy6O5PI=; b=t8Ici/NV2yjG6ZRZWJbYo+g4ub/r0jr1ODA66AdOiPsk4aQqIZROFx0KeId/DIi4w/fu8o qv3hptOsxKxFYugoLB1v6radQyEieRcNjQ5QEfW8RrMbM4QEroWbOsaS8grIaHpJwQK/MG hzdGWE4v8qbodjINpHbtUXkLu9AkUqlfbf25gZKbuuXEITyICp0UT33OPDIc8UngiDqG8O +/k2r9Y0TpZxlRxkDhVkwuRrMrqM2tYS2ix3S9W6Ysz6tLKo1W6uhfyNGSrDjFwUfiSSwB Ml+vs6pYqz9ORT6+kBRNbI25+wOjU4ph7Et13sTaeTUMl5Gd8W/afT76dubf/A== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250072 Archived-At: On 5 December 2022 21:22:09 CET, Yuan Fu wrote: > > >> On Dec 5, 2022, at 12:19 PM, Randy Taylor wrote: >>=20 >> On Monday, December 5th, 2022 at 15:14, Theodor Thornhill wrote: >>>=20 >>>=20 >>> On 5 December 2022 20:57:55 CET, Yuan Fu casouri@gmail=2Ecom wrote: >>>=20 >>>>> On Dec 5, 2022, at 7:37 AM, Theodor Thornhill via Bug reports for GN= U Emacs, the Swiss army knife of text editors bug-gnu-emacs@gnu=2Eorg wrote= : >>>>>=20 >>>>> On 5 December 2022 16:35:12 CET, Randy Taylor dev@rjt=2Edev wrote: >>>>>=20 >>>>>> On Monday, December 5th, 2022 at 10:03, Theodor Thornhill theo@thor= nhill=2Eno wrote: >>>>>>=20 >>>>>>> Yeah js-json-mode is a lot simpler, and is imo too simple=2E The j= son-mode >>>>>>> is not infact default in emacs, but there are two, one in melpa an= d one >>>>>>> in elpa, IIRC=2E >>>>>>>=20 >>>>>>> Anyway, last patch for now - are you both satisfied with this one? >>>>>>>=20 >>>>>>> Theo >>>>>>=20 >>>>>> It's perfect! Sorry for all the trouble :D=2E >>>>>=20 >>>>> No problem :) >>>>>=20 >>>>> Yuan, will you commit this one? >>>>=20 >>>> Yeah=2E IIUC :override t is not necessary for pair, right? If so, I= =E2=80=99ll apply the patch and remove the :override, is that OK? >>>>=20 >>>> Yuan >>>=20 >>>=20 >>> Please test it first, but sure! We want it to not be string face at le= ast :) >>>=20 >>> Theo >>=20 >> It's necessary, since string comes first and pair needs to override it = (just tested)=2E > >Ah, yes, of course, sorry for my ignorance=2E Applied! > >Yuan Great news, thanks!