From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Manual suggestions for quit-restore documentation Date: Fri, 24 Mar 2017 19:52:58 +0100 Message-ID: <58D56B0A.1070405@gmx.at> References: <87varoh5ka.fsf@ericabrahamsen.net> <58BBE3DB.7000000@gmx.at> <8737e37ozr.fsf@ericabrahamsen.net> <58D4E0F8.10500@gmx.at> <87mvca7k7h.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1490381656 10592 195.159.176.226 (24 Mar 2017 18:54:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 24 Mar 2017 18:54:16 +0000 (UTC) To: Eric Abrahamsen , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 24 19:54:12 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crULg-0001v0-5i for ged-emacs-devel@m.gmane.org; Fri, 24 Mar 2017 19:54:08 +0100 Original-Received: from localhost ([::1]:34537 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crULl-0001JX-Ql for ged-emacs-devel@m.gmane.org; Fri, 24 Mar 2017 14:54:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crUKo-0001I0-MI for emacs-devel@gnu.org; Fri, 24 Mar 2017 14:53:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crUKl-0000e3-Vw for emacs-devel@gnu.org; Fri, 24 Mar 2017 14:53:14 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:58768) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1crUKl-0000c9-Mf for emacs-devel@gnu.org; Fri, 24 Mar 2017 14:53:11 -0400 Original-Received: from [192.168.1.100] ([213.162.68.26]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M4Wwq-1bxTSz19a8-00yfXW; Fri, 24 Mar 2017 19:53:01 +0100 In-Reply-To: <87mvca7k7h.fsf@ericabrahamsen.net> X-Provags-ID: V03:K0:hMdFUyPsLHnmqyhNnK4d4xRKOXXpH34Po3inS6ASpAXFDErZ5jm CPxsE/RByjcOxKmaOuy/YZg14vSje4yAi7t223czopCaPRNNI3nCsYLFx6l2DirYLNpXFOK hrqgpxEJPrZqpie89MOxHSWowgulCOUGkQqDuuo8KCXe1xJ8bP6RJwZXcusjj8CoVSPlCu7 CJcruT604EBat9b6OJsig== X-UI-Out-Filterresults: notjunk:1;V01:K0:oR1ZfqCtAbs=:rtT7GrTiGWGbYl8Bl/UFmR i4Kdg8hm2LsPMi7PoPA7dIcfE+22A5bZ02exmcVYVqlmCI2hHAKWEh8JK+EmV0MN/x7mtgCdR V4yfEn03USlXVFYJopQkl1pXoy81aP4LV4RkqAPwq1r54hiy86ZujYUiv+R88yQnyqpg/VKDe eXvr/MV+IvqaiAEnV1iAvK2gcXcQZ/MHyUoH3CDsL7mvAPXPMO5G4Fh5FYAGOhQ9D0zb8qnq2 IAozAt3GJKAetd3jVVvIEY6nTfIZY2jyi7V0Ot0bCm0t4d4pJdiaC7YOvamGvYdbFN9/RxJw9 xrUfjUYog5m1ZBze3MLJ/NwLjDbdpDIWZAScp3+R/8REwH32bsBTKQALx2RZ+riyg7AbtOSbh CzbqDNmPcedziFO9iw0J8UM+zDGkC8yZGcD2+f0+OjiRVHI2nLrMDOTdpGEf0e/13vMRjCDW+ id5ViYHUasAEn1Kn/boYsXT/sdIljWkh0tCrO4prEkukU/NiSSJoxA838xgNRosvP8JAhvrFI 6U7Q2xRzBFXHNhKnZF7eyxTG1XucSct3P9fUQQc2p14TZiveOqYNDqKRqQV1MNqQPv8H1sIMk yUTE8CriExu7IOcj0tgUy2C4tGvEwR3AuoSXDqZpuFnI0uyaGpU8kW5cxmEzP/u3JV0i239AQ M2v505gsddpMmBcG2ClmAxso0bdAhL2Xjaabat7D8kokc8S0R5EMVf6prBVAtqP9JBnIKTUy2 knfUenRVoN6knBcSN6yPap5mzWmt8ZDUOw3GO547MZx1tWiKbgocOtFxBk83TTRlL3D1iO0M X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213309 Archived-At: > Now I'm missing something -- I'm talking about (car quit-restore) -> > 'other. Unless I'm really turned around, I don't see that getting checked. Right. What the code for 'other installs is currently checked by the ((and (listp (setq quad (nth 1 quit-restore))) (buffer-live-p (car quad)) (eq (nth 3 quit-restore) buffer)) condition. I didn't bother to check for 'other here since it's the only remaining case. But if we ever want to add a new case in addition to 'frame, 'window and 'other and that new case has the same structure as 'other, we will have to check for 'other to discriminate the new case from the 'other case. Hence, I recommend to use 'other even if it's nowhere checked at the moment so code written from your recommendations is prepared for future changes in this area. > That's still a bit off, as it sounds like we're setting the function > name to nil. How about: > > Setting the window history to nil ensures that a future call to > @code{quit-window} can delete the window altogether. Perfect! >>> +re-uses the window to display the buffer. >> >> Would "reuses" be bad English? > > No, they're both acceptable spellings, "reuses" is fine. > > Let me know what you think about 'other, and I'll do a proper commit. Let me know if my remark above was not clear enough. Thanks again for working on this, martin