all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eric Abrahamsen <eric@ericabrahamsen.net>, emacs-devel@gnu.org
Subject: Re: Manual suggestions for quit-restore documentation
Date: Fri, 24 Mar 2017 19:52:58 +0100	[thread overview]
Message-ID: <58D56B0A.1070405@gmx.at> (raw)
In-Reply-To: <87mvca7k7h.fsf@ericabrahamsen.net>

 > Now I'm missing something -- I'm talking about (car quit-restore) ->
 > 'other. Unless I'm really turned around, I don't see that getting checked.

Right.  What the code for 'other installs is currently checked by the

      ((and (listp (setq quad (nth 1 quit-restore)))
	   (buffer-live-p (car quad))
	   (eq (nth 3 quit-restore) buffer))

condition.  I didn't bother to check for 'other here since it's the only
remaining case.  But if we ever want to add a new case in addition to
'frame, 'window and 'other and that new case has the same structure as
'other, we will have to check for 'other to discriminate the new case
from the 'other case.  Hence, I recommend to use 'other even if it's
nowhere checked at the moment so code written from your recommendations
is prepared for future changes in this area.

 > That's still a bit off, as it sounds like we're setting the function
 > name to nil. How about:
 >
 > Setting the window history to nil ensures that a future call to
 > @code{quit-window} can delete the window altogether.

Perfect!

 >>> +re-uses the window to display the buffer.
 >>
 >> Would "reuses" be bad English?
 >
 > No, they're both acceptable spellings, "reuses" is fine.
 >
 > Let me know what you think about 'other, and I'll do a proper commit.

Let me know if my remark above was not clear enough.

Thanks again for working on this, martin



  reply	other threads:[~2017-03-24 18:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-05  1:32 Manual suggestions for quit-restore documentation Eric Abrahamsen
2017-03-05  2:14 ` Drew Adams
2017-03-05  4:37   ` Eric Abrahamsen
2017-03-05  4:39     ` Eric Abrahamsen
2017-03-05 10:09     ` martin rudalics
2017-03-05 10:09 ` martin rudalics
2017-03-05 17:24   ` Eric Abrahamsen
2017-03-23 19:49   ` Eric Abrahamsen
2017-03-24  9:03     ` martin rudalics
2017-03-24 15:44       ` Eric Abrahamsen
2017-03-24 18:52         ` martin rudalics [this message]
2017-03-24 19:17           ` Eric Abrahamsen
2017-03-25  9:24             ` martin rudalics
2017-03-25 16:57               ` Eric Abrahamsen
2017-03-26  8:39                 ` martin rudalics
2017-03-26 14:49                   ` Eli Zaretskii
2017-03-26 15:33                     ` Eric Abrahamsen
2017-03-26 16:27                       ` Eli Zaretskii
2017-03-26 23:40                         ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58D56B0A.1070405@gmx.at \
    --to=rudalics@gmx.at \
    --cc=emacs-devel@gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.