bug#25946: 26.0.50; display-buffer ignores ignores reusable-frames in display-buffer-alist

[martin rudalics <rudalics@gmx.at>]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

 > I'll try once I know how to create special/dedicated frames.

Impossible since the "fix" for Bug#15133.  Apparently no one used this
in the past four years.  Please apply the attached patch and try again.
The following example works here now as intended.

(customize-set-variable
  'display-buffer-alist
  '(("\\*text\\*"
     (display-buffer-reuse-window display-buffer-pop-up-frame)
     (reusable-frames . t))))

(setq display-buffer-mark-dedicated t)

(display-buffer (get-buffer-create "*text*"))

(kill-buffer "*text*")

martin

[-- Attachment #2: window.el.diff --]
[-- Type: text/plain, Size: 1962 bytes --]

diff --git a/lisp/window.el b/lisp/window.el
index 358d7bc..4fd1c10 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -5986,7 +5986,10 @@ display-buffer-record-window
 shown in the window, that buffer's window start and window point,
 and the window's height.  The third element is the window
 selected at the time the parameter was created.  The fourth
-element is BUFFER."
+element is BUFFER.
+
+When TYPE equals `window' or `frame' this function also clears
+the list of previous buffers of WINDOW."
   (cond
    ((eq type 'reuse)
     (if (eq (window-buffer window) buffer)
@@ -6018,12 +6021,14 @@ display-buffer-record-window
     ;; WINDOW has been created on an existing frame.
     (set-window-parameter
      window 'quit-restore
-     (list 'window 'window (selected-window) buffer)))
+     (list 'window 'window (selected-window) buffer))
+    (set-window-prev-buffers window nil))
    ((eq type 'frame)
     ;; WINDOW has been created on a new frame.
     (set-window-parameter
      window 'quit-restore
-     (list 'frame 'frame (selected-window) buffer)))))
+     (list 'frame 'frame (selected-window) buffer)))
+   (set-window-prev-buffers window nil)))

 (defcustom display-buffer-function nil
   "If non-nil, function to call to handle `display-buffer'.
@@ -6643,11 +6648,9 @@ window--display-buffer
     (display-buffer-record-window type window buffer)
     (unless (eq buffer (window-buffer window))
       (set-window-dedicated-p window nil)
-      (set-window-buffer window buffer)
-      (when dedicated
-	(set-window-dedicated-p window dedicated))
-      (when (memq type '(window frame))
-	(set-window-prev-buffers window nil)))
+      (set-window-buffer window buffer))
+    (when (and dedicated (memq type '(window frame)))
+      (set-window-dedicated-p window dedicated))
     (let ((quit-restore (window-parameter window 'quit-restore))
 	  (height (cdr (assq 'window-height alist)))
 	  (width (cdr (assq 'window-width alist)))