From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized Date: Sat, 28 Jan 2017 09:02:11 +0100 Message-ID: <588C5003.4070409@gmx.at> References: <5889C6B4.8060506@gmx.at> <588A0102.7010704@gmx.at> <588B108E.9070501@gmx.at> <588B1437.9010303@gmx.at> <588B4F7C.40909@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1485590616 10281 195.159.176.226 (28 Jan 2017 08:03:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 08:03:36 +0000 (UTC) Cc: 25542@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 28 09:03:32 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXNyq-00021a-Ib for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2017 09:03:28 +0100 Original-Received: from localhost ([::1]:50346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXNyw-0004tK-2K for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2017 03:03:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXNyU-0004ik-MT for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 03:03:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXNyQ-0003kP-LZ for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 03:03:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXNyQ-0003jt-IM for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 03:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXNyQ-0003bU-5Z for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 03:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2017 08:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25542 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25542-submit@debbugs.gnu.org id=B25542.148559055713820 (code B ref 25542); Sat, 28 Jan 2017 08:03:02 +0000 Original-Received: (at 25542) by debbugs.gnu.org; 28 Jan 2017 08:02:37 +0000 Original-Received: from localhost ([127.0.0.1]:48765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXNy1-0003aq-6M for submit@debbugs.gnu.org; Sat, 28 Jan 2017 03:02:37 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:63701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXNxz-0003ab-FQ for 25542@debbugs.gnu.org; Sat, 28 Jan 2017 03:02:36 -0500 Original-Received: from [192.168.1.100] ([213.162.68.35]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MaaOf-1cn06Y36Px-00K7DZ; Sat, 28 Jan 2017 09:02:15 +0100 In-Reply-To: X-Provags-ID: V03:K0:N+WlfsUPqu28gjVClz9kqs423kyCF4WglQIh/7QO9ysHAYANmyo JHcOXWfNiaEiWgs9bZPxcsXGcUwA/lcvymsabzF2T4ShrFhKmN0vKZulyFUvnUzSh5qE3tj 3R91gNxzApfUiT6gla3QYr0o4pW7XMEGRNICITBUgIyCicyWeTwf8EULy+AsY1ES/Nw21Xl psGfVek5L4NxvECXJccGA== X-UI-Out-Filterresults: notjunk:1;V01:K0:x8V6GBG9BH4=:W+Mb/S/XvAeY7tuJWlU8QB 45EeX96g9NfvVi6Bo25zKLV9xQOAYz93d7Mq2yNigOOjVWoNQuTtbLyi7wqCtNbsfiETJR3YQ Dvo5f8EeCUi0ZVCqJAFVrWT/aJcyNBL9xnjORzr9ZFpccW+Nd9o4OLycJABdcY3Do7l5IGj+o 9A7K/Q7rj/PgxuGkP84PLqyTpHtL9blitSRF3uq+wkhGhAz+H93ZP1yhAlAZbbhbdrkGmRbbd llwpZaMYkjXD7kyCFZScLqMc4AhXQO9HQDgIyBnKLreGKILtQ9LsXqLWwY5U/gxs5pbTpxdQz fqgnHdYTsyoryumHKIgE+851I+Yguv56U40DNYwNELwC7pKpWunIns3IBqgvTTixDjAzczpaL 4Al94ENdtPpY8PtAmmnwTyd0zynbov5qJGQLLrtLqmF9EtoBpNOREbUCGSfnQBGH56cOsYdfp dOpCXkHz6j/WOJVwkGWySnev4iGn/SwZRyJwyxtY+n0Ddga620y3OoIiheLgAdhwilFEE3rLI dhH7riRbgbpxTxb2YvkY+yZ22tEXwKZ93IxEb+E55fSqTCiJxke7w+ZdEHomiGF7YHp1zVHkB WZX+jasHOBUp07n4WAG+ph0+4JxgAUGkKakK1nRfVBJue9ziLJpbJRci15y6OTOQU3wnv/LdX n/wv4KPVI7gYcjq9fGr/OBwDavXEJXgPvuQGK9DkU8guO76k+oeew3mLUxci3OdHrZfacwniY hwaV56j5Xn7fFrk7a4g5cwtuqF5l4puCzLq9OzIn+tYvAcQR0Ri7QvaxNlmcwdjuIpZRS044 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128708 Archived-At: > Your assumption is correct. I added some message calls to master (as > in the attached diff). With the taskbar on the left I got: > > SIZE_MAXIMIZED, fullscreen = nil > SIZE_MAXIMIZED, x = 54, y = -8 > > on the maximize, and > > SIZE_MAXIMIZED, fullscreen = fullboth > > on hitting f11 the first time. Nothing the second time (when Emacs > incorrectly switches to non-maximized state). > > With the taskbar on top it's the same except x = -8, y = 22 (when > taskbar is on the right or botton both x and y are -8 and the the > second f11 produces the same message as maximizing). Thank you very much for checking. I suppose that replacing if (EQ (fullscreen, Qfullwidth) || EQ (fullscreen, Qfullheight) || NILP (fullscreen)) { int x, y; x_real_positions (f, &x, &y); if (x < 0 && y < 0) store_frame_param (f, Qfullscreen, Qmaximized); } with store_frame_param (f, Qfullscreen, Qmaximized); should work because I doubt that "Windows can send us a SIZE_MAXIMIZED message even when fullscreen is fullboth" can happen but who knows ... martin