From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24594: 24.5; `variable-pitch-mode': accept FACE arg instead of hardcoding the face Date: Sun, 2 Oct 2016 20:48:19 -0700 (PDT) Message-ID: <587cb6c7-44f8-4546-91ee-264416c965d6@default> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1475466571 19052 195.159.176.226 (3 Oct 2016 03:49:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Oct 2016 03:49:31 +0000 (UTC) To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel , 24594@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 03 05:49:27 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bquFh-0003Jg-B9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Oct 2016 05:49:17 +0200 Original-Received: from localhost ([::1]:33651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bquFf-0000M4-Pv for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2016 23:49:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bquFW-0000K5-QW for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 23:49:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bquFS-00037C-NY for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 23:49:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bquFS-000375-KI for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 23:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bquFS-0001o2-9I for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 23:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2016 03:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24594 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24594-submit@debbugs.gnu.org id=B24594.14754665146893 (code B ref 24594); Mon, 03 Oct 2016 03:49:02 +0000 Original-Received: (at 24594) by debbugs.gnu.org; 3 Oct 2016 03:48:34 +0000 Original-Received: from localhost ([127.0.0.1]:42412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bquF0-0001n7-Gq for submit@debbugs.gnu.org; Sun, 02 Oct 2016 23:48:34 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:42112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bquEx-0001mr-LH for 24594@debbugs.gnu.org; Sun, 02 Oct 2016 23:48:32 -0400 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u933mNAg007210 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Oct 2016 03:48:23 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u933mMDU014724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Oct 2016 03:48:22 GMT Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u933mLnt006706; Mon, 3 Oct 2016 03:48:21 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6753.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123934 Archived-At: > > See http://emacs.stackexchange.com/a/27527/105: the user wants to use a > > different face from face `variable-pitch'. That seems reasonable. >=20 > That's not how I read it. I think they just want to change the look of > Emacs after invoking variable-pitch-mode, and customizing the variable-pi= tch > face seems like the right approach for that. The question as posed is ambiguous, but it specifically asks how to use a d= ifferent face. The answer I gave spoke to both possible interpretations of= the question. > > Please consider adding an optional FACE argument, defaulting to face > > `variable-pitch'. >=20 > I don't really see why the function should be called variable-pitch-mode = any > more. Maybe select-buffer-face? IIUC this wouldn't have anything to do w= ith > variable pitches any more, except for the default value, maybe? Agreed. Unless there is some particular use for limiting the accepted FACE= to variable-pitch faces. In that case, additional logic/control would be = needed. Was there some particular reason that a mode was written specifically for v= ariable-pitch (whether the face `variable-pitch' or variable-pitch faces in= general), rather than providing a mode for any face? If not then agreed: = a name change would be appropriate.