all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: "Clément Pit--Claudel" <clement.pit@gmail.com>, 24594@debbugs.gnu.org
Subject: bug#24594: 24.5; `variable-pitch-mode': accept FACE arg instead of hardcoding the face
Date: Sun, 2 Oct 2016 20:48:19 -0700 (PDT)	[thread overview]
Message-ID: <587cb6c7-44f8-4546-91ee-264416c965d6@default> (raw)
In-Reply-To: <d0251387-49d7-39e4-6b5e-95cf82ef1d6f@gmail.com>

> > See http://emacs.stackexchange.com/a/27527/105: the user wants to use a
> > different face from face `variable-pitch'.  That seems reasonable.
> 
> That's not how I read it.  I think they just want to change the look of
> Emacs after invoking variable-pitch-mode, and customizing the variable-pitch
> face seems like the right approach for that.

The question as posed is ambiguous, but it specifically asks how to use a different face.  The answer I gave spoke to both possible interpretations of the question.

> > Please consider adding an optional FACE argument, defaulting to face
> > `variable-pitch'.
> 
> I don't really see why the function should be called variable-pitch-mode any
> more.  Maybe select-buffer-face? IIUC this wouldn't have anything to do with
> variable pitches any more, except for the default value, maybe?

Agreed.  Unless there is some particular use for limiting the accepted FACE to variable-pitch faces.  In that case, additional logic/control would be needed.

Was there some particular reason that a mode was written specifically for variable-pitch (whether the face `variable-pitch' or variable-pitch faces in general), rather than providing a mode for any face?  If not then agreed: a name change would be appropriate.





  reply	other threads:[~2016-10-03  3:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-03  3:22 bug#24594: 24.5; `variable-pitch-mode': accept FACE arg instead of hardcoding the face Drew Adams
2016-10-03  3:39 ` Clément Pit--Claudel
2016-10-03  3:48   ` Drew Adams [this message]
2016-10-03  7:00     ` Eli Zaretskii
2016-10-05  0:16     ` npostavs
2016-10-05  3:28       ` Drew Adams
2016-10-05 12:29         ` npostavs
2016-10-05 15:14           ` Drew Adams
2016-10-05 15:32             ` Noam Postavsky
2016-10-05 15:51               ` Drew Adams
2016-10-05 21:43                 ` Noam Postavsky
2016-10-06 16:24                   ` Drew Adams
     [not found]   ` <<587cb6c7-44f8-4546-91ee-264416c965d6@default>
     [not found]     ` <<83oa31q5mr.fsf@gnu.org>
2016-10-03 13:36       ` Drew Adams
2016-10-03 14:12         ` Eli Zaretskii
2016-12-07 20:15           ` Glenn Morris
     [not found]   ` <<<587cb6c7-44f8-4546-91ee-264416c965d6@default>
     [not found]     ` <<<83oa31q5mr.fsf@gnu.org>
     [not found]       ` <<3a104ad1-ccf9-4b54-9773-e939d74aaac1@default>
     [not found]         ` <<83d1jhplmf.fsf@gnu.org>
2016-10-03 14:51           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=587cb6c7-44f8-4546-91ee-264416c965d6@default \
    --to=drew.adams@oracle.com \
    --cc=24594@debbugs.gnu.org \
    --cc=clement.pit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.