From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.bugs Subject: bug#16856: [PATCH] Prevent bar cursor overwriting next glyph (bug#16856) Date: Mon, 18 Jul 2016 07:54:03 +0900 Message-ID: <58701B24-4BAC-4B03-B173-AE6F1D3468F3@gmail.com> References: <20160717084232.GA3426@breton.holly.idiocy.org> <20160717135131.GA4810@breton.holly.idiocy.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1468796130 31598 80.91.229.3 (17 Jul 2016 22:55:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Jul 2016 22:55:30 +0000 (UTC) Cc: 16856@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 18 00:55:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bOuxy-0007aK-CJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2016 00:55:18 +0200 Original-Received: from localhost ([::1]:43325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOuxx-00022y-3q for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jul 2016 18:55:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOuxm-00022O-P1 for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 18:55:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOuxi-0006xE-Ns for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 18:55:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOuxi-0006xA-Js for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 18:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bOuxi-0007Z2-F2 for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 18:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Reitter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Jul 2016 22:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: unreproducible Original-Received: via spool by 16856-submit@debbugs.gnu.org id=B16856.146879605428998 (code B ref 16856); Sun, 17 Jul 2016 22:55:02 +0000 Original-Received: (at 16856) by debbugs.gnu.org; 17 Jul 2016 22:54:14 +0000 Original-Received: from localhost ([127.0.0.1]:54900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOuwv-0007Xe-Tg for submit@debbugs.gnu.org; Sun, 17 Jul 2016 18:54:14 -0400 Original-Received: from mail-pf0-f193.google.com ([209.85.192.193]:36153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOuwu-0007XO-7E for 16856@debbugs.gnu.org; Sun, 17 Jul 2016 18:54:12 -0400 Original-Received: by mail-pf0-f193.google.com with SMTP id y134so6038500pfg.3 for <16856@debbugs.gnu.org>; Sun, 17 Jul 2016 15:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IBsYWmVf/12EjaNSyU65Np/p0Z5y5r3SqSlWEkxtMNI=; b=M0KiwPx7AfsEiFlbirQ7A/lMNDxeVBeHsw0misPM4lBtgzJU/LX21PADdOACY2EtQf HrTZrTAAexV/2D+ShyykaNOgcP35BIohgjfsSZ0Gt7+6+gM7O5eWm21RGyxcVC9snSkT BxpP+qptLI6vN97WLdgvf6aCznlETQ8GiqiDJ0IuIEbZOiuKWdZz9kyIxnPp3W+bghGW E1r0O0lDJQKBqtyPHAmjWniLlg8cIa9p+j7so232IF+IKwF6P6PpKiSk7PAnlDZQZu9q OqnKupHwJxC7E7ui16uhZTEZpPU1NNRTcWTYj5r9Qx8O9RTH6cvXUSJNB+iVis4oThC5 gh7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IBsYWmVf/12EjaNSyU65Np/p0Z5y5r3SqSlWEkxtMNI=; b=OC5o2XjKuHjV9fwhLOtUXHw+3l3/p/Mwsj2T1bxa32a0eLAU0kA/tU9f6RLrTQtlgU LAGDK6nLJMMz3bTld4hWhap/s5dZNIr4X3srk2Wg2yLwm0oNWc4bllBbDX+Bgai2fjsM KyWPeXa92nBgfPvv1k+FlCfems3vYFu2g7UA4eNNWDPhASnAcmGYDOTGZ4zlnTat4TiI XY7sSZ2t1CadmCDRRdjPtFPB9qA0E3UlezSuXsFSGs/wL0mQqZARb8fQz8CWCHGBKGgJ sdp5SdXmSa+x4DiRGb7+Iy0A6BbCxYn8UizAzlivp1k/DQSzcMxcQ4cPSNC6+riiQ/l1 mGPQ== X-Gm-Message-State: ALyK8tLZ0x0jNm+cEO71leijBLygIG2lY5QKPv6r3Ejv222m1gezYF851YdYhRJajUO0Uw== X-Received: by 10.98.14.72 with SMTP id w69mr41246702pfi.119.1468796046438; Sun, 17 Jul 2016 15:54:06 -0700 (PDT) Original-Received: from [172.20.10.5] ([110.70.47.70]) by smtp.gmail.com with ESMTPSA id q1sm2668762pfi.93.2016.07.17.15.54.04 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 17 Jul 2016 15:54:05 -0700 (PDT) In-Reply-To: <20160717135131.GA4810@breton.holly.idiocy.org> X-Mailer: Apple Mail (2.3124) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121198 Archived-At: No ill effects with that. What is the glyph at the end of the line? Also, about your patch, it seems like w->phys_cursor_width will then = just be whatever it was before. > On Jul 17, 2016, at 10:51 PM, Alan Third wrote: >=20 > * src/nsterm.m (ns_draw_window_cursor): Test glyph width vs cursor = width > before setting final size. > --- > src/nsterm.m | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/src/nsterm.m b/src/nsterm.m > index a6160ed..8da2ffe 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -2861,7 +2861,10 @@ Note that CURSOR_WIDTH is meaningful only for = (h)bar cursors. > { > if (cursor_width < 1) > cursor_width =3D max (FRAME_CURSOR_WIDTH (f), 1); > - w->phys_cursor_width =3D cursor_width; > + > + /* The bar cursor should never be wider than the glyph. */ > + if (cursor_width < w->phys_cursor_width) > + w->phys_cursor_width =3D cursor_width; > } > /* If we have an HBAR, "cursor_width" MAY specify height. */ > else if (cursor_type =3D=3D HBAR_CURSOR) > --=20 >=20 > And here's a patch to prevent the bar cursor straying into the next = glyph. > --=20 > Alan Third