From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 128ed5c9f17: Add one more mouse-set-point call to functions xref-find-*-at-mouse Date: Thu, 31 Aug 2023 03:54:26 +0300 Message-ID: <583ae120-d016-e9e8-2783-db21c1e018b8@gutov.dev> References: <169344150641.11482.13012085201452768898@vcs2.savannah.gnu.org> <20230831002506.C0C6DC038B5@vcs2.savannah.gnu.org> <87il8wt52f.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40930"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 02:55:24 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbVy0-000AQ0-0b for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 02:55:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbVxA-0008LU-LA; Wed, 30 Aug 2023 20:54:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbVx9-0008LH-9R for emacs-devel@gnu.org; Wed, 30 Aug 2023 20:54:31 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbVx7-0007xs-7J for emacs-devel@gnu.org; Wed, 30 Aug 2023 20:54:31 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BFF885C01B7; Wed, 30 Aug 2023 20:54:28 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 30 Aug 2023 20:54:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1693443268; x=1693529668; bh=5ZttSdWWq9/UZIn9Dto5k0c0QdO6M/lm4nk ZNh/FYVw=; b=kLrEXQfzWJZXHhJFHvEDub71StOCfxhR+MKwaZz7d4G4hjoFY6B EdYwXdLInYvae3DmwSmhe1PYusyjmFmskUjL7tkoaW5ATa0dKSdMTYT2HPeal1mp gGoU7CS7V0Ee4SNGaLB0j5vZIjzhcxUFW58DiPJmVQtOvXlo8vtnohSznnbtRpg+ UE7DtPYVrWZMhBLA+vk3fDEF7KML4GSzVDTnuazYET2hkTlVlWe0uixy4sDfKf7X 1wJGO0q0Bqxfpj8tF1Sjk+ZyU3RDlpgnXwh0sIr7GFURwnWJKxQ4VYxvHj2bG2Nl EhdbNmYhxpfwpDSVRjT4gbPy/pUGOdunLbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1693443268; x= 1693529668; bh=5ZttSdWWq9/UZIn9Dto5k0c0QdO6M/lm4nkZNh/FYVw=; b=Y fnATnUh2Hf/asdpyqVL1yBv+Flt27TvgZDIS50G7aMjYBib0UsEOi3iX/WistOQz JWk+rSHZ6XAN6dCBdx748gh6M/aZAwCdNiEBiB1BlM0BcOx/GD9VShYNX1Mqs351 dmk6zE0kNH0bz6pOpXrUhtyMM1c/H3X1/SSMaQ1enfyDd+Z2DFtoPY3CxJkTxcV1 os55VF/Awm2AHEAC+PRralOhJgvwHB1zjapOltqFCBY++HkmHKcIeOpST8C1M05e qbKjX51h/a91986dr42grAA9NJihxzaW5vU8KQ1ApwC2Cn9mJAqPxS6NVJR/hW+6 Hg0j//IQCs0nzYAeoMLlA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefledgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepgeehtdehudejieetuedttdejkeehje etueekheffuddtjeeuvdefveeuveeiuddunecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Aug 2023 20:54:27 -0400 (EDT) Content-Language: en-US In-Reply-To: <87il8wt52f.fsf@yahoo.com> Received-SPF: pass client-ip=66.111.4.27; envelope-from=dmitry@gutov.dev; helo=out3-smtp.messagingengine.com X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.242, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309569 Archived-At: On 31/08/2023 03:43, Po Lu wrote: > My experience with the entire touch screen affair says that many such > errors would never have been written had `xref-find-definitions' taken > an EVENT argument and used its posn-point if present. Something to > consider, I suppose. Sorry, I don't quite understand which change you have in mind. The issue here was that we needed to move to the click's location both when detecting the identifier (at that point), and before using the identifier to find a set of locations. If we used a POSN value, it would also have to be used in two places, I guess. One of which we could just as easily missed as we had here.