From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix Subject when forwarding message with 2-line From Date: Sat, 27 Nov 2021 07:59:45 -0800 Message-ID: <5817.1638028785@alto> References: <83k0gu15w0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17157"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 27 17:03:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mr0AM-0004GQ-3V for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 17:03:06 +0100 Original-Received: from localhost ([::1]:47760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mr0AK-0000Ok-7G for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 11:03:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mr07K-0007Gy-MG for emacs-devel@gnu.org; Sat, 27 Nov 2021 10:59:58 -0500 Original-Received: from shell1.rawbw.com ([198.144.192.42]:21206) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mr07I-0000zv-T2; Sat, 27 Nov 2021 10:59:58 -0500 Original-Received: from alto (96-95-200-133-static.hfc.comcastbusiness.net [96.95.200.133]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 1ARFxjXV046965 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 27 Nov 2021 07:59:50 -0800 (PST) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 96-95-200-133-static.hfc.comcastbusiness.net [96.95.200.133] claimed to be alto In-Reply-To: Your message of "Sat, 27 Nov 2021 08:15:11 +0200." <83k0gu15w0.fsf@gnu.org> X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 28.0.60 Content-ID: <5816.1638028785.1@alto> Received-SPF: none client-ip=198.144.192.42; envelope-from=mkupfer@alum.berkeley.edu; helo=shell1.rawbw.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280348 Archived-At: Eli Zaretskii wrote: > > From: Mike Kupfer > > Date: Fri, 26 Nov 2021 17:49:18 -0800 > > > > Hi, is the attached patch to MH-E eligible for emacs-28, or should it go > > into master? > > I don't use MH-E, so I don't know how severe is the problem. Can you > tell? I think the argument for fixing it now is this: if the user doesn't notice the problem and fix it before pressing C-c C-c, the attempt to forward can fail (e.g., get bounced by the mail server) because of the messed-up headers, and the user might have a hard time figuring out what happened. On the other hand, I think 2-line From headers are fairly rare. I don't think I've ever hit this bug. Lester (the person thanked in the changeset comment) reported seeing it "once in awhile". It's been on the MH-E bug list (on SourceForge) since 2012. > In any case, isn't the fix more than absolutely necessary? If all you > want is replace newlines with spaces, why not do just that? Or what > am I missing? If mh-forwarded-letter-subject doesn't eat the whitespaces around the newline, you can get a Subject line that looks like Subject: "Some User" : 2-line From It's functional, I suppose, but the ":" is supposed to come immediately after the name ("Some User" here). mike