From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Max Nikulin Newsgroups: gmane.emacs.bugs Subject: bug#66390: `man' allows to inject arbitrary shell code Date: Thu, 11 Jan 2024 21:34:43 +0700 Message-ID: <57f6810f-dd98-4cd0-9580-e0f93b8ee158@gmail.com> References: <83wmvyzir2.fsf@gnu.org> <585dcaf0-358e-4a9d-84d1-6fd9c2c8aec5@gmail.com> <83v8bizf9r.fsf@gnu.org> <1865abb8-16cd-4570-9a8a-87cf9430583d@gmail.com> <875y3iigua.fsf@gmx.de> <83o7hazap7.fsf@gnu.org> <87mswugyoq.fsf@gmx.de> <83jzryz6op.fsf@gnu.org> <87a5sugwcx.fsf@gmx.de> <83h6n2z3tr.fsf@gnu.org> <831qe5znrz.fsf@gnu.org> <262ed9fe-b92b-489d-b1f0-5202bfdb088b@gmail.com> <87il7e78j5.fsf@igel.home> <83h6mksaqp.fsf@gnu.org> <87v880jcok.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18698"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: lx@shellcodes.org, Eli Zaretskii , 66390@debbugs.gnu.org, schwab@linux-m68k.org, michael.albinus@gmx.de To: Ihor Radchenko , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 11 15:35:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNw9T-0004aw-KZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jan 2024 15:35:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNw9C-0006CN-VZ; Thu, 11 Jan 2024 09:35:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNw9A-0006C6-UG for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 09:35:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNw9A-0007ht-J5 for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 09:35:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNw97-0003So-T6 for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 09:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Max Nikulin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jan 2024 14:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66390 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 66390-submit@debbugs.gnu.org id=B66390.170498369313291 (code B ref 66390); Thu, 11 Jan 2024 14:35:01 +0000 Original-Received: (at 66390) by debbugs.gnu.org; 11 Jan 2024 14:34:53 +0000 Original-Received: from localhost ([127.0.0.1]:59154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNw8y-0003SJ-Lk for submit@debbugs.gnu.org; Thu, 11 Jan 2024 09:34:53 -0500 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:54571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNw8v-0003S0-JI for 66390@debbugs.gnu.org; Thu, 11 Jan 2024 09:34:51 -0500 Original-Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2cd84600920so11669771fa.1 for <66390@debbugs.gnu.org>; Thu, 11 Jan 2024 06:34:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704983686; x=1705588486; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=IMK8IpRvY/Eo1pOs0fNQPDD2fWMPfoHZA5+11qKT86E=; b=F6GrwBul4kMHjJkH1gT34mZpLppdKZDeaAgHCmVEqxQxvTpcoyDdagOxV0BEFL4fj5 H4/pj3GdF62UK/Ci8OOEnF1xyHQY1p/blcSCp0dNaQieABDkY2BYt1vSTGkH/GkQfQrL FQrU9TrDfd/syFo+aFD0Ygy2yyH2Xdaf50tZEDvOz2m/dwuH9QY9maGv0lgH7BXKyPI4 mrrLIdYaFeuh+zrbt3wRsh62bFywDxA3K97akxBUyXyXT7z9nwdOMR9cbckbP5UFU/9J pJWun2l3sv4cKYj9i60gIusdRwOhOlJpmr9+fMzsk8LZlZLG+rtTfnsZd6PlAXaNw11x yNPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704983686; x=1705588486; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IMK8IpRvY/Eo1pOs0fNQPDD2fWMPfoHZA5+11qKT86E=; b=TNqXnO3lW9b8RobLLO7/5YNC7KA0kupM9lHBzxm4VUoPjrbXtj4fdKSI8luaegx6ad I2mjIK7jLaOYAHkHmMcYkaPqGMOwvlj3bNg/ui1rUa2FRZXvwh/wnS2FOEsZ1nEyi74u 3DBSDKFtIh93Xy0XHjT+qLbpsYWL2aM/X6dRxRaxoOm7US3nmswrmqrglZzs/kUaPd0f kXu2N7Z7S++9Qy0dqFFlV2b/Xy8hNNCO3o964zV+Uws4dmO7+c5rMPk6kdCb2o7ETV9b jM0jX9eqORnXOUd0s1cSeFhJYbLv2rG87u4OEcoWJ4LGdjcn7KQcnVW8oZoi3MU7WIp5 RmEQ== X-Gm-Message-State: AOJu0YxUtcEuQ7dNYPF6Hy9J+DRCxLtb45j9oY3BG/CEeTu55p6ylgw1 mDpau1XnUSZ4R3OglPTMduU= X-Google-Smtp-Source: AGHT+IGz2WUBBQAkIMTa7gkaw3wRemWVp6S6i82gAsMHdgG1x8zGbyrQ91P5P/tkRDOh4Y07/CPcwA== X-Received: by 2002:ac2:41cd:0:b0:50e:b207:ab46 with SMTP id d13-20020ac241cd000000b0050eb207ab46mr624988lfi.12.1704983685819; Thu, 11 Jan 2024 06:34:45 -0800 (PST) Original-Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id b12-20020a056512218c00b0050e7ec49881sm209640lft.21.2024.01.11.06.34.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 06:34:45 -0800 (PST) Content-Language: en-US, ru-RU In-Reply-To: <87v880jcok.fsf@localhost> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277898 Archived-At: On 11/01/2024 19:07, Ihor Radchenko wrote: > Stefan Kangas writes: > >> OK, I've now installed the change on master (820f0793f0b). I'm tagging >> the bug "security" to make it easier to find for distro maintainers. >> >> Ihor, I'm copying in you as well, in case you want to add a workaround >> for this security-relevant bug to Org mode as well. [...] > Fixed, on bugfix (for the next Org bugfix release). > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=bc3caa8f9 Ihor, I am confused by `org-man-store-link' call in (if (org-man-store-link (equal (Man-translate-references ";id") "\\;id")) Is it intentional? I hope, the following is not an issue: (let ((system-type 'ms-dos)) (shell-quote-argument ";id")) "\";id\"" no "\\;id"