Re: Proposal: font lock for `describe-variable`

["Clément Pit--Claudel" <clement.pit@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1559 bytes --]

I think Eli is pointing out that in every place where you made a modification to the code, you also changed the whitespace.  For example, you untabified all three lines of the following chunk.

-	(setq output
-	      (format "This variable was introduced, or its default value was changed, in\nversion %s of Emacs.\n"
-		      custom-version))
+        (setq output
+              (format "This variable was introduced, or its default value was changed, in version %s of Emacs.\n"
+                      custom-version))

Clément.

On 2016-09-27 23:45, Tianxiang Xiong wrote:
> @Eli I don't know what you mean, then. The diffs in the 0002 version are definitely not due to whitespace changes; I explicitly removed the whitespace-only changes from 0001.
> 
> There /is/ a good amount of refactoring, simply because the previous code was very hard to follow. The new code is ~40 lines shorter and, if I do say so myself, much clearer.
> 
> I've attached the 0002 version again in case there's something wrong with the previous one.
> 
> 2016-09-27 10:40 GMT-07:00 Eli Zaretskii <eliz@gnu.org <mailto:eliz@gnu.org>>:
> 
>     > From: Tianxiang Xiong <tianxiang.xiong@gmail.com <mailto:tianxiang.xiong@gmail.com>>
>     > Date: Tue, 27 Sep 2016 09:30:18 -0700
>     > Cc: emacs-devel@gnu.org <mailto:emacs-devel@gnu.org>, monnier@iro.umontreal.ca <mailto:monnier@iro.umontreal.ca>,
>     >       Clément Pit--Claudel <clement.pit@gmail.com <mailto:clement.pit@gmail.com>>
>     >
>     > Even the 0002 version?
> 
>     Yes.
> 
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]